[3.2][RC] Thanks for posts (and optional Tapatalk integration)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Nov 11, 2017 1:54 pm

jackennils wrote:
Sat Nov 11, 2017 1:22 pm
The contribution you requested could not be found.
:shock:
Yes, seems it cannot be viewed by other than me until approved.

User avatar
david63
Jr. Extension Validator
Posts: 13499
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by david63 » Sat Nov 11, 2017 4:07 pm

Naguissa wrote:
Sat Nov 11, 2017 1:54 pm
Yes, seems it cannot be viewed by other than me until approved.
... and the Extensions Team
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Nov 11, 2017 4:12 pm

david63 wrote:
Sat Nov 11, 2017 4:07 pm
Naguissa wrote:
Sat Nov 11, 2017 1:54 pm
Yes, seems it cannot be viewed by other than me until approved.
... and the Extensions Team
Here could be a good use to "Thanks" extension :D

Yes, of course, "and the Extensions Team".

andreszs
Registered User
Posts: 16
Joined: Sat Aug 19, 2017 11:05 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by andreszs » Sat Nov 11, 2017 11:38 pm

Naguissa wrote:
Sat Nov 11, 2017 4:12 pm
Yes, of course, "and the Extensions Team".
... which told me that it can take up to one month for an extension to get reviewed and approved. My extension to hide content from guests is still waiting.

Anyway, thanks for submitting it, let's hope it gets approved soon so more users can find it.

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sun Nov 12, 2017 10:32 am

:shock:

Well, no problem, as process is in it's way....

User avatar
eunaumtenhoid
Registered User
Posts: 711
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by eunaumtenhoid » Sun Nov 12, 2017 4:52 pm

language files are the same as rxu?
If I translate one will work in the 2?
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sun Nov 12, 2017 5:20 pm

eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should

User avatar
eunaumtenhoid
Registered User
Posts: 711
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by eunaumtenhoid » Sun Nov 12, 2017 5:25 pm

Naguissa wrote:
Sun Nov 12, 2017 5:20 pm
eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should
ok ty
working on it
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sun Nov 12, 2017 5:28 pm

eunaumtenhoid wrote:
Sun Nov 12, 2017 5:25 pm
Naguissa wrote:
Sun Nov 12, 2017 5:20 pm
eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should
ok ty
working on it
Thanks for you! Obrigado!

Bermudez
Registered User
Posts: 65
Joined: Mon Aug 15, 2011 11:56 pm
Location: Spain
Name: Juan Antonio
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Bermudez » Mon Nov 13, 2017 9:08 am

Hello.
Why in this version does you no longer use the Font Awesome Icons?
In this other version (which is perfectly compatible with phpBB 3.2.1) they were used.
If you do not use the Font Awesome Icons I doubt that the phpBB team validates the extension.

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Mon Nov 13, 2017 11:58 am

Bermudez wrote:
Mon Nov 13, 2017 9:08 am
Hello.
Why in this version does you no longer use the Font Awesome Icons?
In this other version (which is perfectly compatible with phpBB 3.2.1) they were used.
If you do not use the Font Awesome Icons I doubt that the phpBB team validates the extension.
This was forked from 3.1 extenison, so in fact thanks/Remove buttons are using Font Awesome added personally.

Stars is a to-do improvement, not done yet because nobody asked for and I don't use it.


About phpBB validation, let's let them decide. I think they look more for PHP bugs, SQL injections and other serious things than about icons.

Bermudez
Registered User
Posts: 65
Joined: Mon Aug 15, 2011 11:56 pm
Location: Spain
Name: Juan Antonio
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Bermudez » Mon Nov 13, 2017 12:12 pm

I did not mean the stars (I do not use them either), I meant to Thanks/Remove thanks button, in which you use images instead of Font Awesome Icons.

Regarding the issue of validation, I said it because the use of Font Awesome Icons is a standard since version 3.2.0 of phpBB. See here at the bottom. in my view, using images instead of Font Awesome Icons would be like taking a step back in the natural evolution of phpBB.
Last edited by Bermudez on Mon Nov 13, 2017 12:34 pm, edited 1 time in total.

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Mon Nov 13, 2017 12:33 pm

Bermudez wrote:
Mon Nov 13, 2017 12:12 pm
I did not mean the stars (I do not use them either), I meant to Thanks/Remove thanks button, in which you use images instead of Font Awesome Icons.

Regarding the issue of validation, I said it because the use of Font Awesome Icons is a standard since version 3.2.0 of phpBB.
As far as I know, this fa-<iconname> stands for FontAwesome--<iconname>....

Image

Bermudez
Registered User
Posts: 65
Joined: Mon Aug 15, 2011 11:56 pm
Location: Spain
Name: Juan Antonio
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Bermudez » Mon Nov 13, 2017 1:09 pm

My conclusion that you use images is based on your file thanks.css respect to the file thanks.css of the other version.

Your thanks.css file:
Image

The thanks.css file of the other version:
Image

Off-topic:
Todavía no entiendo por qué estamos conversando en inglés siendo los dos españoles. :lol:
Last edited by Bermudez on Mon Nov 13, 2017 1:17 pm, edited 1 time in total.

Naguissa
Registered User
Posts: 89
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Mon Nov 13, 2017 1:17 pm

It's a leftover from phpBB 3.1 original extension (the one which this one was forked from), but unused.

I've to do a cleanup version, but after modifiying star rating system for also use FontAwesome.

Then I'll remove all unused icons, CSS and maybe Admin options. Or maybe leave them and use FontAwesome as default (empty value) and let users (forum administrator) choose any image if they want.


Edit: English because this site is english. Yes, it will be more comfortable discuss in spanish, but then we should do it in phpbb-es.com

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: MarkDHamill, Naguissa, Rick8, RomaamoR and 26 guests