[3.2][RC] Thanks for posts (and optional Tapatalk integration)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
eunaumtenhoid
Registered User
Posts: 534
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by eunaumtenhoid » Sun May 21, 2017 3:03 pm

how update of ext 3.1 of rxu?
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sun May 21, 2017 3:32 pm

I didn't saw rxu 3.2 branch, so when this extension is stable I'll try to merge in his one. At this moment I'm not sure 100% it's bug-free (it was working perfectly in my forums but failed because hardcoded path on forums on a subfolder).

BTW, both extensions are directly exchangeable, uses same tables and data, so you could simply replace one by the other (correctly done: disable, replace, enable).

jackennils
Registered User
Posts: 65
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by jackennils » Sun May 21, 2017 5:47 pm

Naguissa wrote:
Sun May 21, 2017 2:53 pm
All of that is strange, have you tried cleaning cache?

I've a production system ( foroelectro.net ) and a local site that is completely bare + this extension (even it doesn't have Tapatalk support) and both work correctly.
  • The composer file is not updated to 3.0.2, it still says 3.0.0
  • About version numbers, well, I was correcting some of them on 3.0.3 (when there's any fix to release such version)
  • When you get a notification for multiple thanks, then there should be no avatar output in the notification at all (http://i.imgur.com/SjaVGfS.png)
  • Avatar comes from PHPBB directly, and should be (on a bare installation): ./styles/prosilver/theme/images/no_avatar.gif
  • In the settings page it says "MOD version: : 2.0.2" (http://i.imgur.com/ffCf5eQ.png)
  • About version numbers, well, I was correcting some of them on 3.0.2 but still I forgot Travis file. So that should not happen on 3.0.2 but still I forgot Travis file.
  • After I removed a thanks, I was not able to re-thank the same post. Simply nothing happened. Is this desired behavior?
  • No. For sure.
  • After clearing a list of thanks, I was not able to re-thank. Desired behavior as well?
  • No. For sure.
Again, Could you reset cache and retest? If bugs continues, please, tell extra info as style, version, extensions which could conflict....



Thanks for the info.
I've cleared the cache multiple times, since I'm using a heavy modified theme on my site, I needed to make lot's of changes. But it's based on this template: https://themeforest.net/item/ariki-phpb ... me/7773806

Besides from that problem, that I cannot re-thank after taking back the thanks or clearing the thanks list, it's working fine.

You can check it out over at https://mydivision.net/forum/

These are all other currently installed extensions:
Image


Edit:
Another thing I noticed: When you don't allow the users to remove their thanks you can still set up notifications for removed thanks. This option should depend on the setting in the ACP.

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat May 27, 2017 6:25 am

Hello,

I had a busy week, but now I could do my tests.
  • I've checked permissions versus actions: When no allowed you cannot do things, even typing correct URL. It says invalid or you cannot...
  • Checked notifications: when an action is forbidden notifications doesn't trigger.
  • Remove thanks settings when option disabled. Can be a feature, but also is a choice, as maybe it's enabled in the future (in that particular board by the admin, I mean).
  • No avatar image: I've checked in your particular board and seems that should work, as no-avatar gif image exists: https://mydivision.net/forum/styles/myd ... avatar.gif -- Could you tell me what image is trying to find?
  • About rethank, is there any message? Maybe any server cache issues, but I really have no idea why this particular error. My local test is working without cache, but my live forum uses memcached.
Thanks.

jackennils wrote:
Sun May 21, 2017 5:47 pm
Naguissa wrote:
Sun May 21, 2017 2:53 pm
All of that is strange, have you tried cleaning cache?

I've a production system ( foroelectro.net ) and a local site that is completely bare + this extension (even it doesn't have Tapatalk support) and both work correctly.
  • The composer file is not updated to 3.0.2, it still says 3.0.0
  • About version numbers, well, I was correcting some of them on 3.0.3 (when there's any fix to release such version)
  • When you get a notification for multiple thanks, then there should be no avatar output in the notification at all (http://i.imgur.com/SjaVGfS.png)
  • Avatar comes from PHPBB directly, and should be (on a bare installation): ./styles/prosilver/theme/images/no_avatar.gif
  • In the settings page it says "MOD version: : 2.0.2" (http://i.imgur.com/ffCf5eQ.png)
  • About version numbers, well, I was correcting some of them on 3.0.2 but still I forgot Travis file. So that should not happen on 3.0.2 but still I forgot Travis file.
  • After I removed a thanks, I was not able to re-thank the same post. Simply nothing happened. Is this desired behavior?
  • No. For sure.
  • After clearing a list of thanks, I was not able to re-thank. Desired behavior as well?
  • No. For sure.
Again, Could you reset cache and retest? If bugs continues, please, tell extra info as style, version, extensions which could conflict....



Thanks for the info.
I've cleared the cache multiple times, since I'm using a heavy modified theme on my site, I needed to make lot's of changes. But it's based on this template: https://themeforest.net/item/ariki-phpb ... me/7773806

Besides from that problem, that I cannot re-thank after taking back the thanks or clearing the thanks list, it's working fine.

You can check it out over at https://mydivision.net/forum/

These are all other currently installed extensions:
Image


Edit:
Another thing I noticed: When you don't allow the users to remove their thanks you can still set up notifications for removed thanks. This option should depend on the setting in the ACP.

jackennils
Registered User
Posts: 65
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by jackennils » Sat May 27, 2017 10:21 am

Naguissa wrote:
Sat May 27, 2017 6:25 am
Hello,

I had a busy week, but now I could do my tests.
No problem. That's how life can be. :)
Naguissa wrote:
Sat May 27, 2017 6:25 am
I've checked permissions versus actions: When no allowed you cannot do things, even typing correct URL. It says invalid or you cannot...
Permission-wise everything is fine.
Naguissa wrote:
Sat May 27, 2017 6:25 am
Checked notifications: when an action is forbidden notifications doesn't trigger.
Correct. But what I was talking about is that even if you do not allow people to remove their Thanks, they can still set up a notification that is triggered when people remove their Thanks. But why should I be able to do this, if it's not even possible? The notification settings should depend on the settings of the extension ifself.
Naguissa wrote:
Sat May 27, 2017 6:25 am
Remove thanks settings when option disabled. Can be a feature, but also is a choice, as maybe it's enabled in the future (in that particular board by the admin, I mean).
If you enable it later, then people will have to check their settings again. Otherwise it's too confusing.
Naguissa wrote:
Sat May 27, 2017 6:25 am
No avatar image: I've checked in your particular board and seems that should work, as no-avatar gif image exists: https://mydivision.net/forum/styles/myd ... avatar.gif -- Could you tell me what image is trying to find?
That's fine. I was trying to say that there should be no image at all in the notification if it comes from multiple users. Just as a small improvement. There is no bug. Just a suggestion.
Naguissa wrote:
Sat May 27, 2017 6:25 am
About rethank, is there any message? Maybe any server cache issues, but I really have no idea why this particular error. My local test is working without cache, but my live forum uses memcached.
No message. No caching besides the phpBB cache. I say thank you, remove the thanks, click the thank-you-thumb-icon again and nothing happens. Absolutely nothing. Does not work with prosilver as well.

User avatar
Luixx
Registered User
Posts: 1
Joined: Sun Jul 02, 2017 3:55 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Luixx » Sun Jul 02, 2017 4:14 am

Excellent work Naguissa, congratulations !!

Image

Tapatalk integration is working perfectly, fully functional with phpBB 3.2

You did a genius job ... do not abandon the project, keep updating Thanks_for_posts and integration with Tapatalk (mobiquo folder) !!


Luixx

User avatar
eunaumtenhoid
Registered User
Posts: 534
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by eunaumtenhoid » Sun Jul 16, 2017 10:48 pm

NICE WORK ty
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Tue Jul 18, 2017 5:25 am

You're welcome. I was on vacations and was not much connected.

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Tue Jul 25, 2017 5:35 am

Tested on PhpBB 3.2.1 -- No problem, as 3.2.0

darkobgd
Registered User
Posts: 12
Joined: Thu Oct 22, 2015 10:03 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by darkobgd » Thu Oct 19, 2017 12:07 pm

Any plans to modify TT plugin for 2.0.4 update?

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Oct 21, 2017 7:50 pm

darkobgd wrote:
Thu Oct 19, 2017 12:07 pm
Any plans to modify TT plugin for 2.0.4 update?
Just found right now new version, I'll update it ASAP.


darkobgd
Registered User
Posts: 12
Joined: Thu Oct 22, 2015 10:03 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by darkobgd » Tue Oct 24, 2017 8:40 am

Thank you, updating right now :)

darkobgd
Registered User
Posts: 12
Joined: Thu Oct 22, 2015 10:03 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by darkobgd » Tue Oct 24, 2017 8:47 am

Hmmm, updated. Notification from forum are completely broken :|

P.S. 2.0.5 is out, maybe because of that?

Naguissa
Registered User
Posts: 48
Joined: Thu Mar 02, 2017 6:55 am
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Wed Oct 25, 2017 4:51 pm

darkobgd wrote:
Tue Oct 24, 2017 8:47 am
Hmmm, updated. Notification from forum are completely broken :|

P.S. 2.0.5 is out, maybe because of that?
It shouldn't, but I'll recheck.

Also, I'll update plugin ASAP. Sad, this version only lasted few days...

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Anuj Dhawan, Binano, Naguissa, remoss, supanet and 26 guests