[3.2][3.3][RC] Thanks for posts (and optional Tapatalk integration)

bcurran3 · Post by **bcurran3** » Sun Mar 18, 2018 12:41 pm

Naguissa wrote: ↑Sun Mar 18, 2018 11:22 am It seems to be something related to ROLES in your phpbb installation. I've not been told about anything similar, and even the code, as far as I remember, doesn't use any role like this. It should be when defining defaults for all roles (from DB, not manually), and that role is damaged in your installation.

I created a new role called ROLE_USER_NOAVATAR and it installed. I don't remember the role. If it's default, I must have deleted it years ago not needing it.

Thanks for the help.

Naguissa · Post by **Naguissa** » Sun Mar 18, 2018 1:02 pm

bcurran3 wrote: ↑Sun Mar 18, 2018 12:41 pm
Naguissa wrote: ↑Sun Mar 18, 2018 11:22 am It seems to be something related to ROLES in your phpbb installation. I've not been told about anything similar, and even the code, as far as I remember, doesn't use any role like this. It should be when defining defaults for all roles (from DB, not manually), and that role is damaged in your installation.
I created a new role called ROLE_USER_NOAVATAR and it installed. I don't remember the role. If it's default, I must have deleted it years ago not needing it.

Thanks for the help.

You are welcome!

Maybe it was created by other extension (or mod if forum is old enougth).

I'm glad it was solved in that easy way.

Naguissa · Post by **Naguissa** » Tue Mar 20, 2018 5:51 am

GitHub user id-tarzanych has improved PosgreSQL compatibiliy. As I cannot test it properly now I merged the changes but still not done a new release. If anyone wants to use it you will need to dowload master of the repository; it has no more changes now.

KlausiMaus · Post by **KlausiMaus** » Tue Mar 20, 2018 8:00 pm

After update from an development Version (date 25.Feb.2018, cannot remember version number), I get the following when I active the extension:

Code: Select all

Zurück zur Foren-Übersicht 
Allgemeiner Fehler
SQL ERROR [ mysqli ]

Table 'phpbb_9.thanks' doesn't exist [1146]

SQL

SELECT MAX(tally) AS max_post_thanks FROM (SELECT post_id, COUNT(*) AS tally FROM thanks GROUP BY post_id) t

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 996
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/gfksx/ThanksForPosts/core/helper.php
LINE: 611
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/gfksx/ThanksForPosts/event/listener.php
LINE: 182
CALL: gfksx\ThanksForPosts\core\helper->array_all_thanks()

FILE: (not given by php)
LINE: (not given by php)
CALL: gfksx\ThanksForPosts\event\listener->viewtopic_handle_thanks()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 184
CALL: call_user_func()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 46
CALL: Symfony\Component\EventDispatcher\EventDispatcher->doDispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 62
CALL: Symfony\Component\EventDispatcher\EventDispatcher->dispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 46
CALL: phpbb\event\dispatcher->dispatch()

FILE: [ROOT]/viewtopic.php
LINE: 1223
CALL: phpbb\event\dispatcher->trigger_event()
Bitte informiere die Board-Administration oder den Webmaster: [email protected]
Powered by phpBB® Forum Software © phpBB Limited

and there is no table "thanks" when I check with MyAdmin!

Uninstall an reinstall does not work, SQL error!

Since it was working fine before and I love this extension, how could i get to work again?

Naguissa · Post by **Naguissa** » Tue Mar 20, 2018 8:06 pm

KlausiMaus wrote: ↑Tue Mar 20, 2018 8:00 pm After update from an development Version (date 25.Mar.2018, cannot remember version number), I get the following when I active the extension:

Code: Select all

Zurück zur Foren-Übersicht 
Allgemeiner Fehler
SQL ERROR [ mysqli ]

Table 'phpbb_9.thanks' doesn't exist [1146]

SQL

SELECT MAX(tally) AS max_post_thanks FROM (SELECT post_id, COUNT(*) AS tally FROM thanks GROUP BY post_id) t

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 996
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/gfksx/ThanksForPosts/core/helper.php
LINE: 611
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/gfksx/ThanksForPosts/event/listener.php
LINE: 182
CALL: gfksx\ThanksForPosts\core\helper->array_all_thanks()

FILE: (not given by php)
LINE: (not given by php)
CALL: gfksx\ThanksForPosts\event\listener->viewtopic_handle_thanks()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 184
CALL: call_user_func()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 46
CALL: Symfony\Component\EventDispatcher\EventDispatcher->doDispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 62
CALL: Symfony\Component\EventDispatcher\EventDispatcher->dispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 46
CALL: phpbb\event\dispatcher->dispatch()

FILE: [ROOT]/viewtopic.php
LINE: 1223
CALL: phpbb\event\dispatcher->trigger_event()
Bitte informiere die Board-Administration oder den Webmaster: [email protected]
Powered by phpBB® Forum Software © phpBB Limited

and there is no table "thanks" when I check with MyAdmin!

Uninstall an reinstall does not work, SQL error!

Since it was working fine before and I love this extension, how could i get to work again?

Seems there's config on DB but no data.

It's supposed to be any old data there? Because it seems it's lost....

If not, I'll retrieve a list of data to clean from database about old installations in an hour aprox.

KlausiMaus · Post by **KlausiMaus** » Tue Mar 20, 2018 8:16 pm

Thanks to your fast reaction

Where to look for old DB data?
I told you already there is no table "thanks"

Naguissa · Post by **Naguissa** » Tue Mar 20, 2018 8:29 pm

KlausiMaus wrote: ↑Tue Mar 20, 2018 8:16 pm Thanks to your fast reaction
Where to look for old DB data?
I told you already there is no table "thanks"

YW.

Ol configs and permissions, I'm grabbing a set.,.

Naguissa · Post by **Naguissa** » Tue Mar 20, 2018 9:39 pm

KlausiMaus wrote: ↑Tue Mar 20, 2018 8:16 pm Thanks to your fast reaction
Where to look for old DB data?
I told you already there is no table "thanks"

I have no time to correlate tables & fields with all (possible) data.

This is a categorized set of any kind of config used in all extension life, so any version can be tracked from this:

Code: Select all

tables:
	thanks

config.add:
	thanks_for_posts_version  <=== Most important!
	remove_thanks
	thanks_postlist_view
	thanks_profilelist_view
	thanks_counters_view
	thanks_number
	thanks_info_page
	thanks_only_first_post
	thanks_for_posts_version
	thanks_number_post
	thanks_post_reput_view
	thanks_topic_reput_view
	thanks_forum_reput_view
	thanks_reput_height
	thanks_reput_level
	thanks_number_digits
	thanks_number_row_reput
	thanks_reput_graphic
	thanks_reput_image
	thanks_reput_image_back
	thanks_time_view
	thanks_top_number
	thanks_forum_reput_view_column
	thanks_topic_reput_view_column
	thanks_global_announce
	thanks_global_post
	thanks_post_view_guests
	thanks_post_view_robots





permission.add:
	f_thanks
	u_viewthanks
	u_viewtoplist
	m_thanks


permission.permission_set
	role ROLE_USER_STANDARD, u_viewthanks
	group REGISTERED, u_viewthanks
	role ROLE_FORUM_STANDARD, f_thanks
	group REGISTERED, u_viewtoplist
	role ROLE_USER_STANDARD, u_viewtoplist
	role ROLE_MOD_FULL, m_thanks
	group GLOBAL_MODERATORS, m_thanks
	role ROLE_FORUM_FULL, f_thanks
	role ROLE_FORUM_FULL, f_thanks
	role ROLE_FORUM_POLLS, f_thanks
	role ROLE_FORUM_LIMITED, f_thanks
	role ROLE_FORUM_LIMITED_POLLS, f_thanks
	role ROLE_USER_FULL, u_viewtoplist
	role ROLE_USER_LIMITED, u_viewtoplist
	role ROLE_USER_NOPM, u_viewtoplist
	role ROLE_USER_NOAVATAR, u_viewtoplist
	role ROLE_USER_FULL, u_viewthanks
	role ROLE_USER_LIMITED, u_viewthanks
	role ROLE_USER_NOPM, u_viewthanks
	role ROLE_USER_NOAVATAR, u_viewthanks



module.remove
	acp, ACP_MESSAGES, ACP_THANKS
	acp, ACP_CAT_DOT_MODS, ACP_THANKS
	acp, ACP_THANKS_SETTINGS, ACP_THANKS
	acp, ACP_THANKS_REFRESH, ACP_THANKS
	acp, ACP_THANKS_TRUNCATE, ACP_THANKS
	acp, ACP_THANKS_REPUT_SETTINGS, ACP_THANKS


notifications:
	gfksx.thanksforposts.notification.type.thanks
	gfksx.thanksforposts.notification.type.thanks_remove

To ensure installation works all this data should be missing. Or in a correct state in order to use it or update it.

KlausiMaus · Post by **KlausiMaus** » Tue Mar 20, 2018 10:38 pm

Thanks, I restored the table "thanks" in the database and it works now perfect

Thanks a lot

Naguissa · Post by **Naguissa** » Wed Mar 21, 2018 8:06 am

KlausiMaus wrote: ↑Tue Mar 20, 2018 10:38 pm Thanks, I restored the table "thanks" in the database and it works now perfect
Thanks a lot

Seems that thanks table was deleted but "delete data" was not correctly executed on old version. Remember that if you want cleanly uninstall and delete an extension you need to "Delete data" on extension prior to delete its files.

Manually removing tables leads you to this kind of errors, because the extension has its data but also data inside phpbb, as permissions and configurations.

KlausiMaus · Post by **KlausiMaus** » Wed Mar 21, 2018 8:18 am

Seems that thanks table was deleted but "delete data" was not correctly executed on old version. Remember that if you want cleanly uninstall and delete an extension you need to "Delete data" on extension prior to delete its files.

Manually removing tables leads you to this kind of errors, because the extension has its data but also data inside phpbb, as permissions and configurations.

Sorry, I never manually deleted the table! Don't know how it happened .

Naguissa · Post by **Naguissa** » Wed Mar 21, 2018 8:22 am

KlausiMaus wrote: ↑Wed Mar 21, 2018 8:18 am
Seems that thanks table was deleted but "delete data" was not correctly executed on old version. Remember that if you want cleanly uninstall and delete an extension you need to "Delete data" on extension prior to delete its files.

Manually removing tables leads you to this kind of errors, because the extension has its data but also data inside phpbb, as permissions and configurations.
Sorry, I never manually deleted the table! Don't know how it happened .

Yes, no problem for me (for you... well, it's just that problem).

It's an advice for any extension, not specific for this one.

GOLX · Post by **GOLX** » Sat Mar 24, 2018 8:19 pm

Hello Naguissa,

Thanks so much for these increrible extention! it bring power for all board.

I just have a ask. I can not simulate this situation in the demo: What happens if a post has a 200 thanks to author? Are all these two hundred users names listed in the post? Or is there some way to hide the names list if there are many users who thank you the author?

I ll be very grateful for your help

Thank you

Naguissa · Post by **Naguissa** » Sat Mar 24, 2018 9:21 pm

GOLX wrote: ↑Sat Mar 24, 2018 8:19 pm Hello Naguissa,

Thanks so much for these increrible extention! it bring power for all board.

I just have a ask. I can not simulate this situation in the demo: What happens if a post has a 200 thanks to author? Are all these two hundred users names listed in the post? Or is there some way to hide the names list if there are many users who thank you the author?

I ll be very grateful for your help

Thank you

You are welcome

No, you have an option in ACP to choose how many thanks are displayed in messages. I currently have 25 but you can choose any value.

GOLX · Post by **GOLX** » Sat Mar 24, 2018 9:35 pm

Naguissa wrote: ↑Sat Mar 24, 2018 9:21 pm
You are welcome

No, you have an option in ACP to choose how many thanks are displayed in messages. I currently have 25 but you can choose any value.

Icrerible !!! thanks so much!
I thought in all for it be perfect

Thanks so much, i ll try