3Di wrote: ↑Fri May 19, 2017 10:58 pm
Naguissa wrote: ↑Fri May 19, 2017 2:04 pm
Oh, I didn't saw that branch! I picked original code from master, thinking it was abandoned (or mostly abandoned).
FWIW. did you ask
rxu before to try and use its code and efforts?
The author is quite active here.
No, I thougth it was abandoned. I'm also not an active user here. I simply had a need and solved it.
I'm talking with him now and I'll merge the repos when I have some time.
3Di wrote: ↑Fri May 19, 2017 10:58 pm
Naguissa wrote: ↑Fri May 19, 2017 1:40 pm
I had trouble updating from old mod to rxu extension when I migrated to phpbb 3.1. I had to remove some of migrations and clean permissions manually.
Permissions issues have been well dealt with in the original
rxu's topic.
It was hard because there were several Thanks for posts MOD versions available. It was quite time ago, I don't remember it clearly, but I think I solved it removing some migrations and doing that manually.
But it was a MOD to EXT problem, nothing related to EXT itself.
3Di wrote: ↑Fri May 19, 2017 10:58 pm
And last but not least, sincerely you have no chances IMHO to get the "crap-a-talk" stuff validated here, I am assuming you are bound to submit this to the CDB?
I am not meant to ruin a party, but..
- Tapatalk changes have nothing to do with extensions.
- Tapatalk code is independent of extension and it's in other repo. It's not needed to extension to work.
- Tapatalk changes are made to Tapatalk code itself. Core remains unchanged.
- That changes have been made available to Tapatalk through a support ticket.
- I think there's a very small change on extension itself, but something like a function or parameter change, to support Tapatalk calls.
- Tapatalk code is NOT intended to be accepted as extension. In fact, it's not a extension.
jackennils wrote: ↑Fri May 19, 2017 11:28 pm
I bet this can be released to the CDB without the Tapatalk part which can be offered separately, right?
You are right.
jackennils wrote: ↑Fri May 19, 2017 11:28 pm
Anyway, one more request, Naguissa. Any chance of removing all those images from the extension and replacing them with font awesome icons? With 3.2 there's no need for image icons. What do you think?
Mainly it's leftovers. At least, topic buttons are made with font awesome. Yes, I will have to do some cleaning.