Page 33 of 36

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Thu Feb 14, 2019 2:46 pm
by Naguissa
buzuc wrote:
Thu Feb 14, 2019 2:30 pm
Hi Naguissa,

first of all : Thanks for the 3.2 version, it's a functionnality that my members and I are using a lot!
The extension is working fine: giving thanks OK, display of thanks given and received OK, counters OK.

I have an issue though, It appears after upgrading my forum from 3.1 to 3.2: The links to the lists of thanks are leading to a 404 error.

For example, the link to the "Top 10" at the bottom of the forum is

Code: Select all

https://www.maquettes-papier.net/forumenpapier/thankslist
The link "Thanks given" in the member information is

Code: Select all

https://www.maquettes-papier.net/forumenpapier/thankslist/givens/2/true
and so on...

I tried to find a fix and the only thing I see is my modification of the httacess. But that modification was already there with my board in 3.1...

Any thoughts?

Regards

It seems you are using Apache web server.

If you have mod_rewrite enabled, check phpBB 3.2 ".htaccess" file, as it seems to have problems.

If you don't have mod_rewrite enabled, you should disable "Rewrite URLs" on phpBB site config on ACP.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Thu Feb 14, 2019 3:06 pm
by buzuc
I disabled the rewrite url in the ACP and it's working fine now. Unfortunately the urls for the rest of the forum are now changed as well (obviously).

I will try to play with the rewrite rules in the htaccess and see where it leads.

thanks for the help

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Thu Feb 14, 2019 3:27 pm
by Naguissa
buzuc wrote:
Thu Feb 14, 2019 3:06 pm
I disabled the rewrite url in the ACP and it's working fine now. Unfortunately the urls for the rest of the forum are now changed as well (obviously).

I will try to play with the rewrite rules in the htaccess and see where it leads.

thanks for the help
I suggest you to check your actual .htaccess to a new download of phpBB 3.2 one. I use nginx and rules are coded differently, but I think you miss the equivalent to this one:

Code: Select all

if (!-e $request_filename) {
      rewrite ^(.*)$ /app.php;
    }
It redirects any not found request to phpBB's app.php file.


Now that I think of it... you may try clearing cache first....

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Thu Feb 14, 2019 4:24 pm
by buzuc
That's exactly what I'm doing right now: rewrite my htaccess based on a "out of the box" one from phpbb3.2
Now that I think of it... you may try clearing cache first....
that's what I do each time I change something on my board

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Fri Feb 22, 2019 2:24 pm
by meisterberger
Looks like just what I'm looking for.
Any known security risks with this extension?

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Fri Feb 22, 2019 10:05 pm
by Naguissa
meisterberger wrote:
Fri Feb 22, 2019 2:24 pm
Looks like just what I'm looking for.
Any known security risks with this extension?
None reported or that I'm aware of....

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Thu Feb 28, 2019 12:49 pm
by andreask
I'm really sorry if that question(s) has already been answered...

I have the rxu's ext (Thanks for posts) installed on my 3.2.5 board with the extra ext for the "Addon for Thanks for posts"(no page refresh on like).

So here are my questions...
  • How is this ext differs from rxu's (besides the tapatalk integration)
  • If I disable rxu's ext and install this one will it use the already existing thanks of the users or it will start from the beginning?
  • Wouldn't it be better/easier to have a ext like the "Addon for Thanks for posts" (no page refresh on like) for tapatalk as well?
Thank you!

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Tue Mar 05, 2019 11:41 am
by Naguissa
andreask wrote:
Thu Feb 28, 2019 12:49 pm
I'm really sorry if that question(s) has already been answered...

I have the rxu's ext (Thanks for posts) installed on my 3.2.5 board with the extra ext for the "Addon for Thanks for posts"(no page refresh on like).

So here are my questions...
  • How is this ext differs from rxu's (besides the tapatalk integration)
At the beginnit, it was a 3.2 port of rxu's main branch. Then I added Tapatalk support. Not they've evolved separately, integrating minor different options and glyphs usages.

Still, core functionality is the same, but now they differ in a lot of details.

andreask wrote:
Thu Feb 28, 2019 12:49 pm
  • If I disable rxu's ext and install this one will it use the already existing thanks of the users or it will start from the beginning?

Last time I looked for this, one or two months ago, we were still using same tables. It should be compatible.

andreask wrote:
Thu Feb 28, 2019 12:49 pm
  • Wouldn't it be better/easier to have a ext like the "Addon for Thanks for posts" (no page refresh on like) for tapatalk as well?
Yes, but I needed a phpBB 3.2 version of the extension and didn't saw an existing development branch in rxu's repository. Then I devoloped more options suiting my needs (i.e.: change images for FontAwesome glyphs).
andreask wrote:
Thu Feb 28, 2019 12:49 pm
Thank you!
You are welcome!

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Wed Mar 06, 2019 6:05 am
by skybound
Great mod Naguissa.

Two questions:
  • How is the rating calculated
  • The screenshots on the opening post has a shot with a heart on it (assume instead of thumbs up)- what theme is that?

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Wed Mar 06, 2019 7:02 am
by Naguissa
skybound wrote:
Wed Mar 06, 2019 6:05 am
Great mod Naguissa.
[/list]
Well, it's only a fork of rxu's extension, and that one was a conversion from Палыч 's mod....

Thanks anyway.
skybound wrote:
Wed Mar 06, 2019 6:05 am
Two questions:
  • How is the rating calculated
current thanks / max_thanks_from_same_element_type

i.e.:
score = thaks of this post / max number of thanks in any post
score = thaks of this thread / max number of thanks in any thread
[...]
skybound wrote:
Wed Mar 06, 2019 6:05 am
  • The screenshots on the opening post has a shot with a heart on it (assume instead of thumbs up)- what theme is that?
If it's the mobile display (you can see a black bar with back soft-button on bottom) it's Tapatalk Android 4.1 app from long time ago. I'm still using my 5.5 years old Jolla Sailfish OS phone that has compatibility with 4.1 Android.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Wed Mar 06, 2019 12:20 pm
by Ticinoforum
I made language file for italian.
How can I post it? Where I can send it?

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Wed Mar 06, 2019 1:38 pm
by Naguissa
Ticinoforum wrote:
Wed Mar 06, 2019 12:20 pm
I made language file for italian.
How can I post it? Where I can send it?
You can use GitHub, here (if it's available or via PM) or you can send an email to naguissa@foroelectro.net

Thanks!

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Wed Mar 06, 2019 5:58 pm
by Ticinoforum
Naguissa wrote:
Wed Mar 06, 2019 1:38 pm
You can use GitHub, here (if it's available or via PM) or you can send an email to naguissa@foroelectro.net
Thanks!
Will do tomorrow morning, ASAP.
Thanks.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Mar 10, 2019 11:08 am
by Ticinoforum
A recent "problem" with member list, made me notice one thing.
On the "toplist" of [Thanks for posts] extension, permission "Can see hidden users" is not respected.
I try to better explain:
If board is settled with "Can see hidden users" at No, the column "last action" of the "toplist" should be hidden as well.
Like in board member list.
If a user can see "last action" of other users, it's a way to know that a user is online and this is like a bypass of the board permission setting.
In my opinion it should be corrected checking the "u_viewonline" flag like in "memberlist.php".

I'ts that clear?

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Mar 10, 2019 4:55 pm
by Naguissa
Ticinoforum wrote:
Sun Mar 10, 2019 11:08 am
A recent "problem" with member list, made me notice one thing.
On the "toplist" of [Thanks for posts] extension, permission "Can see hidden users" is not respected.
I try to better explain:
If board is settled with "Can see hidden users" at No, the column "last action" of the "toplist" should be hidden as well.
Like in board member list.
If a user can see "last action" of other users, it's a way to know that a user is online and this is like a bypass of the board permission setting.
In my opinion it should be corrected checking the "u_viewonline" flag like in "memberlist.php".

I'ts that clear?
Cristal clear! I'll check ASAP and add italian translation (thanks!)