Page 5 of 39

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sat Nov 11, 2017 1:54 pm
by Naguissa
jackennils wrote:
Sat Nov 11, 2017 1:22 pm
The contribution you requested could not be found.
:shock:
Yes, seems it cannot be viewed by other than me until approved.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sat Nov 11, 2017 4:07 pm
by david63
Naguissa wrote:
Sat Nov 11, 2017 1:54 pm
Yes, seems it cannot be viewed by other than me until approved.
... and the Extensions Team

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sat Nov 11, 2017 4:12 pm
by Naguissa
david63 wrote:
Sat Nov 11, 2017 4:07 pm
Naguissa wrote:
Sat Nov 11, 2017 1:54 pm
Yes, seems it cannot be viewed by other than me until approved.
... and the Extensions Team
Here could be a good use to "Thanks" extension :D

Yes, of course, "and the Extensions Team".

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sat Nov 11, 2017 11:38 pm
by andreszs
Naguissa wrote:
Sat Nov 11, 2017 4:12 pm
Yes, of course, "and the Extensions Team".
... which told me that it can take up to one month for an extension to get reviewed and approved. My extension to hide content from guests is still waiting.

Anyway, thanks for submitting it, let's hope it gets approved soon so more users can find it.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Nov 12, 2017 10:32 am
by Naguissa
:shock:

Well, no problem, as process is in it's way....

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Nov 12, 2017 4:52 pm
by eunaumtenhoid
language files are the same as rxu?
If I translate one will work in the 2?

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Nov 12, 2017 5:20 pm
by Naguissa
eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Nov 12, 2017 5:25 pm
by eunaumtenhoid
Naguissa wrote:
Sun Nov 12, 2017 5:20 pm
eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should
ok ty
working on it

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Sun Nov 12, 2017 5:28 pm
by Naguissa
eunaumtenhoid wrote:
Sun Nov 12, 2017 5:25 pm
Naguissa wrote:
Sun Nov 12, 2017 5:20 pm
eunaumtenhoid wrote:
Sun Nov 12, 2017 4:52 pm
language files are the same as rxu?
If I translate one will work in the 2?
Yes. And yes, it should
ok ty
working on it
Thanks for you! Obrigado!

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 9:08 am
by Bermudez
Hello.
Why in this version does you no longer use the Font Awesome Icons?
In this other version (which is perfectly compatible with phpBB 3.2.1) they were used.
If you do not use the Font Awesome Icons I doubt that the phpBB team validates the extension.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 11:58 am
by Naguissa
Bermudez wrote:
Mon Nov 13, 2017 9:08 am
Hello.
Why in this version does you no longer use the Font Awesome Icons?
In this other version (which is perfectly compatible with phpBB 3.2.1) they were used.
If you do not use the Font Awesome Icons I doubt that the phpBB team validates the extension.
This was forked from 3.1 extenison, so in fact thanks/Remove buttons are using Font Awesome added personally.

Stars is a to-do improvement, not done yet because nobody asked for and I don't use it.


About phpBB validation, let's let them decide. I think they look more for PHP bugs, SQL injections and other serious things than about icons.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 12:12 pm
by Bermudez
I did not mean the stars (I do not use them either), I meant to Thanks/Remove thanks button, in which you use images instead of Font Awesome Icons.

Regarding the issue of validation, I said it because the use of Font Awesome Icons is a standard since version 3.2.0 of phpBB. See here at the bottom. in my view, using images instead of Font Awesome Icons would be like taking a step back in the natural evolution of phpBB.

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 12:33 pm
by Naguissa
Bermudez wrote:
Mon Nov 13, 2017 12:12 pm
I did not mean the stars (I do not use them either), I meant to Thanks/Remove thanks button, in which you use images instead of Font Awesome Icons.

Regarding the issue of validation, I said it because the use of Font Awesome Icons is a standard since version 3.2.0 of phpBB.
As far as I know, this fa-<iconname> stands for FontAwesome--<iconname>....

Image

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 1:09 pm
by Bermudez
My conclusion that you use images is based on your file thanks.css respect to the file thanks.css of the other version.

Your thanks.css file:
Image

The thanks.css file of the other version:
Image

Off-topic:
Todavía no entiendo por qué estamos conversando en inglés siendo los dos españoles. :lol:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Posted: Mon Nov 13, 2017 1:17 pm
by Naguissa
It's a leftover from phpBB 3.1 original extension (the one which this one was forked from), but unused.

I've to do a cleanup version, but after modifiying star rating system for also use FontAwesome.

Then I'll remove all unused icons, CSS and maybe Admin options. Or maybe leave them and use FontAwesome as default (empty value) and let users (forum administrator) choose any image if they want.


Edit: English because this site is english. Yes, it will be more comfortable discuss in spanish, but then we should do it in phpbb-es.com