[BETA] Official Extension: Advertisement Management

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
janus_zonstraal
Registered User
Posts: 1376
Joined: Sat Aug 30, 2014 1:30 pm

Re: [BETA] Official Extension: Advertisement Management

Post by janus_zonstraal » Tue Aug 08, 2017 1:17 pm

cspld wrote:
Tue Aug 08, 2017 12:58 pm
Hello, I have a problem with the extension

Code: Select all

Unknown column 'ad_views_limit' in 'field list' [1054]
When, which version?
phpbb version?
Sorry! My English is bat ;) !!!

cspld
Registered User
Posts: 5
Joined: Tue Mar 29, 2016 8:37 pm

Re: [BETA] Official Extension: Advertisement Management

Post by cspld » Tue Aug 08, 2017 2:03 pm

When, which version? - https://github.com/phpbb-extensions/ad-management
phpbb version - 3.2.1

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 1776
Joined: Sat Sep 10, 2011 7:12 pm
Contact:

Re: [BETA] Official Extension: Advertisement Management

Post by kasimi » Tue Aug 08, 2017 2:06 pm

cspld wrote:
Tue Aug 08, 2017 12:58 pm
Hello, I have a problem with the extension

Code: Select all

Unknown column 'ad_views_limit' in 'field list' [1054]
Disable and enable the extension to make sure all migrations have run.

cspld
Registered User
Posts: 5
Joined: Tue Mar 29, 2016 8:37 pm

Re: [BETA] Official Extension: Advertisement Management

Post by cspld » Tue Aug 08, 2017 6:43 pm

I can not stop the extension of bb3mobi. Maybe because of this it gives mistakes
https://imgur.com/sefrO79

Senky
Jr. Extension Validator
Posts: 1315
Joined: Thu Apr 30, 2009 8:49 pm
Location: Slovakia
Name: Jakub

Re: [BETA] Official Extension: Advertisement Management

Post by Senky » Wed Aug 09, 2017 6:07 am

cspld wrote:
Tue Aug 08, 2017 6:43 pm
I can not stop the extension of bb3mobi. Maybe because of this it gives mistakes
https://imgur.com/sefrO79
Oh, those 2 extensions are not compatible. You need to disable (and delete data) of the old one to be able to enable new one.

cspld
Registered User
Posts: 5
Joined: Tue Mar 29, 2016 8:37 pm

Re: [BETA] Official Extension: Advertisement Management

Post by cspld » Wed Aug 09, 2017 1:46 pm

Not fashionable to uninstall, gives eros. https://imgur.com/sefrO79

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 20096
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [BETA] Official Extension: Advertisement Management

Post by RMcGirr83 » Wed Aug 09, 2017 2:58 pm

Try uninstalling and deleting the data for both.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Senky
Jr. Extension Validator
Posts: 1315
Joined: Thu Apr 30, 2009 8:49 pm
Location: Slovakia
Name: Jakub

Re: [BETA] Official Extension: Advertisement Management

Post by Senky » Wed Aug 09, 2017 3:45 pm

cspld wrote:
Wed Aug 09, 2017 1:46 pm
Not fashionable to uninstall, gives eros. https://imgur.com/sefrO79
That's probably because installation went wrong with already existing module. Now, you probably need to manually delete the modules from your board. Please, head to general support if you are not sure how to do it.

Senky
Jr. Extension Validator
Posts: 1315
Joined: Thu Apr 30, 2009 8:49 pm
Location: Slovakia
Name: Jakub

Re: [BETA] Official Extension: Advertisement Management

Post by Senky » Wed Aug 09, 2017 3:50 pm

Everyone,
it's good to know your ad is not rogue, right? We have just implemented so-called "Ad code analyser" which checks for basic errors your code can have, such as redirect user to another page, popping alerts, generating "Mixed content" browser errors, etc. If you have any other checks in mind, please, let us know - we would like to have this analyser as powerful as possible!

https://github.com/phpbb-extensions/ad-management

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4410
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [BETA] Official Extension: Advertisement Management

Post by VSE » Fri Aug 11, 2017 3:44 am

Way2Vet wrote:
Mon Aug 07, 2017 5:14 pm
EDIT:
The XSS_ERROR is only related to the latest Chrome-build. I used Opera and FireFox and could preview the ads perfectly without any errors occuring.

After I had a little deeper look into what's wrong with ads not showing up, I figured out that - because I am using responsive Ads - there was a problem that only had to do with AdSense and NOT this extension. The error was that the responsive ad was not able to get the width and height available for it (or at least needed a definition how much space it could take depending on the screen resolution). Therefore the Ad-Code had to be adapted as following:

Instead of the code provided by AdSense themselves:

Code: Select all

<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<!-- Before_First_Post -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-1234567"
     data-ad-slot="8910"
     data-ad-format="auto"></ins>
<script>
(adsbygoogle = window.adsbygoogle || []).push({});
</script>

I had to use the "style"-Tag as you can find many of such solutions by searching the internet:

Code: Select all

<style type="text/css">
.adslot_ID_X{ display:inline-block; width: 320px; height: 50px; }
@media (max-width: 400px) { .adslot_ID_X { width:200px; 30px; } }
@media (min-width:500px) { .adslot_ID_X { width: 468px; height: 60px; } }
@media (min-width:800px) { .adslot_ID_X { width: 728px; height: 90px; } }
</style>
<ins class="adsbygoogle adslot_ID_X"
   data-ad-client="ca-pub-1234567"
   data-ad-slot="8910"></ins>
<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>
I am testing the extension now live. Big Thanks again to the devs for their efforts :!:
This doesn't solve anything for me when previewing Adsense in Chrome. This error is in fact a bit of extra security in Chrome to prevent cross site injections. It's a little too strng though and thinks Google Adsense is a security issue, even though the admin actually wants to add it. So a proper solution will probably need to be found internally to prevent this.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.
Dictated but not read.

Way2Vet
Registered User
Posts: 20
Joined: Tue Jun 01, 2010 10:25 am

Re: [BETA] Official Extension: Advertisement Management

Post by Way2Vet » Fri Aug 11, 2017 7:09 am

VSE wrote:
Fri Aug 11, 2017 3:44 am
This doesn't solve anything for me when previewing Adsense in Chrome.
Sorry. I wasn't clear about it as it seems. I had two problems. One was Chrome preventing me previewing ads. And the other one was, that there did not show up any ads.
Because I wasn't sure at first if one problem causes the other I had a look at it and found out that AdSense uses some kind of Javascript to get the max width and height for the ad to show, but wasn't able to get it (alltough the exact same code worked on the other extension I used before).
So to make sure the ad code works - I posted this code examples.

Chrome still prevents me from previewing the ads. Whereas Opera or Firefox now show the ads (which I did not see before, because of the issue I mentioned above).

Sorry for the misunderstanding :roll:

goodking
Registered User
Posts: 3
Joined: Wed Aug 16, 2017 5:12 pm

Re: [BETA] Official Extension: Advertisement Management

Post by goodking » Tue Aug 22, 2017 10:00 am

The View counts does not work for me. I have several visitors at www.biafraforum.com but after a while, I had to disable it.

I used an image banner and Popup option for the ad. It shows properly but the views does not count.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: canonknipser, Chrono, dimetrius, Hippie459MN, Meis2M and 33 guests

cron