Page 8 of 11

Re: [BETA] Official Extension: Advertisement Management

Posted: Tue Aug 08, 2017 2:03 pm
by cspld
When, which version? - https://github.com/phpbb-extensions/ad-management
phpbb version - 3.2.1

Re: [BETA] Official Extension: Advertisement Management

Posted: Tue Aug 08, 2017 2:06 pm
by kasimi
cspld wrote:
Tue Aug 08, 2017 12:58 pm
Hello, I have a problem with the extension

Code: Select all

Unknown column 'ad_views_limit' in 'field list' [1054]
Disable and enable the extension to make sure all migrations have run.

Re: [BETA] Official Extension: Advertisement Management

Posted: Tue Aug 08, 2017 6:43 pm
by cspld
I can not stop the extension of bb3mobi. Maybe because of this it gives mistakes
https://imgur.com/sefrO79

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 09, 2017 6:07 am
by Senky
cspld wrote:
Tue Aug 08, 2017 6:43 pm
I can not stop the extension of bb3mobi. Maybe because of this it gives mistakes
https://imgur.com/sefrO79
Oh, those 2 extensions are not compatible. You need to disable (and delete data) of the old one to be able to enable new one.

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 09, 2017 1:46 pm
by cspld
Not fashionable to uninstall, gives eros. https://imgur.com/sefrO79

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 09, 2017 2:58 pm
by RMcGirr83
Try uninstalling and deleting the data for both.

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 09, 2017 3:45 pm
by Senky
cspld wrote:
Wed Aug 09, 2017 1:46 pm
Not fashionable to uninstall, gives eros. https://imgur.com/sefrO79
That's probably because installation went wrong with already existing module. Now, you probably need to manually delete the modules from your board. Please, head to general support if you are not sure how to do it.

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 09, 2017 3:50 pm
by Senky
Everyone,
it's good to know your ad is not rogue, right? We have just implemented so-called "Ad code analyser" which checks for basic errors your code can have, such as redirect user to another page, popping alerts, generating "Mixed content" browser errors, etc. If you have any other checks in mind, please, let us know - we would like to have this analyser as powerful as possible!

https://github.com/phpbb-extensions/ad-management

Re: [BETA] Official Extension: Advertisement Management

Posted: Fri Aug 11, 2017 3:44 am
by VSE
Way2Vet wrote:
Mon Aug 07, 2017 5:14 pm
EDIT:
The XSS_ERROR is only related to the latest Chrome-build. I used Opera and FireFox and could preview the ads perfectly without any errors occuring.

After I had a little deeper look into what's wrong with ads not showing up, I figured out that - because I am using responsive Ads - there was a problem that only had to do with AdSense and NOT this extension. The error was that the responsive ad was not able to get the width and height available for it (or at least needed a definition how much space it could take depending on the screen resolution). Therefore the Ad-Code had to be adapted as following:

Instead of the code provided by AdSense themselves:

Code: Select all

<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<!-- Before_First_Post -->
<ins class="adsbygoogle"
     style="display:block"
     data-ad-client="ca-pub-1234567"
     data-ad-slot="8910"
     data-ad-format="auto"></ins>
<script>
(adsbygoogle = window.adsbygoogle || []).push({});
</script>

I had to use the "style"-Tag as you can find many of such solutions by searching the internet:

Code: Select all

<style type="text/css">
.adslot_ID_X{ display:inline-block; width: 320px; height: 50px; }
@media (max-width: 400px) { .adslot_ID_X { width:200px; 30px; } }
@media (min-width:500px) { .adslot_ID_X { width: 468px; height: 60px; } }
@media (min-width:800px) { .adslot_ID_X { width: 728px; height: 90px; } }
</style>
<ins class="adsbygoogle adslot_ID_X"
   data-ad-client="ca-pub-1234567"
   data-ad-slot="8910"></ins>
<script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
<script>(adsbygoogle = window.adsbygoogle || []).push({});</script>
I am testing the extension now live. Big Thanks again to the devs for their efforts :!:
This doesn't solve anything for me when previewing Adsense in Chrome. This error is in fact a bit of extra security in Chrome to prevent cross site injections. It's a little too strng though and thinks Google Adsense is a security issue, even though the admin actually wants to add it. So a proper solution will probably need to be found internally to prevent this.

Re: [BETA] Official Extension: Advertisement Management

Posted: Fri Aug 11, 2017 7:09 am
by Way2Vet
VSE wrote:
Fri Aug 11, 2017 3:44 am
This doesn't solve anything for me when previewing Adsense in Chrome.
Sorry. I wasn't clear about it as it seems. I had two problems. One was Chrome preventing me previewing ads. And the other one was, that there did not show up any ads.
Because I wasn't sure at first if one problem causes the other I had a look at it and found out that AdSense uses some kind of Javascript to get the max width and height for the ad to show, but wasn't able to get it (alltough the exact same code worked on the other extension I used before).
So to make sure the ad code works - I posted this code examples.

Chrome still prevents me from previewing the ads. Whereas Opera or Firefox now show the ads (which I did not see before, because of the issue I mentioned above).

Sorry for the misunderstanding :roll:

Re: [BETA] Official Extension: Advertisement Management

Posted: Tue Aug 22, 2017 10:00 am
by goodking
The View counts does not work for me. I have several visitors at www.biafraforum.com but after a while, I had to disable it.

I used an image banner and Popup option for the ad. It shows properly but the views does not count.

Re: [BETA] Official Extension: Advertisement Management

Posted: Wed Aug 23, 2017 8:25 am
by goodking
I have enabled it. You can check.

Re: [BETA] Official Extension: Advertisement Management

Posted: Fri Aug 25, 2017 8:20 am
by TomaGo
Hello,

Thank you again for this usefull and official Extension !

On my site https://www.forumgolf8.fr/ the adsense ads are not visible even if the source code is showing adsense code.

I have install the other extension from Mobi and it is working fine.

Do you have any idea to solve this issue ?

Thanks
Thomas

Re: [BETA] Official Extension: Advertisement Management

Posted: Fri Aug 25, 2017 9:16 am
by Way2Vet
TomaGo wrote:
Fri Aug 25, 2017 8:20 am
On my site https://www.forumgolf8.fr/ the adsense ads are not visible even if the source code is showing adsense code.
What "source code" did you use? The one with responsive layout/ads? If so have a look >this post<. (I had a similar issue which had nothing to do with this extension itself.)

Re: [BETA] Official Extension: Advertisement Management

Posted: Fri Aug 25, 2017 11:21 am
by TomaGo
Thank you Way2vet for your answer,

Yes you are right, this extension have an issue with adsense responsive ads.

I have modified my adsense code with the size information and it is working but it is not clean.
(I have also added @media (min-width:1200px) { .adslot_ID_X { width: 1600px; height: 120px; } } to your code)

The native Adsense code is working well with the other ads extension.

Could it be corrected in the next release ?

Thomas