Page 3 of 6

Re: [3.1][3.2][RC] Twig Converter

Posted: Mon Jul 03, 2017 11:45 pm
by Toxyy
Well yeah but they aren't necessary for 3.2. I wouldn't mind removing them myself where needed but if this let you chose to add it or not for 3.2 that'd be nice :)

Re: [3.1][3.2][RC] Twig Converter

Posted: Tue Jul 04, 2017 6:50 am
by david63
Toxyy wrote:
Mon Jul 03, 2017 11:45 pm
Well yeah but they aren't necessary for 3.2.
Why?

Re: [3.1][3.2][RC] Twig Converter

Posted: Tue Jul 04, 2017 1:30 pm
by Toxyy
Because that's what it says in the documentation....?

Kasimi's topic, like midway through op:

viewtopic.php?f=461&t=2424606

Re: [3.1][3.2][RC] Twig Converter

Posted: Tue Jul 04, 2017 11:37 pm
by spaceace
outstanding work kasimi. saves me, and i'm sure others, a ton of time converting templates :D

Re: [3.1][3.2][RC] Twig Converter

Posted: Wed Jul 05, 2017 1:18 am
by VSE
This extension is awesome, though I see it as fitting more into our idea of extension development tools. I only wish this extension was around before I already converted all my extensions to Twig :cry:

Re: [3.1][3.2][RC] Twig Converter

Posted: Wed Jul 05, 2017 6:44 am
by david63
VSE wrote:
Wed Jul 05, 2017 1:18 am
I only wish this extension was around before I already converted all my extensions to Twig
Me too - although converting them manually did provide an opportunity to "learn" about Twig.

Re: [3.1][3.2][RC] Twig Converter

Posted: Wed Jul 05, 2017 2:58 pm
by </Solidjeuh>

Re: [3.1][3.2][RC] Twig Converter

Posted: Mon Jul 24, 2017 11:26 am
by Scanialady
German translation for version 1.1.1

Kasimi Twig Converter 1.1.1 German language files

Re: [3.1][3.2][RC] Twig Converter

Posted: Tue Aug 08, 2017 10:55 am
by Tastenplayer
Is now somehow too high for me :lol:

So I install this extension in the testboard.
Then I convert my whole style or only the template files?

What is the effect? Makes this the style faster?

Re: [3.1][3.2][RC] Twig Converter

Posted: Thu Aug 10, 2017 8:12 pm
by </Solidjeuh>
Tastenplayer wrote:
Tue Aug 08, 2017 10:55 am
Is now somehow too high for me :lol:

So I install this extension in the testboard.
Then I convert my whole style or only the template files?

What is the effect? Makes this the style faster?
More info: https://twig.symfony.com/

Re: [3.1][3.2][RC] Twig Converter

Posted: Fri Aug 11, 2017 3:32 pm
by Tastenplayer
Thanks I read that. In the next days I have to take a closer look.
That this always must be in English! :lol:

Re: [3.1][3.2][RC] Twig Converter

Posted: Fri Aug 11, 2017 11:44 pm
by </Solidjeuh>
Tastenplayer wrote:
Fri Aug 11, 2017 3:32 pm
Thanks I read that. In the next days I have to take a closer look.
That this always must be in English! :lol:
you can always translate websites with google :D

https://translate.google.com/translate? ... t=&act=url

Re: [3.1][3.2][RC] Twig Converter

Posted: Sat Aug 12, 2017 9:18 pm
by Tastenplayer
you can always translate websites with google :D
Sure, see the Chinese manuals translated to German with google :lol: :lol:

Re: [3.1][3.2][RC] Twig Converter

Posted: Mon Aug 14, 2017 6:22 am
by rxu
JoshyPHP wrote:
Mon Jul 03, 2017 4:58 pm
Yes, everything in phpBB expects bbcode.html to use the <!-- BEGIN ... --> syntax.
Well, in 3.2 adding twig compatible regex to the factory.php solves the issue for me, like that
FIND

Code: Select all

preg_match_all('#<!-- BEGIN (.*?) -->(.*?)<!-- END .*? -->#s', $template, $matches, PREG_SET_ORDER);
AFTER, ADD

Code: Select all

if (empty($matches))
{
	preg_match_all('#{% for (.*?) in .*? %}(.*?){% endfor %}#s', $template, $matches, PREG_SET_ORDER);
}

phpBB 3.1 requires similar changes to bbcode.php.

https://github.com/phpbb/phpbb/pull/4903

Re: [3.1][3.2][RC] Twig Converter

Posted: Sun Oct 08, 2017 7:10 pm
by kasimi
Version 1.2.0 is now available in the first post.
  • Works with 3.2.x and the latest master branch (3.3.x), dropped support for 3.1.x
  • Entirely rely on core code's lexer class, thereby increasing chances of forward compatibility.