[CDB] Magic OGP links: thumbnails and descriptions

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Ger
Recognised Extension Developer
Posts: 1922
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Ger »

Theriddler1 wrote:
Tue Oct 10, 2017 9:46 am
tested your extension Ger, nice work but i can only see it parsed when previewing the post
after posting the link is not parsed anymore

example: https://peppersrusforum.nl/viewtopic.php?p=44321#p44321
I've just tested the URL in the post you link to, it works for me on prosilver and "somewhat vanilla" testboard.

Do you have any other extensions on your board that do something to the textformatter?
You might also want to check the error log in ACP.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
Theriddler1
Registered User
Posts: 448
Joined: Sat Aug 27, 2011 11:00 pm
Location: NL
Name: Theriddler❶
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Theriddler1 »

strange...

No i got no extensions that i can think of that do someting with the textformater.

Would you like to take a look at the board yourself ?

I can PB you the account details with admin rights.
Theriddler - Moderator @ phpBB.nl | phpBBservice.nl Team-member
ImageSupport Tools | Image My Extensions | buy me a beer Image

User avatar
Ger
Recognised Extension Developer
Posts: 1922
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Ger »

Yeah, I'm kinda intrigued. Can you also make sure you have the latest version, cache cleared and point me to a subforum where I can test at will?
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
Theriddler1
Registered User
Posts: 448
Joined: Sat Aug 27, 2011 11:00 pm
Location: NL
Name: Theriddler❶
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Theriddler1 »

PB sent :)
Theriddler - Moderator @ phpBB.nl | phpBBservice.nl Team-member
ImageSupport Tools | Image My Extensions | buy me a beer Image

User avatar
Ger
Recognised Extension Developer
Posts: 1922
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Ger »

See PM :)

For other users: it seems like there was simply a problem with a specific site that's unreliable. Other sites seem to work as expected.

There's also a minor issue when combining this extension with the Ajax base extension. When the option for ajax preview is enabled, the OGP data isn't parsed on the browser site. It should call the javascript function from the Magic OGP extension, but doesn't.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Hartenheer »

In the caption, this does not work.

Will this be possible in the future?
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
Ger
Recognised Extension Developer
Posts: 1922
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Ger »

Hartenheer wrote:
Fri Oct 13, 2017 10:07 am
In the caption, this does not work.
You mean in the signature? (onderschrift/handtekening in dutch)
I've intentionally only made this to work in the post content, since in signatures it would quickly become very crowded
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
Theriddler1
Registered User
Posts: 448
Joined: Sat Aug 27, 2011 11:00 pm
Location: NL
Name: Theriddler❶
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Theriddler1 »

Ger wrote:
Thu Oct 12, 2017 8:45 am
See PM :)

For other users: it seems like there was simply a problem with a specific site that's unreliable. Other sites seem to work as expected.

There's also a minor issue when combining this extension with the Ajax base extension. When the option for ajax preview is enabled, the OGP data isn't parsed on the browser site. It should call the javascript function from the Magic OGP extension, but doesn't.
Thnx Ger for your spare time to take a look at my board.

I disabled the post preview function from the ajax base extension and no problem seen after that.
Theriddler - Moderator @ phpBB.nl | phpBBservice.nl Team-member
ImageSupport Tools | Image My Extensions | buy me a beer Image

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Hartenheer »

Ger wrote:
Fri Oct 13, 2017 10:13 am
Hartenheer wrote:
Fri Oct 13, 2017 10:07 am
In the caption, this does not work.
You mean in the signature? (onderschrift/handtekening in dutch)
I've intentionally only made this to work in the post content, since in signatures it would quickly become very crowded
Yes, I meant the signature. Unfortunately, it would be very good for some messages.
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
Ger
Recognised Extension Developer
Posts: 1922
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Ger »

Hartenheer wrote:
Fri Oct 13, 2017 10:37 am
Yes, I meant the signature. Unfortunately, it would be very good for some messages.
You can quite simply enable it. Open up ./ext/ger/magicogp/styles/prosilver/template/magicogp.js
Change this line:

Code: Select all

    $('.content .postlink').each(function() {
to

Code: Select all

    $('.content .postlink, .signature .postlink').each(function() {
You need to make sure you refresh both your board cache and your browser cache.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Hartenheer »

Thank you very much. As soon as I'm home, I'll change it

Edit:
Works fine
Thank you for the code
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
Frogmen
Registered User
Posts: 114
Joined: Fri Dec 28, 2007 11:48 pm
Location: Palma De Mallorca. Spain

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Frogmen »

Hello, Its not working in my forum, it does nothing to the urls. Maybe is because I have lots of extensions installed:

Image

rgds
Frogmen

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Hartenheer »

Frogmen wrote:
Fri Oct 13, 2017 4:25 pm
Hello, Its not working in my forum, it does nothing to the urls. Maybe is because I have lots of extensions installed:

Image

rgds
Frogmen
The site you use must also be and have good standing

Try https://www.efteling.com/nl as proof.
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
Frogmen
Registered User
Posts: 114
Joined: Fri Dec 28, 2007 11:48 pm
Location: Palma De Mallorca. Spain

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Frogmen »

My forum works perfectly, no errors log since 2015.

rgds
Frogmen

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] Magic OGP links: thumbnails and descriptions

Post by Hartenheer »

Frogmen wrote:
Fri Oct 13, 2017 5:20 pm
My forum works perfectly, no errors log since 2015.

rgds
Frogmen
Sorry for my bad English.
Does not the link I have given either work?
Then Ger you have to help
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

Locked

Return to “Extensions in Development”