[3.2][BETA] phpBB Initial Avatars (Lite)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
jackennils
Registered User
Posts: 181
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by jackennils » Sat Nov 11, 2017 12:19 am

It's populated, but I don't know if everything is correct. I'll send you another PM with the exported table, then you can check yourself.

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Sat Nov 11, 2017 12:33 am

When it contains 2967 records is fully populated, in your case.
(2968 - anonymous) bots aren't included in the total users.

Data I know they will be correctly placed.

Edit: checked, is all right. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
jackennils
Registered User
Posts: 181
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by jackennils » Sat Nov 11, 2017 9:13 am

Super! :)

hubaishan
Translator
Posts: 125
Joined: Sun Apr 10, 2011 2:47 pm
Name: Saeed Hubaishan
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by hubaishan » Mon Nov 13, 2017 1:02 pm

In Arabic and RTL languages must start from right to left php GDI is not compatible with RTL, I think.

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Mon Nov 13, 2017 11:07 pm

I think you meant GD not GDI. That's correct and the php's bug has been suspended till the lib will be fixed.

All of this is behind my coding though, I mean I depend from an API which itself depends on intervention/image for this kind of issues. (I filed an issue related at the repo though).

You know for sure you can use the ar-php library, which I suggested the API's creator to have a look at. If there will be some news about that then the extension will automatically get benefits from. To add, there is already support for Arabic etc.. built-in. Being my self not a native speaker I didn't investigate it further though, see first posts to know wich languages got already support.

Alternatively there is only one solution which is to don't use the extension, that's all what I can do here now.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

hubaishan
Translator
Posts: 125
Joined: Sun Apr 10, 2011 2:47 pm
Name: Saeed Hubaishan
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by hubaishan » Tue Nov 14, 2017 9:18 am

In Arabic every letter has 4 forms: isolated, initial, medial and final. ar-php is used to choose the correct form. But in abbreviation we use isolated only so no need to ar-php we can use strrev() only

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Wed Dec 06, 2017 11:15 pm

hubaishan wrote:
Tue Nov 14, 2017 9:18 am
In Arabic every letter has 4 forms: isolated, initial, medial and final. ar-php is used to choose the correct form. But in abbreviation we use isolated only so no need to ar-php we can use strrev() only
Hi,
there are news about this, as I told you I forwarded the question to LasseRafn, we got a reply.
If you want to follow the discussion please have a look here,

Thanks.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
jackennils
Registered User
Posts: 181
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by jackennils » Sat Jan 06, 2018 12:37 pm

Hey 3Di!

Just to let you know, the SSL certificate of ui-avatars is marked as unsecure by Chrome since today. That means, that for many users, the avatars are not loaded anymore which breaks the whole extension. I will deactivate it for now until LasseRafn has fixed his site. Anyway, everything seems pretty abandoned on his end. :(

Also, setting "Use Initial avatars" to No, does not remove the PIAs and does not make users avatarless again. :(


Edit: That was fast... Chrome is now again listing LasseRafn's site as secure. :shock:

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Sat Jan 06, 2018 9:25 pm

Its certificate is automatically renewed every 3 months (Let's Encrypt).
jackennils wrote:
Sat Jan 06, 2018 12:37 pm
setting "Use Initial avatars" to No, does not remove the PIAs and does not make users avatarless again.
That could be you should hit submit multiple times, as we already discovered.
Once I will get on this again I will fix that.
jackennils wrote:
Sat Jan 06, 2018 12:37 pm
breaks the whole extension
Care to expand, what exactly breaks? The URL is managed by phpBB, if the URL is not working a red X should display, isn't?
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
jackennils
Registered User
Posts: 181
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by jackennils » Sat Jan 06, 2018 10:34 pm

I tried clicking many times, did not help. However, will test again and report.

Edit: Okay, seems I did not try often enough, works!



Yes, if ui-avatars is not loading/blocked, the red X or similar (different for each browser) is displayed making the site look unprofessional. Maybe you can implement some sort of fallback?

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Sat Jan 06, 2018 10:58 pm

jackennils wrote:
Sat Jan 06, 2018 10:34 pm
Yes, if ui-avatars is not loading/blocked, the red X or similar (different for each browser) is displayed making the site look unprofessional. Maybe you can implement some sort of fallback?
That's why I asked, I am thinking about providing a fallback indeed.

At the moment I don't have a clue though if PHP events are already provided to achieve that goal, as I said, it's like every remote avatar, if the URL provided isn't working anymore (IE.: image hosting) then a red-X of some sort is shown instead. This extension takes care to provide a URL without the human intervention.

The site ui-avatars provides those also at the Official WordPress' one, this kind of issue shouldn't happen so often but... Would you mind to create an issue in my tracker? I will take care of it, if possible.

https://github.com/3D-I/pia/issues

Thanks for the feedback, appreciated. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
jackennils
Registered User
Posts: 181
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by jackennils » Sun Jan 07, 2018 10:56 am

Done, thanks!

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Sun Jan 07, 2018 11:28 pm

Thank you too! :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
RomaamoR
Registered User
Posts: 150
Joined: Tue Feb 24, 2015 4:45 pm
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by RomaamoR » Fri Jan 19, 2018 10:06 am

Общая ошибка

Code: Select all

SQL ERROR [ mysqli ]

Duplicate entry 'threedi_pia_default_avatar' for key 'PRIMARY' [1062]

SQL

INSERT INTO phpbb_config (config_name, config_value, is_dynamic) VALUES ('threedi_pia_default_avatar', 1, 0)

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 996
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 161
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 122
CALL: phpbb\config\db->set_atomic()

FILE: [ROOT]/ext/threedi/pia/acp/pia_module.php
LINE: 53
CALL: phpbb\config\db->set()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: threedi\pia\acp\pia_module->main()

FILE: [ROOT]/adm/index.php
LINE: 82
CALL: p_master->load_active()

User avatar
3Di
Registered User
Posts: 12946
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] phpBB Initial Avatars (Lite)

Post by 3Di » Wed Jan 24, 2018 4:50 am

RomaamoR wrote:
Fri Jan 19, 2018 10:06 am

Code: Select all

SQL ERROR [ mysqli ]

Duplicate entry 'threedi_pia_default_avatar' for key 'PRIMARY' [1062]

SQL

INSERT INTO phpbb_config (config_name, config_value, is_dynamic) VALUES ('threedi_pia_default_avatar', 1, 0)

BACKTRACE
... snip ...

FILE: [ROOT]/ext/threedi/pia/acp/pia_module.php
LINE: 53
CALL: phpbb\config\db->set()

... snip ..
The above line is perfectly fine IMHO, I can't reproduce your issue here..

Code: Select all

$config->set('threedi_pia_default_avatar', $request->variable('threedi_pia_default_avatar', (int) $config['threedi_pia_default_avatar']));
That line it's surrounded by a condition, that one leads me to guess you are using the back-button of your browser in order to re-submit data, that's a no-no. That data has been already stored on the first submit and ofcourse could produce a such error just in the use case I guessed.

Code: Select all

		if ($request->is_set_post('submit'))
		{
			if (!check_form_key('threedi/pia'))
			{
				trigger_error('FORM_INVALID', E_USER_WARNING);
			}

			if (!$config['allow_avatar_remote'])
			{
				$errors[] = $user->lang('PIA_REMOTE_CONFIG_INVALID');
				/* Log the error. */
				$phpbb_log->add('critical', $user->data['user_id'], $user->ip, 'PIA_LOG_REMOTE_CONFIG_INVALID');
			}

			/* No errors? Great, let's go. */
			if (!count($errors))
			{
				$config->set('threedi_pia_default_avatar', $request->variable('threedi_pia_default_avatar', (int) config['threedi_pia_default_avatar']));
The above means the config will be set only if the "submit" button has been pushed and there are no errors on its way..

I believe you misunderstod some posts, here in this topic, where we were talking about re-submitting the "form" in ACP in order to full-fill the data, that's due to a glitch in the present code, a work-around, to be done (in case) till I will be back on this code and I will fix that.

So if you are not confortable with the explaination given then, please, disable the extension and wait.
Thank you. :)
RomaamoR wrote:
Fri Jan 19, 2018 10:06 am
Общая ошибка
The above language (and many more) aren't into my level of comfort, I don't know what you are trying to tell me nor I have to investigate about that, IMHO. :roll:

Please, just use plain-english here (or try, like I do) and I will be more than glad to help you out. ;)

This time I understood the problem thanks to the error message you above posted, just you to know. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: No registered users and 26 guests