[CDB] Prime Links

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Fri Feb 09, 2018 11:43 pm

eunaumtenhoid wrote:
Thu Feb 08, 2018 12:44 pm
so...
look, user posted a link, but to access his link who click will be directed to another link that will then be directed to the original link, does this extension do this?
You can specify what you would like to have prepended to the front of a link's URL.
pennino wrote:
Fri Feb 09, 2018 3:00 pm
Update: OK, I've just checked. In memberlist.php (member page + profile page) Prime Links uses JavaScript. The question is: it would be possible to add inline a rel="nofollow"?
I believe that would require directly editing template files which extensions can't do.
pennino wrote:
Fri Feb 09, 2018 3:00 pm
In viewtopic.php, Prime Links does not manage the member website link under the avatar. It would be possible to do that and adding a rel="nofollow" into the anchor tag?
Yes, I can add that.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Fri Feb 09, 2018 11:49 pm

spaceace wrote:
Fri Feb 09, 2018 11:39 am
primehalo wrote:
Sat Feb 03, 2018 11:24 pm
## [1.1.0 BETA 2]
### Added
- Applied external link attributes to member website links on the memberlist page.
i will have to update my board to phpBB 3.2.2 to test this as the core event used was applied to the phpBB core in that version

also, composer.json needs the version updated in it ;)
I didn't realize that. I'm sure I can find an event to use that exists in phpBB 3.1
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Sun Feb 11, 2018 3:15 pm

primehalo wrote:
Fri Feb 09, 2018 11:43 pm
pennino wrote:
Fri Feb 09, 2018 3:00 pm
Update: OK, I've just checked. In memberlist.php (member page + profile page) Prime Links uses JavaScript. The question is: it would be possible to add inline a rel="nofollow"?
I believe that would require directly editing template files which extensions can't do.
Perfect, I'll check the template files. However, in my configuration, Google cannot access this file (each board's user has to be logged in...) so using JavaScript would be ok.
primehalo wrote:
Fri Feb 09, 2018 11:43 pm
pennino wrote:
Fri Feb 09, 2018 3:00 pm
In viewtopic.php, Prime Links does not manage the member website link under the avatar. It would be possible to do that and adding a rel="nofollow" into the anchor tag?
Yes, I can add that.
It would be wonderful! :)
Thank you so much and, again, congratulations for your ext!!

User avatar
eunaumtenhoid
Registered User
Posts: 740
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.1][3.2][BETA] Prime Links

Post by eunaumtenhoid » Sun Feb 11, 2018 5:04 pm

not in front of the URL and before the original link is accessed, the user visits another link as a "protector" of links
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Sun Feb 11, 2018 5:13 pm

eunaumtenhoid wrote:
Sun Feb 11, 2018 5:04 pm
not in front of the URL and before the original link is accessed, the user visits another link as a "protector" of links
You want a second link to replace the first link and then after the second link is clicked the first link reappears? This extension can't do something like that, but it can add a different link onto the front of the link's URL so you could implement something like this yourself by creating a protector page and sending the original link to it http://www.example.com/link-protected.php?url=http://www.example.com/original-link.php
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Sun Feb 11, 2018 5:57 pm

Uploaded Beta 3.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
eunaumtenhoid
Registered User
Posts: 740
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.1][3.2][BETA] Prime Links

Post by eunaumtenhoid » Sun Feb 11, 2018 8:52 pm

primehalo wrote:
Sun Feb 11, 2018 5:13 pm
eunaumtenhoid wrote:
Sun Feb 11, 2018 5:04 pm
not in front of the URL and before the original link is accessed, the user visits another link as a "protector" of links
You want a second link to replace the first link and then after the second link is clicked the first link reappears? This extension can't do something like that, but it can add a different link onto the front of the link's URL so you could implement something like this yourself by creating a protector page and sending the original link to it http://www.example.com/link-protected.php?url=http://www.example.com/original-link.php
yeahh
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

User avatar
spaceace
Registered User
Posts: 1795
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by spaceace » Sun Feb 11, 2018 10:38 pm

primehalo wrote:
Sun Feb 11, 2018 5:57 pm
Uploaded Beta 3.
all my testing shows everything working :)

great work

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Mon Feb 12, 2018 7:46 am

Hi primehalo,

thank you again for your effort!

You wrote in the changelog:
- Applied external link attributes to member website links on the viewtopic page, excluding the class attribute because the links here are represented as icons.
So I removed class="dropdown-contents contact-icons" and class="contact-icon {postrow.contact.ID}-icon" from DIV/SPAN in viewtopic_body.html but rel="nofollow" isn't added to a href member website link.

Thank you!

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Mon Feb 12, 2018 8:28 am

Did you clear the board cache? The rel="nofollow" is showing up for me just fine. Are you using something other than prosilver? And why did you remove the classes?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Mon Feb 12, 2018 8:46 am

Yes, I've cleared the board cache.
I'm using prosilver only, no other extension.
"Enable for Member Website" is set to YES.

With the following code, in viewtopic_body.html, the rel="nofollow" attribute does not appear:
<!-- EVENT viewtopic_body_contact_fields_before -->
<!-- IF not S_IS_BOT and .postrow.contact -->
<dd class="profile-contact">
<strong>{L_CONTACT}{L_COLON}</strong>
<div class="dropdown-container dropdown-left">
<a href="#" class="dropdown-trigger"><span class="imageset icon_contact" title="{postrow.CONTACT_USER}">{postrow.CONTACT_USER}</span></a>
<div class="dropdown hidden">
<div class="pointer"><div class="pointer-inner"></div></div>
<div class="dropdown-contents contact-icons">
<!-- BEGIN contact -->
{% set REMAINDER = postrow.contact.S_ROW_COUNT % 4 %}
<!-- DEFINE $S_LAST_CELL = ((REMAINDER eq 3) or (postrow.contact.S_LAST_ROW and postrow.contact.S_NUM_ROWS < 4)) -->
<!-- IF REMAINDER eq 0 -->
<div>
<!-- ENDIF -->
<a href="<!-- IF postrow.contact.U_CONTACT -->{postrow.contact.U_CONTACT}<!-- ELSE -->{postrow.U_POST_AUTHOR}<!-- ENDIF -->" title="{postrow.contact.NAME}"<!-- IF $S_LAST_CELL --> class="last-cell"<!-- ENDIF --><!-- IF postrow.contact.ID eq 'jabber' --> onclick="popup(this.href, 750, 320); return false;"<!-- ENDIF -->>
<span class="contact-icon {postrow.contact.ID}-icon">{postrow.contact.NAME}</span>
</a>
<!-- IF REMAINDER eq 3 or postrow.contact.S_LAST_ROW -->
</div>
<!-- ENDIF -->
<!-- END contact -->
</div>
</div>
</div>
</dd>
<!-- ENDIF -->
<!-- EVENT viewtopic_body_contact_fields_after -->
Thank you!

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Mon Feb 12, 2018 8:52 am

The attributes aren't added to the template, they are injected into the HTML with Javascript when the page is rendered.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Mon Feb 12, 2018 9:13 am

Ok, I've checked this. Sorry for the misunderstanding: for member links the attribute is added via JavaScript.
BUT, which modification to phpBB could you kindly suggest to me in order to add the rel="nofollow" to member links (under the avatar) managing the a "anchor" tag?

Thank you so much!

User avatar
primehalo
Former Team Member
Posts: 2769
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.1][3.2][BETA] Prime Links

Post by primehalo » Mon Feb 12, 2018 9:19 am

Code: Select all

<a rel="nofollow" href="<!-- IF postrow.contact.U_CONTACT -->{postrow.contact.U_CONTACT}<!-- ELSE -->{postrow.U_POST_AUTHOR}<!-- ENDIF -->" title="{postrow.contact.NAME}"<!-- IF $S_LAST_CELL --> class="last-cell"<!-- ENDIF --><!-- IF postrow.contact.ID eq 'jabber' --> onclick="popup(this.href, 750, 320); return false;"<!-- ENDIF -->>
<span class="contact-icon {postrow.contact.ID}-icon">{postrow.contact.NAME}</span>
</a>
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

pennino
Registered User
Posts: 139
Joined: Thu May 05, 2005 2:07 pm

Re: [3.1][3.2][BETA] Prime Links

Post by pennino » Mon Feb 12, 2018 9:23 am

Thank you! I was already testing that modification but the rel="nofollow" attribute is added for local links too (for example ./memberlist.php?mode=email). So I'm searching for the way to add rel="nofollow" for member website link only

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: jackennils, Matthew G. Saroff and 24 guests