[BETA] [3.2] Prime Notify

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Mon Sep 16, 2019 4:33 pm

I don't think the problem would be with this extension as it uses the exact same checks used in the original phpbb files.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
3Di
Former Team Member
Posts: 14358
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [BETA] [3.2] Prime Notify

Post by 3Di » Tue Sep 17, 2019 2:36 am

primehalo wrote:
Thu Apr 04, 2019 7:38 am
I posted an updated version, 1.0.0 Beta 11, with a fix. Unfortunately the fix just replaces 4-byte characters with a 3-byte character instead of encoding it into something else that can be stored in the database and then decoding it when extracting from the database, so 4-byte emoji characters won't show up in the email.
I recently discovered 2 phpBB functions which can do what you were after, see:

https://github.com/phpbb/phpbb/pull/5685
https://github.com/phpbb/phpbb/pull/5685/files

utf8_encode_ncr() and utf8_decode_ncr()
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Wed Sep 25, 2019 7:28 pm

Thanks, I have incorporated those into the extension and released v1.0.0 RC1.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
NAPWR
Registered User
Posts: 27
Joined: Thu May 11, 2017 5:40 am

Re: [BETA] [3.2] Prime Notify

Post by NAPWR » Thu Oct 03, 2019 4:44 am

primehalo wrote:
Wed Sep 25, 2019 7:28 pm
Thanks, I have incorporated those into the extension and released v1.0.0 RC1.
That's Great Mate,

I tried a few weeks ago to download new version v1.0.0 RC1

and got the same error today:

https://www.absoluteanime.com/_phpbb3-e ... notify.zip
Error 404, Resource Not Found

Any help with the link please?

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Thu Oct 03, 2019 5:14 am

Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

User avatar
NAPWR
Registered User
Posts: 27
Joined: Thu May 11, 2017 5:40 am

Re: [BETA] [3.2] Prime Notify

Post by NAPWR » Thu Oct 03, 2019 5:26 am

Thanks again Primehalo,

My mistake, as I now have a Linux Mint system running Chrome browser is why it did not work,

so I tried my old system Win10/Chrome just now and works M8. :lol:

I am Happy now. :mrgreen:

frankv
Registered User
Posts: 17
Joined: Mon May 24, 2004 6:37 pm

Re: [BETA] [3.2] Prime Notify

Post by frankv » Sat Nov 02, 2019 3:29 pm

Hi, @first thank you for this great mod :-)

A little Problem I have:

I changed subject as follows:

Subject: {FORUM_NAME} - {TOPIC_TITLE}

The first Mail I receive is

{FORUM_NAME} - {TOPIC_TITLE}

All following Mails to the same Posts are only

- {TOPIC_TITLE}

Where is my mistake, what do I have to change?

Thank you in advance,

Frank

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Sat Nov 02, 2019 4:32 pm

I really don't know. My extension shouldn't do anything at all with FORUM_NAME or TOPIC_TITLE. It pretty much just gets the existing template variables, adds in a couple new ones, and gives that back to phpBB to use like it normally would.

Does the same thing happen if you disable the extension and make the same changes to the original phpBB templates?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

frankv
Registered User
Posts: 17
Joined: Mon May 24, 2004 6:37 pm

Re: [BETA] [3.2] Prime Notify

Post by frankv » Sat Nov 02, 2019 4:36 pm

primehalo wrote:
Sat Nov 02, 2019 4:32 pm
It pretty much just gets the existing template variables, adds in a couple new ones?
Thank you, what new variables are responsible?


Frank

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Sat Nov 02, 2019 4:40 pm

MESSAGE and S_VISIT_MSG
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

frankv
Registered User
Posts: 17
Joined: Mon May 24, 2004 6:37 pm

Re: [BETA] [3.2] Prime Notify

Post by frankv » Sat Nov 02, 2019 4:43 pm

Thank you for your fast replay.

I Like to have a Subject equal to

Forum Name - Forum Topic

How can I realise this?

Frank

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Sat Nov 02, 2019 4:45 pm

I don't know, I would have tried exactly what you tried. The template variables should be there since they're used within the body of the template so I have no idea why they're not working with the subject.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

frankv
Registered User
Posts: 17
Joined: Mon May 24, 2004 6:37 pm

Re: [BETA] [3.2] Prime Notify

Post by frankv » Sat Nov 02, 2019 4:51 pm

For topic_notify.txt I have still this one:

Code: Select all

Subject: {FORUM_NAME} - {TOPIC_TITLE}
_____________________________________________________________________
Von: {AUTHOR_NAME}

{MESSAGE}

{U_TOPIC}
_____________________________________________________________________
And the first Mail has

{FORUM_NAME} - {TOPIC_TITLE}

in the Subject, all following notifications only unexpectedly

- {TOPIC_TITLE}

Thank you,

Frank

User avatar
primehalo
Former Team Member
Posts: 2848
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [BETA] [3.2] Prime Notify

Post by primehalo » Sat Nov 02, 2019 5:26 pm

Maybe the first time it's using the newtopic_notify.txt template and after that it's using the topic_notify.txt template. I don't see the FORUM_NAME template variable in the topic_notify.txt template and I don't see that variable being set in phpbb/notification/type/post.php.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!

frankv
Registered User
Posts: 17
Joined: Mon May 24, 2004 6:37 pm

Re: [BETA] [3.2] Prime Notify

Post by frankv » Sat Nov 02, 2019 5:31 pm

OK, thank you again. How do I alter


phpbb/notification/type/post.php

to solve this one?
Best regards, Frank

Post Reply

Return to “Extensions in Development”