[3.2][3.3][RC] Highlight Posts ⚡️

3Di · Post by **3Di** » Thu Apr 02, 2020 1:59 pm

Erwan11 wrote: ↑Thu Apr 02, 2020 1:47 pm I fear that's not the case. I just installed this extension on my phpBB 3.3 forum. Firstly, I had to modify composer.json and ext.php so that the extension matches my version of phpBB, otherwise I couldn't enable it.

3Di wrote: ↑Thu Oct 03, 2019 10:28 pm It should perfectly work on 3.3 as well, quite sure.

Next release we will raise the max. requirements.

It should means I am not really sure but quite, since we have not tested it and no new version has beeen released since then.

Thx for feedback though.

Erwan11 · Post by **Erwan11** » Thu Apr 02, 2020 3:29 pm

Ok, thank you. And what about the Highlight Post icons that do not appear in messages?

3Di · Post by **3Di** » Thu Apr 02, 2020 3:34 pm

3Di wrote: ↑Thu Apr 02, 2020 1:59 pm ... we have not tested it ...

Not tested with 3.3 this is an extension for phpBB 3.2, still.

Erwan11 · Post by **Erwan11** » Fri Apr 10, 2020 12:40 pm

Hello 3Di,

I really need this extension for phpBB 3.3. If you wish I can pay for it (send me a PM).

Thanks in advance.

3Di · Post by **3Di** » Fri Apr 10, 2020 12:47 pm

Erwan11 wrote: ↑Fri Apr 10, 2020 12:40 pm ...
I really need this extension for phpBB 3.3. If you wish I can pay for it (send me a PM).
...

Unfortunately in this case it's not the money that makes the difference but the time we have available, this extension is a donation from one of our customers who has already paid for it, to whom we all say thank you, right? Our sponsor doesn't have this urgency and therefore it's not in our priorities, don't worry that sooner or later we will test and eventually fix this one for 3.3 and you won't have to put money out of your pocket, nobody will have to.

Erwan11 · Post by **Erwan11** » Fri Apr 10, 2020 12:58 pm

3Di wrote:this extension is a donation from one of our customers who has already paid for it

That's what I meant : to pay for it and let everyone download it for free. But I understand that you can't sell it twice.

3Di · Post by **3Di** » Fri Apr 10, 2020 12:59 pm

It's just not correct. Thanks for comprehending.

mrgoldy · Post by **mrgoldy** » Fri Apr 10, 2020 8:22 pm

Erwan, if you want to request something from us (3Di and myself), you can head over to our forum (see our signatures) and do it there.
This isn't really the appropriate place for requesting custom work from us, if I understand you correctly.

Happy easter!

Erwan11 · Post by **Erwan11** » Sat Apr 11, 2020 11:24 am

I might be wrong but I think there is a syntax error in core/operator.php at line 430.

The end of

Code: Select all

WHERE (g.group_type <> ' . GROUP_HIDDEN . ' OR ug.user_id = ' . (int) $user->data['user_id'] . ')';

should be

Code: Select all

... OR ug.user_id = ' . (int) $user->data['user_id']);

mrgoldy · Post by **mrgoldy** » Sat Apr 11, 2020 12:03 pm

Not sure what you mean, but we use an opening parentheses: (, which has to be closed.
We like to 'group' our OR statements, meaning that they are enclosed in ( ... ).

Erwan11 · Post by **Erwan11** » Sat Apr 11, 2020 12:34 pm

mrgoldy wrote: ↑Sat Apr 11, 2020 12:03 pm Not sure what you mean

I was wrong. There should be no parenthesis at the end of the request:

Code: Select all

$sql = 'text ' . GROUPS_TABLE . ' text ' . USER_GROUP_TABLE . ' text ' . $user->data['user_id'] . ' text ' . GROUP_HIDDEN . ' text ' . (int) user->data['user_id'];

mrgoldy · Post by **mrgoldy** » Sat Apr 11, 2020 12:42 pm

Still not sure what you mean, and replacing parts of a SQL query with text doesn't really help either..

Code: Select all

WHERE (g.group_type <> ' . GROUP_HIDDEN . ' OR ug.user_id = ' . (int) $user->data['user_id'] . ')';

As you can see, after the WHERE there is an opening parenthesis: (.
This groups the following statements together, and has to be closed: . ')';.
All I can say, is that the code as it is, is correct.

Erwan11 · Post by **Erwan11** » Sat Apr 11, 2020 1:04 pm

Anyway, I was trying to make your extension work in phpBB 3.3 when I clicked on the red icon eye to see who marked the message as read. I got an error message from mySql saying that there is a syntax error near (int) $user->data['user_id'] in core/operator.php line 430.

I tried first to replace .')'; with ); but the forum completely failed (blank page). I had to remove the extension from ext/ and delete the content of cache/production in FTP.

That said, you are right in principle, there is an opening parenthesis. So I don't really know where the error comes from.

EDIT : my forum uses php 7.3.12.

mrgoldy · Post by **mrgoldy** » Sat Apr 11, 2020 1:19 pm

Yes, and as mentioned and indicated, this extension is not compatible with phpBB 3.3 as it is.
So we can and will not provide support for that, so you are on your own.

So you can either wait for us to do it when we have the time,
request us to do it sooner by making a request at our forum,
or try it on your own, but you can not receive support from us.

Erwan11 · Post by **Erwan11** » Sat Apr 11, 2020 1:34 pm

The modifications I made allowed me to get a good idea of this extension, and my conclusion is that it's not exactly what I need. So I don't need support, I'll rather contact you from your web site to ask for something much simpler, but first I have to think about it.