[CDB] Linked Accounts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Flerex
Registered User
Posts: 61
Joined: Sun Oct 14, 2012 8:35 pm
Location: Galicia, Spain
Name: Flerex
Contact:

[CDB] Linked Accounts

Post by Flerex » Sat Mar 10, 2018 6:52 pm

Extension Name: Linked Accounts
Author: Flerex

Extension Description: A phpBB 3.2 extension that gives your users the ability to link all their accounts and switch between them with ease.
Extension Version: 1.0.3

Features:
  • Account linking. Link all your owned accounts to easily switch between them without having to type your password
  • Bidirectional links. A link created from account A to B will automatically allow account B to switch to A.
  • Permission-ready. Choose which groups can use the account switching features.
  • User selection menu. Find the username of the account you want to link without having to type it. (Because this extension is about not typing, right?).
  • phpBB integration. The extension beautifuly behaves as if the linking account system was part of phpBB.
  • Admin management. Because you want to be able to manage your users' links.


Screenshots:

Image
Image
Image
Image
Image
Image

Extension Download: Download the latest release

Roadmap:
  1. Add support for alternative authentication methods.
Github repository: flerex/linkedaccounts

Information:

This is my first phpBB extension ever so please excuse the multiple mistakes I have most likely made on my code. I would appreciate any suggestions to improve the code so I can learn more about phpBB developement. Merge requests are open to everyone that wants to help!

Moreover, if you have any feature suggestion, you're free to leave it here too.

I hope you like the extension! :)
Last edited by Flerex on Sun Jul 01, 2018 9:06 am, edited 19 times in total.

User avatar
Galandas
Registered User
Posts: 731
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][BETA] Linked Accounts

Post by Galandas » Sun Mar 11, 2018 12:52 am

very interesting.
English is not my native language My CDB Contributions My RC extensions

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3271
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [3.2][BETA] Linked Accounts

Post by HiFiKabin » Sun Mar 11, 2018 10:49 am

On First enabling the extension

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/phpbb/db/migration/tool/module.php on line 520: Undefined index: module_langname
Adding account OK

On Switching account

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/flerex/linkedaccounts/service/utils.php on line 134: Undefined variable: row
I haven't looked through the code. yet, but its certainly an Extension I will be using.

Running locally W10 64 pro using XAMPP and Quickinstall

User avatar
Flerex
Registered User
Posts: 61
Joined: Sun Oct 14, 2012 8:35 pm
Location: Galicia, Spain
Name: Flerex
Contact:

Re: [3.2][BETA] Linked Accounts

Post by Flerex » Sun Mar 11, 2018 12:45 pm

Both warnings shoud be fixed right now with version 0.1.1. Thanks for pointing them out!

This new version also includes Galician translation.

Edited: Version 0.1.2 released, which includes the following changes:
  • Support for PHP 5.4 fixed.
  • Added Spanish translation.
  • Fixed English translation.
  • Fixed Galician translation.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3271
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [3.2][BETA] Linked Accounts

Post by HiFiKabin » Sun Mar 11, 2018 5:03 pm

Updated

I like to try and break things, so ...

If you are in your UCP and then try to switch accounts

screenshot_173.jpg

but the account is switched successfully.

User avatar
Flerex
Registered User
Posts: 61
Joined: Sun Oct 14, 2012 8:35 pm
Location: Galicia, Spain
Name: Flerex
Contact:

Re: [3.2][BETA] Linked Accounts

Post by Flerex » Mon Mar 12, 2018 2:28 pm

Unfortunately I can't seem to reproduce your problem. Are you running the latest version of phpBB? Which version of PHP are you using?

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3271
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [3.2][BETA] Linked Accounts

Post by HiFiKabin » Mon Mar 12, 2018 4:14 pm

phpBB 3.2.2

php 7.0.25

fagbutlil
Registered User
Posts: 26
Joined: Wed Mar 07, 2018 10:56 pm

Re: [3.2][BETA] Linked Accounts

Post by fagbutlil » Mon Mar 12, 2018 7:18 pm

I use the account switcher by dmzx that works great.

User avatar
</Solidjeuh>
Registered User
Posts: 1069
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [3.2][BETA] Linked Accounts

Post by </Solidjeuh> » Mon Mar 12, 2018 8:17 pm

fagbutlil wrote:
Mon Mar 12, 2018 7:18 pm
I use the account switcher by dmzx that works great.
Yes, but only for VIP users ;)

I made a pull request on GitHub for Dutch translation.
You can also find it here: https://github.com/Solidjeuh/Linked-Accounts
We offer fun HTML5 games for young and old.
Register a free account & enjoy all functions!
Save your score, challenge other members or play along with our tournaments.


~~~ https://www.solidjeuh.be ~~~

User avatar
Flerex
Registered User
Posts: 61
Joined: Sun Oct 14, 2012 8:35 pm
Location: Galicia, Spain
Name: Flerex
Contact:

Re: [3.2][BETA] Linked Accounts

Post by Flerex » Mon Mar 12, 2018 8:40 pm

HiFiKabin wrote:
Mon Mar 12, 2018 4:14 pm
phpBB 3.2.2

php 7.0.25
I'm still not able to replicate the problem. Is it a fresh phpBB installation? Do you have any other extensions installed?

I don't know what may be happening.

nou nou
Registered User
Posts: 210
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.2][BETA] Linked Accounts

Post by nou nou » Mon Mar 12, 2018 8:49 pm

fagbutlil wrote:
Mon Mar 12, 2018 7:18 pm
I use the account switcher by dmzx that works great.
Apart from that the UCP tab for Linked Account shows even when you don't have the permission to use the extension.

Keeping an eye on this one to see if it has the same problem.

nou nou
Registered User
Posts: 210
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.2][BETA] Linked Accounts

Post by nou nou » Mon Mar 12, 2018 8:50 pm

Froddelaar wrote:
Mon Mar 12, 2018 8:17 pm
fagbutlil wrote:
Mon Mar 12, 2018 7:18 pm
I use the account switcher by dmzx that works great.
Yes, but only for VIP users ;)
Surely the price of a coffee isn't too much to ask for something you find useful?

User avatar
Flerex
Registered User
Posts: 61
Joined: Sun Oct 14, 2012 8:35 pm
Location: Galicia, Spain
Name: Flerex
Contact:

Re: [3.2][BETA] Linked Accounts

Post by Flerex » Mon Mar 12, 2018 9:17 pm

nou nou wrote:
Mon Mar 12, 2018 8:49 pm
fagbutlil wrote:
Mon Mar 12, 2018 7:18 pm
I use the account switcher by dmzx that works great.
Apart from that the UCP tab for Linked Account shows even when you don't have the permission to use the extension.

Keeping an eye on this one to see if it has the same problem.
I can confirm that doesn't happen with Linked Accounts.

nou nou
Registered User
Posts: 210
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.2][BETA] Linked Accounts

Post by nou nou » Tue Mar 13, 2018 5:42 am

Flerex wrote:
Mon Mar 12, 2018 9:17 pm
I can confirm that doesn't happen with Linked Accounts.
Indeed it doesn't :)

Sweet little extension, works quite well already.

A little feedback if you don't mind.

Use case to consider: I'm testing giving the Linked Accounts permission to individual users. Say account A.

Account A, having the permission, sets up a link with account B.

Account B appears in the User menu, all goes well.

Then switch to account B. Account A is now in the user menu. Click on account A to switch back and the permission error is thrown: Account B does not have the permission to link accounts.

I can think of two solutions. Either the permissions need to be given to both accounts before the link is set up. Not ideal because of a potential added admin burden. Also the extension will need to check if account B has the required permission.

Else the extension needs to somehow work if any of the linked accounts has the permission, but I don't know if that is possible.

A couple of small things. You're adding some CSS which really doesn't play well with custom styles in the dropdown menu, notably

Code: Select all

#linked_accounts {
    order: 1;
    border-top: none;
    background-color: #ECF1F3;
    margin: 5px -5px -5px -5px;
    padding: 5px 10px;
}
If you remove background-color, margin and padding it works a lot better. In fact I don't think any of it is necessary.

Could you add a little icon to it, please, to match the other items in the menu? An icon of a link or something would be great :)

When installing the extension, by default it's enabled for all registered users. IMO it would be better for it to be disabled, and let admins decide who will be able to use the extension.

As a feature request, would it be possible to add a way (it could be a list that lives in the ACP) for admins to see a list of all users that have linked accounts, and what those accounts are?

Thanks!

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3271
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [3.2][BETA] Linked Accounts

Post by HiFiKabin » Tue Mar 13, 2018 11:50 am

Flerex wrote:
Mon Mar 12, 2018 8:40 pm
HiFiKabin wrote:
Mon Mar 12, 2018 4:14 pm
phpBB 3.2.2

php 7.0.25
I'm still not able to replicate the problem. Is it a fresh phpBB installation? Do you have any other extensions installed?

I don't know what may be happening.
:oops: my error not yours. Working perfectly.

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: karbiko, Mathieu M. and 23 guests