To be honest I don't see any advantage by doing so. Right now you can link to any account (even if the latter doesn't have permissions) and you can switch to that account because you have permissions in the initial account. In account B you wouldn't be able to switch back because you don't have permissions. Maybe the best thing would be to hide the links from account B, as it doesn't have permissions.nou nou wrote: ↑Tue Mar 13, 2018 5:42 am Use case to consider: I'm testing giving the Linked Accounts permission to individual users. Say account A.
Account A, having the permission, sets up a link with account B.
Account B appears in the User menu, all goes well.
Then switch to account B. Account A is now in the user menu. Click on account A to switch back and the permission error is thrown: Account B does not have the permission to link accounts.
I can think of two solutions. Either the permissions need to be given to both accounts before the link is set up. Not ideal because of a potential added admin burden. Also the extension will need to check if account B has the required permission.
Else the extension needs to somehow work if any of the linked accounts has the permission, but I don't know if that is possible.
It is necessary to somehow separate in the UI all menu elements regarding the current account and the items that are part of the Linked Accounts for UX reasons. Right not it might not look very well in other prosilver based styles because they don't have support. I see two possibilities, either add support for the themes that need it or find another way to show the links that is more style-friendly and that doesn't clutter the interface.nou nou wrote: ↑Tue Mar 13, 2018 5:42 am A couple of small things. You're adding some CSS which really doesn't play well with custom styles in the dropdown menu, notably
If you remove background-color, margin and padding it works a lot better. In fact I don't think any of it is necessary.Code: Select all
#linked_accounts { order: 1; border-top: none; background-color: #ECF1F3; margin: 5px -5px -5px -5px; padding: 5px 10px; }
I'm going to add the avatars of the accounts. I think it could look nice.
I don't agree with this. Having it enabled by default is the expected behavior when you install the extension. In most cases administrators will want users to use this feature when they install it. If you want to specify which groups should be able to use it I think in that case the administrator should edit permissions according to their need. If the linking permissions are disabled out of the box, permissions would have to be edited in all use cases and some administrators might even think the extension is not working.
That's a great idea. I'll be working on it.