Page 19 of 49

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 2:53 pm
by david63
@hurghanico - Are you OK at editing code?

If so openprivacypolicy/core/privacypolicy_lang.php
Find (should be around line 136

Code: Select all

public function get_text($lang_name, $lang_id, $validate = true)
	{
		if ($validate)
		{
			// Is the user a Guest? If so then we need to default
		    if ($this->user->data['user_id'] == ANONYMOUS)
			{
				$lang_valid = false;
			}
Replace with

Code: Select all

public function get_text($lang_name, $lang_id, $validate = true)
	{
		if ($validate)
		{
			// Is the user a Guest? If so then we need to default
		    if ($this->user->data['user_id'] == ANONYMOUS)
			{
				$lang_valid = true;
			}

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 3:10 pm
by hurghanico
david63 wrote:
Wed May 23, 2018 2:53 pm
@hurghanico - Are you OK at editing code?

If so openprivacypolicy/core/privacypolicy_lang.php
Find (should be around line 136

Code: Select all

public function get_text($lang_name, $lang_id, $validate = true)
	{
		if ($validate)
		{
			// Is the user a Guest? If so then we need to default
		    if ($this->user->data['user_id'] == ANONYMOUS)
			{
				$lang_valid = false;
			}
Replace with

Code: Select all

public function get_text($lang_name, $lang_id, $validate = true)
	{
		if ($validate)
		{
			// Is the user a Guest? If so then we need to default
		    if ($this->user->data['user_id'] == ANONYMOUS)
			{
				$lang_valid = true;
			}
Fantastic!.. it works!!.. I changed "false" to "true" and saved the file.. that's the solution!

Thanks a lot for your time! :)

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 3:23 pm
by david63
Thanks

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 7:09 pm
by Havym
When trying to download the csv file in your own profile i get an error.
Het verstuurde formulier is ongeldig. Probeer het nogmaals te versturen.
The submitted form is invalid. Try sending it again.

I'm using xammp

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 8:30 pm
by david63
Havym wrote:
Wed May 23, 2018 7:09 pm
When trying to download the csv file in your own profile i get an error.
Het verstuurde formulier is ongeldig. Probeer het nogmaals te versturen.
The submitted form is invalid. Try sending it again.

I'm using xammp
The most common reason for that error message is the time between opening the page and performing the download.

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 8:58 pm
by tlem
Good evening David
david63 wrote:
Wed May 23, 2018 7:13 am
I do not believe that there is a bug with this.
I do not know what other users think, but I think there is a big logic problem!

If I take the capture from hurghanico message :
Image

Since in the comboBox the English language is selected, where is the logic to display all the "files" of policy?
Imagine an administrator who needs to have policies translated into 5 or more languages ... This would make him a list of 20 lines. ^^
Logic wants the choice of combobox to filter the list in relation to the selected language.

david63 wrote:
Wed May 23, 2018 7:13 am
But this also has the advantage that you can install this extension without having a language file translation
It can also be a disadvantage
david63 wrote:
Wed May 23, 2018 7:13 am
and you can have the policy files translatable in your language.
I'll just point out that installing an extension requires a minimum of knowledge. Moreover if you want this extension in your language, you must also add the translated files to the right places or translate them yourself! The technique needed for this kind of thing is no more advanced than having a "text" file with BBCode formatting as displayed in the editing interface. But this is only my opinion. You are the devellopper and as such it is normal that you decide how you develop your extension.
david63 wrote:
Wed May 23, 2018 7:13 am
There is no right or wrong/better or worse ways to do this as both have their advantages and disadvantages. As I said before I had to make a decision on which way to go and one of the main underlying factors was the constraints with extensions about editing files which would be necessary if language files were used.
As a participant and probably future user, I shared my opinion and my logic. I will survive your choices. :lol:

Anyway, thank you very much for your great work. If one day you go through Bordeaux, it is with pleasure that I welcome you and share a good bottle of wine with you.

Edit :
I'm probably going to be an idiot, but how does one display the image directly in the message? I tried different image hosting sites and I used the IMG tag, but it does not work.
That's what I get if I do [ img]https://imgur.com/i6A6Yvj[ /img] : Image

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 9:17 pm
by Acorn
You need the link to the actual image (right click on the image and choose 'view image', then copy the url from that) and put the img tags around that.

Image

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 9:23 pm
by tlem
Tank you Acorn.
It was simply missing the file extension (that the site i.imgur.com does not generate in its link)

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 10:21 pm
by Havym
david63 wrote:
Wed May 23, 2018 8:30 pm
The most common reason for that error message is the time between opening the page and performing the download.
Well i waited a minute on the profile page before requesting the download but still this error. How can i fix it?

Re: [3.2][RC] Privacy Policy

Posted: Wed May 23, 2018 10:28 pm
by hurghanico
tlem wrote:
Wed May 23, 2018 9:23 pm
Tank you Acorn.
It was simply missing the file extension (that the site i.imgur.com does not generate in its link)
with imgur.com instead of using the "Image link" you can choose the already made BBcode, or the "Direct link" (and then add the img tags around it), both options include the image file extension..

Image

Re: [3.2][RC] Privacy Policy

Posted: Thu May 24, 2018 6:06 am
by Lech-u
David,
I have a problem.
Before I used version [RC] 2.1.0-rc2. Everything was OK.
Now I changed into version [RC] 2.1.0-rc5 and on ACP is not possible to enable this version.
It is mistake.

What wrong I did?

Re: [3.2][RC] Privacy Policy

Posted: Thu May 24, 2018 8:34 am
by david63
Havym wrote:
Wed May 23, 2018 10:21 pm
david63 wrote:
Wed May 23, 2018 8:30 pm
The most common reason for that error message is the time between opening the page and performing the download.
Well i waited a minute on the profile page before requesting the download but still this error. How can i fix it?
It is a bug, that I introduced, that is fixed in the next release

Re: [3.2][RC] Privacy Policy

Posted: Thu May 24, 2018 5:22 pm
by bill1980
DELETED

Re: [3.2][RC] Privacy Policy

Posted: Thu May 24, 2018 7:27 pm
by ammar rauf
how can i active david63-privacypolicy-3.2 extension , i download the extension and unzip it to ext/david63/privacypolicy, but i can't find in (acp) Extensions Manager to enable it, please help

Re: [3.2][RC] Privacy Policy

Posted: Thu May 24, 2018 7:39 pm
by janus_zonstraal
Can you place a screenprint from your ftp so we can check the directories?