[3.2][RC] Modern quote - multiquote and quote highlighted text

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu May 24, 2018 1:06 pm

I've edited my previous post while you've posted your latest reply.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
jan_2017
Registered User
Posts: 124
Joined: Sun May 07, 2017 3:39 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jan_2017 » Thu May 24, 2018 1:20 pm

Ger wrote:
Thu May 24, 2018 12:45 pm
(...)
jan_2017 wrote:
Thu May 24, 2018 12:30 pm
Unfortunately, ä,ü,ö are not copied. Question marks are displayed instead.
This is now fixed.
jan_2017 wrote:
Thu May 24, 2018 12:30 pm
Furthermore, all quoted text passages are displayed one after the other without a paragraph If I select text passages from three different posts in one topic then these are also displayed but not with the original author.
That's correct. If you want to quote from multiple posts, you should use the multiquote option.
Ok, but in your screenshot you show that you want to mark several text passages and then quote them.

Normally, each marked text passage would have to be start with [ quote=user post_id=14026 time=1527114197 user_id=5]quoted text[/quote] and displayed individually in the texteditor.

Bye Jan

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu May 24, 2018 1:46 pm

jan_2017 wrote:
Thu May 24, 2018 1:20 pm
Normally, each marked text passage would have to be start with [qu ote=user post_id=14026 time=1527114197 user_id=5]quoted text[/qu ote] and displayed individually in the texteditor.
Normally, highlighting text wouldn't do anything in phpBB :P

What you propose simply won't work without the quick reply enabled. With QR disabled, I pass the highlighted text to the query string in the URL alongside default post button data. That works, but also has some limitations since I only have 1 quote URL.

Now I think I might get something like this to work, but it would be quite hard to implement and isn't how I've intended this to work. It's intended to enable you to quote a small portion of a post. And like you've pointed out yourself; highlighting several separate parts on a page is only possible in Firefox so I think it's not worth it to rebuild all this for. Worldwide we represent 10% of the users at best.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

jackennils
Registered User
Posts: 153
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Thu May 24, 2018 1:49 pm

Hi Ger, I have just tested this on my test board and everything works. Thank you for this excellent extension! :)

User avatar
jan_2017
Registered User
Posts: 124
Joined: Sun May 07, 2017 3:39 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jan_2017 » Thu May 24, 2018 1:51 pm

All right. It was an idea of mine :D

Keep on going ... goog job! :ugeek:

Bye Jan

jackennils
Registered User
Posts: 153
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Thu May 24, 2018 2:12 pm

Okay, I found some issues. When I'm not using prosilver and try to quote marked text, I get this:
You don't have permission to access /test-forum/undefined&post_text=tur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit am on this server.
And when I try to quote a text with non-standard letters like ä, ö or ü, I get this:
Information - The requested page could not be found.
The URL is showing: /test-forum/undefined&post_text=ää

But the exact same thing works with prosilver.
Is there any dependency on a specific file that maybe my template does not have?

:cry:
Last edited by jackennils on Thu May 24, 2018 2:47 pm, edited 2 times in total.

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu May 24, 2018 2:32 pm

jackennils wrote:
Thu May 24, 2018 2:12 pm
Okay, I found some issues. When I'm not using prosilver and try to quote marked text, I get this:
You don't have permission to access /test-forum/undefined&post_text=tur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit am on this server.
And when I try to quote a text with non-standard letters like ä, ö or ü, I get this:
Information - The requested page could not be found.
The URL is showing: /test-forum/undefined&post_text=ää

But the exact same thing works with prosilver.
Is there any dependency on a specific file that maybe my template does not have?

:cry:
I see "undefined" in your URL:

Code: Select all

/test-forum/undefined&post_text=tur --/snip/--
That would mean the script cannot find the basic quote URL a quote button this way:

Code: Select all

var quote_url = post.find('.post-buttons i.fa-quote-left').parents('a.button').attr('href');
So it seems you have other classes in your template. Impossible to say without knowing either your board URL or seeing a live demo to checkout the regular quote button.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

jackennils
Registered User
Posts: 153
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Thu May 24, 2018 2:49 pm

Okay, that's what I assumed. You can check the live version of my forum here: https://mydivision.net/forum/
It does not have your ext installed yet.

Posting buttons look like this:

Code: Select all

<li>
  <a href="./posting.php?mode=quote&amp;f=3&amp;p=67467" title="Mit Zitat antworten"><i class="fas fa-quote-left"></i><span>Zitat</span></a>
</li>

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu May 24, 2018 3:18 pm

Well, that part seems actually OK. However, your style has a tiny but important difference:

Code: Select all

<ul class="posts-buttons">
as opposed to:

Code: Select all

<ul class="post-buttons">
No idea why they've chosen that, I for one never expected this :P

Right now I'm pushing a small fix to Github that should bypass this.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

jackennils
Registered User
Posts: 153
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Thu May 24, 2018 4:15 pm

Well, my template also does not have #page-body but #wrap-body, so I will have to amend it anyways.

But even with changing the .posts-buttons part, my link attribute does not have the class .button, so

Code: Select all

.parents('a.button')
must be changed to

Code: Select all

.parents('a')
right?


Edit: Okay, got it working. :)

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri May 25, 2018 6:57 am

jackennils wrote:
Thu May 24, 2018 4:15 pm
Edit: Okay, got it working. :)
Great :)
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

parthunter_harrison
Registered User
Posts: 7
Joined: Fri May 25, 2018 11:37 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by parthunter_harrison » Sat May 26, 2018 4:05 am

Will this extension work with a WYSIWYG Editor?

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Sat May 26, 2018 1:03 pm

I think that depends on the WYSIWYG editor you use. Give it a try I'd say, and let us know.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

ko13o
Registered User
Posts: 6
Joined: Tue May 08, 2018 8:10 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by ko13o » Mon Jun 04, 2018 9:17 am

I just used it.
when the desktop view is successful
but when the display is smaller or the display on the phone
can not run
but my position is an admin
if using member can

Image

User avatar
Ger
Recognised Extension Developer
Posts: 1486
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Jun 04, 2018 9:26 am

I'm not sure what you mean here, can you try to explain better?
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote
Newest: Quoted Where + anonymize

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Meis2M, nou nou and 24 guests