[CDB] Modern quote - multiquote and quote highlighted text

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Oct 08, 2018 8:00 am

null2 wrote:
Fri Oct 05, 2018 8:36 pm
This little window at right will be there forever. I have to disable this extension and delete data to remove it.
Again, which version?

The latest version has 2 ways to disable the selected quotes: deselecting the posts you selected earlier, or hitting the trash can button:
Image
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
null2
Registered User
Posts: 435
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by null2 » Mon Oct 08, 2018 12:23 pm

Im using 1.0.2 version.

But now, I could find something interesting. Looking this window, I cant see the trashbin:

Image

But if I put the mouse on the window, trashbin will appears!

Image

is there a way to keep it showed all time?
Sorry for my bad english. I'm from USA.

User avatar
jackennils
Registered User
Posts: 186
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Mon Oct 08, 2018 12:30 pm

You are using a different style than prosilver. You need to amend the template files for your style to make it work.

User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Oct 08, 2018 1:02 pm

I have only provided default styling for prosilver. That works for most forums, but if you have a different colour scheme like yours, you'll miss some stuff. You will have to add your custom styling to make things pretty.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
null2
Registered User
Posts: 435
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by null2 » Mon Oct 08, 2018 11:18 pm

I will adjust it to others styles.

Thanks.
Sorry for my bad english. I'm from USA.

User avatar
null2
Registered User
Posts: 435
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by null2 » Mon Oct 08, 2018 11:41 pm

Sorry for my bad english. I'm from USA.

Guguss02
Registered User
Posts: 3
Joined: Mon Dec 11, 2017 6:05 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Guguss02 » Tue Oct 09, 2018 6:04 am

Hello Ger,

ModerQuote is a very usefull extension and that's why i'm trying to adapt it on a premium theme of phpbb : RAVAIO

In ravaio, this code of viewtopic-body.html :
<li>
<a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}" class="button button-icon-only">
<i class="icon fa-quote-left fa-fw" aria-hidden="true"></i><span class="sr-only">{L_QUOTE}</span>
</a>
</li>


has been replaced by this code :
<li>
<a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}"><span>{L_QUOTE}<span></a>
</li>


No more button, no more quote-left icon...


So this line of moderquote.js no longer works :
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');

I don't know anything about JS, can you help me solve this little problem?
So what can you replace find('i.fa-quote-left').first().parents('a.button') to make it work?

There were other little problems but I fixed it all, there's only this one left...

Thank's for your time,
Guguss

my board : https://forum.instinct-photo.fr

User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Tue Oct 09, 2018 6:46 am

@Guguss02
Which version of modern quote do you have? I *think* the development version from github might to the trick for you.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
pikachuturkey
Registered User
Posts: 266
Joined: Wed Dec 20, 2006 10:34 pm
Name: Rıza
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by pikachuturkey » Tue Oct 09, 2018 7:13 am

Turkish (tr) translation of "[3.2][RC] Modern quote - multiquote and quote highlighted text" (from github - 09.10.2018).

Code: Select all

<?php
/**
 *
 * Modern quotes. An extension for the phpBB Forum Software package.
 * 
 *
 * @copyright (c) 2017, Ger, https://github.com/GerB
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */
if (!defined('IN_PHPBB'))
{
	exit;
}
if (empty($lang) || !is_array($lang))
{
	$lang = array();
}
$lang = array_merge($lang, array(
    'MQ_CLEAR'                 => 'Temizle',
    'MQ_MULTI_QUOTE_SELECT'    => 'Çoklu gönderiden alıntı için seçin',
    'MQ_MULTI_QUOTE_ACTION'    => 'Seçili alıntılarla cevapla',
    'MQ_QUOTE_SELECTION'       => 'Alıntı seçimi',
		));    
Last edited by pikachuturkey on Tue Oct 09, 2018 10:47 am, edited 1 time in total.
Health For Everyone ==> www.saglikforum.org

Guguss
Registered User
Posts: 3
Joined: Tue Jun 06, 2017 6:11 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Guguss » Tue Oct 09, 2018 9:24 am

Ger wrote:
Tue Oct 09, 2018 6:46 am
@Guguss02
Which version of modern quote do you have? I *think* the development version from github might to the trick for you.
I've downloaded the RC version two weeks ago from Github.

and I just saw that Modern Quote is no longer a RC. Great, congratulation ;)

User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Tue Oct 09, 2018 9:51 am

Guguss wrote:
Tue Oct 09, 2018 9:24 am
and I just saw that Modern Quote is no longer a RC. Great, congratulation ;)
Thanks. :) Unfortunately I can't set the topic prefix to CDB anymore.

Anyhow; I've looked a bit closer at your style. It's not inheriting from Prosilver, therefore it doesn't pick up the template events I've used. You might want to copy the folder
./ext/ger/modernquote/styles/prosilver/
to
./ext/ger/modernquote/styles/ravaio/
You'll probably need to tweak the CSS file to get the colors and positioning to make it fit better into your style, but it should do the trick.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

Guguss
Registered User
Posts: 3
Joined: Tue Jun 06, 2017 6:11 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Guguss » Tue Oct 09, 2018 10:23 am

Thanks for your support.
Ger wrote:
Tue Oct 09, 2018 9:51 am
I've looked a bit closer at your style. It's not inheriting from Prosilver, therefore it doesn't pick up the template events I've used. You might want to copy the folder
./ext/ger/modernquote/styles/prosilver/
to
./ext/ger/modernquote/styles/ravaio/
As I was writing this morning, I have already started to adapt Modern Quote to RAVAIO. So, I've already created ./ext/ger/modernquote/styles/ravaio/. No matter with template events or CSS ;)

But I stumble on javascript :?

Do you have any idea how to modify this line of modernquote.js
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');

so that it returns the href value of this line of code :
<li><a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}"><span>{L_QUOTE}<span></a></li>


As JS does not find fa.quote-left in the code, I get the error "No route found for "GET /undefined&multiquote=...."

This is the only point that is blocking today.

User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Tue Oct 09, 2018 12:04 pm

Guguss wrote:
Tue Oct 09, 2018 10:23 am
As I was writing this morning, I have already started to adapt Modern Quote to RAVAIO. So, I've already created ./ext/ger/modernquote/styles/ravaio/. No matter with template events or CSS ;)

But I stumble on javascript :?

Do you have any idea how to modify this line of modernquote.js
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');
If you are sure you have the events sorted, this might work:

Code: Select all

var quote_url = $('.postbody').find('.hide.postdetails').first().attr('data-quote-url') + '&multiquote=' + multiquote_ary.join(';');
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

Guguss02
Registered User
Posts: 3
Joined: Mon Dec 11, 2017 6:05 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Guguss02 » Tue Oct 09, 2018 5:02 pm

A clever solution that works perfectly :D
That's great, thanks a lot Ger !!

User avatar
Ger
Recognised Extension Developer
Posts: 1771
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [CDB] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Oct 15, 2018 9:06 am

Extension is validated. Information and support here:
https://www.phpbb.com/customise/db/exte ... ern_quote/
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: cachete, caiocald, Majestic-12 [Bot], Manick_swe, martti, Ozo and 34 guests