Page 8 of 8

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 8:00 am
by Ger
null2 wrote:
Fri Oct 05, 2018 8:36 pm
This little window at right will be there forever. I have to disable this extension and delete data to remove it.
Again, which version?

The latest version has 2 ways to disable the selected quotes: deselecting the posts you selected earlier, or hitting the trash can button:
Image

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 12:23 pm
by null2
Im using 1.0.2 version.

But now, I could find something interesting. Looking this window, I cant see the trashbin:

Image

But if I put the mouse on the window, trashbin will appears!

Image

is there a way to keep it showed all time?

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 12:30 pm
by jackennils
You are using a different style than prosilver. You need to amend the template files for your style to make it work.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 1:02 pm
by Ger
I have only provided default styling for prosilver. That works for most forums, but if you have a different colour scheme like yours, you'll miss some stuff. You will have to add your custom styling to make things pretty.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 11:18 pm
by null2
I will adjust it to others styles.

Thanks.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 08, 2018 11:41 pm
by null2

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 6:04 am
by Guguss02
Hello Ger,

ModerQuote is a very usefull extension and that's why i'm trying to adapt it on a premium theme of phpbb : RAVAIO

In ravaio, this code of viewtopic-body.html :
<li>
<a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}" class="button button-icon-only">
<i class="icon fa-quote-left fa-fw" aria-hidden="true"></i><span class="sr-only">{L_QUOTE}</span>
</a>
</li>


has been replaced by this code :
<li>
<a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}"><span>{L_QUOTE}<span></a>
</li>


No more button, no more quote-left icon...


So this line of moderquote.js no longer works :
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');

I don't know anything about JS, can you help me solve this little problem?
So what can you replace find('i.fa-quote-left').first().parents('a.button') to make it work?

There were other little problems but I fixed it all, there's only this one left...

Thank's for your time,
Guguss

my board : https://forum.instinct-photo.fr

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 6:46 am
by Ger
@Guguss02
Which version of modern quote do you have? I *think* the development version from github might to the trick for you.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 7:13 am
by pikachuturkey
Turkish (tr) translation of "[3.2][RC] Modern quote - multiquote and quote highlighted text" (from github - 09.10.2018).

Code: Select all

<?php
/**
 *
 * Modern quotes. An extension for the phpBB Forum Software package.
 * 
 *
 * @copyright (c) 2017, Ger, https://github.com/GerB
 * @license GNU General Public License, version 2 (GPL-2.0)
 *
 */
if (!defined('IN_PHPBB'))
{
	exit;
}
if (empty($lang) || !is_array($lang))
{
	$lang = array();
}
$lang = array_merge($lang, array(
    'MQ_CLEAR'                 => 'Temizle',
    'MQ_MULTI_QUOTE_SELECT'    => 'Çoklu gönderiden alıntı için seçin',
    'MQ_MULTI_QUOTE_ACTION'    => 'Seçili alıntılarla cevapla',
    'MQ_QUOTE_SELECTION'       => 'Alıntı seçimi',
		));    

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 9:24 am
by Guguss
Ger wrote:
Tue Oct 09, 2018 6:46 am
@Guguss02
Which version of modern quote do you have? I *think* the development version from github might to the trick for you.
I've downloaded the RC version two weeks ago from Github.

and I just saw that Modern Quote is no longer a RC. Great, congratulation ;)

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 9:51 am
by Ger
Guguss wrote:
Tue Oct 09, 2018 9:24 am
and I just saw that Modern Quote is no longer a RC. Great, congratulation ;)
Thanks. :) Unfortunately I can't set the topic prefix to CDB anymore.

Anyhow; I've looked a bit closer at your style. It's not inheriting from Prosilver, therefore it doesn't pick up the template events I've used. You might want to copy the folder
./ext/ger/modernquote/styles/prosilver/
to
./ext/ger/modernquote/styles/ravaio/
You'll probably need to tweak the CSS file to get the colors and positioning to make it fit better into your style, but it should do the trick.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 10:23 am
by Guguss
Thanks for your support.
Ger wrote:
Tue Oct 09, 2018 9:51 am
I've looked a bit closer at your style. It's not inheriting from Prosilver, therefore it doesn't pick up the template events I've used. You might want to copy the folder
./ext/ger/modernquote/styles/prosilver/
to
./ext/ger/modernquote/styles/ravaio/
As I was writing this morning, I have already started to adapt Modern Quote to RAVAIO. So, I've already created ./ext/ger/modernquote/styles/ravaio/. No matter with template events or CSS ;)

But I stumble on javascript :?

Do you have any idea how to modify this line of modernquote.js
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');

so that it returns the href value of this line of code :
<li><a href="{postrow.U_QUOTE}" title="{L_REPLY_WITH_QUOTE}"><span>{L_QUOTE}<span></a></li>


As JS does not find fa.quote-left in the code, I get the error "No route found for "GET /undefined&multiquote=...."

This is the only point that is blocking today.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 12:04 pm
by Ger
Guguss wrote:
Tue Oct 09, 2018 10:23 am
As I was writing this morning, I have already started to adapt Modern Quote to RAVAIO. So, I've already created ./ext/ger/modernquote/styles/ravaio/. No matter with template events or CSS ;)

But I stumble on javascript :?

Do you have any idea how to modify this line of modernquote.js
var quote_url = $('#page-body').find('i.fa-quote-left').first().parents('a.button').attr('href') + '&multiquote=' + multiquote_ary.join(';');
If you are sure you have the events sorted, this might work:

Code: Select all

var quote_url = $('.postbody').find('.hide.postdetails').first().attr('data-quote-url') + '&multiquote=' + multiquote_ary.join(';');

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Oct 09, 2018 5:02 pm
by Guguss02
A clever solution that works perfectly :D
That's great, thanks a lot Ger !!

Re: [CDB] Modern quote - multiquote and quote highlighted text

Posted: Mon Oct 15, 2018 9:06 am
by Ger
Extension is validated. Information and support here:
https://www.phpbb.com/customise/db/exte ... ern_quote/