[3.2][RC] Modern quote - multiquote and quote highlighted text

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu Apr 12, 2018 3:29 pm

remoss wrote:
Thu Apr 12, 2018 3:15 pm
Ger wrote:
Thu Apr 12, 2018 3:01 pm
Is it? Haven't noticed that. Is that with de quick reply enabled, or with the full editor?
On both:No only on quick reply
Could you try on Prosilver? It seems the extension cannot find the element it's looking for.
Yep, that's the one. Well it's not really a conflict, i just have to find another way to disable quoting of the last post.
Not sure how good your JS skills are, but you might want to change this selector to exclude last-of-type.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Thu Apr 12, 2018 4:00 pm

Ger wrote:
Thu Apr 12, 2018 3:29 pm
Could you try on Prosilver? It seems the extension cannot find the element it's looking for.
Switched to prosilver, same thing, to be sure I also switched of the "No quote last post" extension:

With Quick Reply ON
[quote post_id=23358 time=1501605763 user_id=682 author=]
Ik zie het, dank!
[/quote]


Quick reply OFF
[quote=Bert post_id=23358 time=1501605763 user_id=682]Ik zie het, dank![/quote]
Ger wrote:
Thu Apr 12, 2018 3:29 pm
Not sure how good your JS skills are, but you might want to change this selector to exclude last-of-type.
I'm no programmer, just a sort of hobby :) But will look in to that, thanks!

EDIT: looked at the JS code, sorry, I can not do anything with it :shock:

User avatar
John connor
Registered User
Posts: 1525
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by John connor » Thu Apr 12, 2018 5:37 pm

Seems to work and the quote button is next to the text this time. I don't have a problem with the quoted user name. I tried this in two forums both with different themes.

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Thu Apr 12, 2018 8:56 pm

John connor wrote:
Thu Apr 12, 2018 5:37 pm
I don't have a problem with the quoted user name. I tried this in two forums both with different themes.
You use Quick Reply? I have three forums, all three the same.

User avatar
John connor
Registered User
Posts: 1525
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by John connor » Fri Apr 13, 2018 1:47 am

Quick reply is on as this extension requires it. I never had it on from the begin with, but it's on now.

If you are having an issue with this extension then it's more than likely related to another one of your extensions you have installed. I would try disabling any extension you suspect as having an influence on this extension then if that doesn't work try disabling other extensions until this extension works as it should. Once you narrow down what extension is interfering you can name it here and then go to that extension autor and ask him/her to fix it.

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Fri Apr 13, 2018 5:18 am

I disabled all other extensions , deleted data and purched the cache, no luck, still the same thing.
Tried several PHP version, no luck!

User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Apr 13, 2018 6:46 am

John connor wrote:
Fri Apr 13, 2018 1:47 am
Quick reply is on as this extension requires it.
Not any more though so if you'd like to you can disable it again.
remoss wrote:
Fri Apr 13, 2018 5:18 am
I disabled all other extensions , deleted data and purched the cache, no luck, still the same thing.
Tried several PHP version, no luck!
PHP version doesn't matter for this, this part is javascript only so it happens in your browser.

Might want to tell me: which phpBB version do you have installed and which browser have you tried?
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Fri Apr 13, 2018 8:05 am

I use phpbb 3.2.2. Tried it on Firefox, Chrome and IE, all same result.

User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Apr 13, 2018 8:37 am

Curious. Works here with similar setup. Mind to give me a test-login so I can check what happens?
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Fri Apr 13, 2018 10:19 am

What kind of account do you need? Have to do that from home later today.

User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Apr 13, 2018 11:11 am

Just a regular user with posting permission on 1 forum. I won't actually post something, but I need the form so I can check what happens in the process.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Apr 13, 2018 2:34 pm

Testing proved I looked for an element not present on your forum.

I've wrapped the relevant data for quoting in 1 element now that I have full control of. Just pushed an update to Github, that one should work on your board.
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Fri Apr 13, 2018 2:46 pm

Tested the pushed version and voila, it works! Nice work, Ger, many thanks :)

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by remoss » Fri Apr 13, 2018 4:42 pm

Removing the multiquote button in the last post of a topic wasn't hard to figure out btw.

In viewtopic_body_post_buttons_after.html is changed <!-- IF postrow.U_QUOTE --> to <!-- IF postrow.U_QUOTE and (not U_NEXT_PAGE and not postrow.S_LAST_ROW) -->

User avatar
Ger
Recognised Extension Developer
Posts: 1415
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Apr 13, 2018 5:17 pm

Great :)
My extensions: Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update and Modern Quote

Like my work? Buy me a coffee to keep it coming. :ugeek:

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Bermudez, Canoran, nou nou, Tarantino and 30 guests