Page 2 of 8

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Thu Apr 12, 2018 3:29 pm
by Ger
remoss wrote:
Thu Apr 12, 2018 3:15 pm
Ger wrote:
Thu Apr 12, 2018 3:01 pm
Is it? Haven't noticed that. Is that with de quick reply enabled, or with the full editor?
On both:No only on quick reply
Could you try on Prosilver? It seems the extension cannot find the element it's looking for.
Yep, that's the one. Well it's not really a conflict, i just have to find another way to disable quoting of the last post.
Not sure how good your JS skills are, but you might want to change this selector to exclude last-of-type.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Thu Apr 12, 2018 4:00 pm
by remoss
Ger wrote:
Thu Apr 12, 2018 3:29 pm
Could you try on Prosilver? It seems the extension cannot find the element it's looking for.
Switched to prosilver, same thing, to be sure I also switched of the "No quote last post" extension:

With Quick Reply ON
[quote post_id=23358 time=1501605763 user_id=682 author=]
Ik zie het, dank!
[/quote]


Quick reply OFF
[quote=Bert post_id=23358 time=1501605763 user_id=682]Ik zie het, dank![/quote]
Ger wrote:
Thu Apr 12, 2018 3:29 pm
Not sure how good your JS skills are, but you might want to change this selector to exclude last-of-type.
I'm no programmer, just a sort of hobby :) But will look in to that, thanks!

EDIT: looked at the JS code, sorry, I can not do anything with it :shock:

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Thu Apr 12, 2018 5:37 pm
by John connor
Seems to work and the quote button is next to the text this time. I don't have a problem with the quoted user name. I tried this in two forums both with different themes.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Thu Apr 12, 2018 8:56 pm
by remoss
John connor wrote:
Thu Apr 12, 2018 5:37 pm
I don't have a problem with the quoted user name. I tried this in two forums both with different themes.
You use Quick Reply? I have three forums, all three the same.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 1:47 am
by John connor
Quick reply is on as this extension requires it. I never had it on from the begin with, but it's on now.

If you are having an issue with this extension then it's more than likely related to another one of your extensions you have installed. I would try disabling any extension you suspect as having an influence on this extension then if that doesn't work try disabling other extensions until this extension works as it should. Once you narrow down what extension is interfering you can name it here and then go to that extension autor and ask him/her to fix it.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 5:18 am
by remoss
I disabled all other extensions , deleted data and purched the cache, no luck, still the same thing.
Tried several PHP version, no luck!

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 6:46 am
by Ger
John connor wrote:
Fri Apr 13, 2018 1:47 am
Quick reply is on as this extension requires it.
Not any more though so if you'd like to you can disable it again.
remoss wrote:
Fri Apr 13, 2018 5:18 am
I disabled all other extensions , deleted data and purched the cache, no luck, still the same thing.
Tried several PHP version, no luck!
PHP version doesn't matter for this, this part is javascript only so it happens in your browser.

Might want to tell me: which phpBB version do you have installed and which browser have you tried?

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 8:05 am
by remoss
I use phpbb 3.2.2. Tried it on Firefox, Chrome and IE, all same result.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 8:37 am
by Ger
Curious. Works here with similar setup. Mind to give me a test-login so I can check what happens?

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 10:19 am
by remoss
What kind of account do you need? Have to do that from home later today.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 11:11 am
by Ger
Just a regular user with posting permission on 1 forum. I won't actually post something, but I need the form so I can check what happens in the process.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 2:34 pm
by Ger
Testing proved I looked for an element not present on your forum.

I've wrapped the relevant data for quoting in 1 element now that I have full control of. Just pushed an update to Github, that one should work on your board.

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 2:46 pm
by remoss
Tested the pushed version and voila, it works! Nice work, Ger, many thanks :)

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 4:42 pm
by remoss
Removing the multiquote button in the last post of a topic wasn't hard to figure out btw.

In viewtopic_body_post_buttons_after.html is changed <!-- IF postrow.U_QUOTE --> to <!-- IF postrow.U_QUOTE and (not U_NEXT_PAGE and not postrow.S_LAST_ROW) -->

Re: [3.2][ALPHA] Modern quote - multiquote and quote highlighted text

Posted: Fri Apr 13, 2018 5:17 pm
by Ger
Great :)