[3.2][RC] Modern quote - multiquote and quote highlighted text

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Thu Jun 21, 2018 9:42 am

jackennils wrote:
Thu Jun 21, 2018 8:51 am
Damn! But on Github it says the file was modified 28 days ago, so I did not expect it to have changed for 0.0.8. :(

Thanks for the help!
28 days ago was 0.0.7 IIRC. :)
Glad it works!

John connor wrote:
Thu Jun 21, 2018 9:27 am
How does this work? I highlighted a quote in one post then went to another topic and highlighted another post, but I can only highlight one post.
It's for the multiquote function only. So you can quote multiple (complete) posts at once.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
John connor
Registered User
Posts: 1726
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by John connor » Fri Jun 22, 2018 4:37 am

Okay, thanks.

jackennils
Registered User
Posts: 178
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Thu Aug 02, 2018 4:20 pm

Hey Ger, it's me again.

I discovered two strange issues:

First, when using the floating quote and you select text which contains smilies, they are only part of the quote when using FireFox. Chrome/Opera do not consider the smilies.

Second, when I select a text which contains a #, the quoted text stops right before the # symbol.

User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Fri Aug 03, 2018 9:49 am

jackennils wrote:
Thu Aug 02, 2018 4:20 pm
First, when using the floating quote and you select text which contains smilies, they are only part of the quote when using FireFox. Chrome/Opera do not consider the smilies.
Yeah that's simply a limitation from the browsers. Even though the smiley code is provided as alt text, several browsers just ignore it when using the toString() method. It's basically the same issue you have when you reply to this message in one of those browsers while selecting a part of my text with some smilies: :| :cry:

(reply without quote, scroll down to topic review, select a part of my text and hit the quote botton inside this post)

It's purely a browser issue so I cannot resolve it unfortunately.
Second, when I select a text which contains a #, the quoted text stops right before the # symbol.
That should be covered now, among some other issues.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

jackennils
Registered User
Posts: 178
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Fri Aug 03, 2018 10:15 am

Alright, understood. Thanks!

User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Sep 10, 2018 12:10 pm

Touch devices (phones/tablets etc) are now also supported for highlighting and quoting text.
This is tested on both Apple as Android devices and for Safari, Chrome, Firefox and Opera.

The Samsung browser seems to have some issues, but unfortunately I have no Samsung devices to test this on.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

jackennils
Registered User
Posts: 178
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Mon Sep 10, 2018 1:06 pm

I just gave it a try and yes, it works.

However, the floating quote button is a bit out of the screen if used with my style.
Maybe you want to take a look here:
https://mydivision.net/forum/


Also, I noticed a minor bug:
When selecting text with a double tap, the floating quote button instantly appears.
When selecting text with a long press, the floating quote button only appears after I scrolled at least a tiny bit. Otherwise it does not appear.

Tested on a OnePlus 5T with Android 8.1 and the latest Chrome.

User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Tue Sep 11, 2018 7:16 am

I see what you mean. Not sure how to solve that though. It seems like Chrome prevents firing the touchend event when selecting text.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
potku
Registered User
Posts: 800
Joined: Wed Dec 22, 2004 10:26 pm
Location: Tampere, Finland
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by potku » Tue Sep 11, 2018 8:41 am

This EXT rocks! 8-)

We just installed it, but I will report later. :)
Potku.net

"Before I speak, I have something important to say."

- Groucho Marx

jackennils
Registered User
Posts: 178
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by jackennils » Tue Sep 11, 2018 5:16 pm

Ger wrote:
Tue Sep 11, 2018 7:16 am
I see what you mean. Not sure how to solve that though. It seems like Chrome prevents firing the touchend event when selecting text.
Not a big deal. It works when selecting text via double tap anyway. It's fine. :)

User avatar
null2
Registered User
Posts: 424
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by null2 » Sat Sep 22, 2018 10:48 pm

After I reply with multiquotes, selected posts keep selected. What am I doing wrong?
Sorry for my bad english. I'm from USA.

User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Sep 24, 2018 7:54 am

Probably with Quick Reply enabled?

Which browser/OS?
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

User avatar
null2
Registered User
Posts: 424
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by null2 » Mon Sep 24, 2018 12:17 pm

To reply, I have clicked on the little window, at right bottom.

Im using Windows 7 and Updated Chrome.
Sorry for my bad english. I'm from USA.

User avatar
Ger
Recognised Extension Developer
Posts: 1678
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Post by Ger » Mon Sep 24, 2018 12:20 pm

Can you post a screenshot and place an arrow at which button you clicked?

Also, have you installed the latest version of Modern Quote from Github?
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:
-Available for custom work-

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Bruce Banner, martti, Mohammed AlSarsawi, Praggle, stevenospam and 20 guests