Page 7 of 8

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Thu Jun 21, 2018 9:42 am
by Ger
jackennils wrote:
Thu Jun 21, 2018 8:51 am
Damn! But on Github it says the file was modified 28 days ago, so I did not expect it to have changed for 0.0.8. :(

Thanks for the help!
28 days ago was 0.0.7 IIRC. :)
Glad it works!

John connor wrote:
Thu Jun 21, 2018 9:27 am
How does this work? I highlighted a quote in one post then went to another topic and highlighted another post, but I can only highlight one post.
It's for the multiquote function only. So you can quote multiple (complete) posts at once.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Fri Jun 22, 2018 4:37 am
by John connor
Okay, thanks.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Thu Aug 02, 2018 4:20 pm
by jackennils
Hey Ger, it's me again.

I discovered two strange issues:

First, when using the floating quote and you select text which contains smilies, they are only part of the quote when using FireFox. Chrome/Opera do not consider the smilies.

Second, when I select a text which contains a #, the quoted text stops right before the # symbol.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Fri Aug 03, 2018 9:49 am
by Ger
jackennils wrote:
Thu Aug 02, 2018 4:20 pm
First, when using the floating quote and you select text which contains smilies, they are only part of the quote when using FireFox. Chrome/Opera do not consider the smilies.
Yeah that's simply a limitation from the browsers. Even though the smiley code is provided as alt text, several browsers just ignore it when using the toString() method. It's basically the same issue you have when you reply to this message in one of those browsers while selecting a part of my text with some smilies: :| :cry:

(reply without quote, scroll down to topic review, select a part of my text and hit the quote botton inside this post)

It's purely a browser issue so I cannot resolve it unfortunately.
Second, when I select a text which contains a #, the quoted text stops right before the # symbol.
That should be covered now, among some other issues.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Fri Aug 03, 2018 10:15 am
by jackennils
Alright, understood. Thanks!

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Sep 10, 2018 12:10 pm
by Ger
Touch devices (phones/tablets etc) are now also supported for highlighting and quoting text.
This is tested on both Apple as Android devices and for Safari, Chrome, Firefox and Opera.

The Samsung browser seems to have some issues, but unfortunately I have no Samsung devices to test this on.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Sep 10, 2018 1:06 pm
by jackennils
I just gave it a try and yes, it works.

However, the floating quote button is a bit out of the screen if used with my style.
Maybe you want to take a look here:
https://mydivision.net/forum/


Also, I noticed a minor bug:
When selecting text with a double tap, the floating quote button instantly appears.
When selecting text with a long press, the floating quote button only appears after I scrolled at least a tiny bit. Otherwise it does not appear.

Tested on a OnePlus 5T with Android 8.1 and the latest Chrome.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Sep 11, 2018 7:16 am
by Ger
I see what you mean. Not sure how to solve that though. It seems like Chrome prevents firing the touchend event when selecting text.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Sep 11, 2018 8:41 am
by potku
This EXT rocks! 8-)

We just installed it, but I will report later. :)

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Tue Sep 11, 2018 5:16 pm
by jackennils
Ger wrote:
Tue Sep 11, 2018 7:16 am
I see what you mean. Not sure how to solve that though. It seems like Chrome prevents firing the touchend event when selecting text.
Not a big deal. It works when selecting text via double tap anyway. It's fine. :)

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Sat Sep 22, 2018 10:48 pm
by null2
After I reply with multiquotes, selected posts keep selected. What am I doing wrong?

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Sep 24, 2018 7:54 am
by Ger
Probably with Quick Reply enabled?

Which browser/OS?

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Sep 24, 2018 12:17 pm
by null2
To reply, I have clicked on the little window, at right bottom.

Im using Windows 7 and Updated Chrome.

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Mon Sep 24, 2018 12:20 pm
by Ger
Can you post a screenshot and place an arrow at which button you clicked?

Also, have you installed the latest version of Modern Quote from Github?

Re: [3.2][RC] Modern quote - multiquote and quote highlighted text

Posted: Fri Oct 05, 2018 8:36 pm
by null2
Im doing exactly as in this example:

Image

And yes, I have Quick Reply activated in all forums.

This little window at right will be there forever. I have to disable this extension and delete data to remove it.