[CDB] Prime Post Revisions

php_bb · Post by **php_bb** » Thu Mar 18, 2021 8:07 am

Dark❶ wrote: ↑Thu Mar 18, 2021 6:22 am What is this ???
Is it a SPAM ???

i couldn't delete the post.

Dark❶ wrote: ↑Thu Mar 18, 2021 6:22 am This, I'll Implement later,

thank you. sometimes first posts get more edits.

Dark❶ · Post by **Dark❶** » Thu Mar 18, 2021 8:54 am

php_bb wrote: ↑Thu Mar 18, 2021 8:07 am
Dark❶ wrote: ↑Thu Mar 18, 2021 6:22 am What is this ???
Is it a SPAM ???
i couldn't delete the post.

Dark❶ wrote: ↑Thu Mar 18, 2021 6:22 am This, I'll Implement later,
thank you. sometimes first posts get more edits.

Welcome !!!
Ahh!!! in that case, I recommend to use this : [Post Deleted].
Otherwise it looks like a SPAM.

Best regards

php_bb · Post by **php_bb** » Thu Mar 18, 2021 7:29 pm

primehalo wrote: ↑Thu Mar 18, 2021 6:41 am Yep,

Dark❶ wrote: ↑Thu Mar 18, 2021 6:22 am Welcome !!!

i found the issue!

my board has about 1000 forums, that's why it couldn't save the setting into database. [after submitting the changes, it even doesn't show the successful message. it just refreshes the page].
i solved the issue by deleting about half of the forums. now it works perfectly.

do you have any idea how to fix this? most of the boards have more forums.

thank you,

warmweer · Post by **warmweer** » Thu Mar 18, 2021 8:03 pm

php_bb wrote: ↑Thu Mar 18, 2021 7:29 pm ...
my board has about 1000 forums,
...
most of the boards have more forums.

Can you corroborate that?

primehalo · Post by **primehalo** » Fri Mar 19, 2021 5:45 am

php_bb wrote: ↑Thu Mar 18, 2021 7:29 pm my board has about 1000 forums, that's why it couldn't save the setting into database. [after submitting the changes, it even doesn't show the successful message. it just refreshes the page].
i solved the issue by deleting about half of the forums. now it works perfectly.

do you have any idea how to fix this? most of the boards have more forums.

I've never seen a board with that many forums. Currently the extension does one SQL update query per forum. I suppose we could change that so it groups all same settings together to do one query for each. Although 1000 forums might also be too much for that. I suppose we could break those down into groups of 100 or so. Anyway, it might be possible but I really don't have the time to work on it right ow and 1000 forums seems like a pretty rare condition to happen.

3Di · Post by **3Di** » Fri Mar 19, 2021 6:00 am

phpBB can NOT handle more than 1000 forums, even less.

php_bb · Post by **php_bb** » Fri Mar 19, 2021 8:11 am

primehalo wrote: ↑Fri Mar 19, 2021 5:45 am
php_bb wrote: ↑Thu Mar 18, 2021 7:29 pm my board has about 1000 forums, that's why it couldn't save the setting into database. [after submitting the changes, it even doesn't show the successful message. it just refreshes the page].
i solved the issue by deleting about half of the forums. now it works perfectly.

do you have any idea how to fix this? most of the boards have more forums.
I've never seen a board with that many forums. Currently the extension does one SQL update query per forum. I suppose we could change that so it groups all same settings together to do one query for each. Although 1000 forums might also be too much for that. I suppose we could break those down into groups of 100 or so. Anyway, it might be possible but I really don't have the time to work on it right ow and 1000 forums seems like a pretty rare condition to happen.

how can i do this:
check the inputs first, if the input's value is NOT the same as the database value, then update the database.
in this case, it only updates the values that we changed.

Dark❶ · Post by **Dark❶** » Fri Mar 19, 2021 9:53 am

php_bb wrote: ↑Fri Mar 19, 2021 8:11 am ...
how can i do this:
check the inputs first, if the input's value is NOT the same as the database value, then update the database.
in this case, it only updates the values that we changed.

The problem will still remain...

Best regards

primehalo · Post by **primehalo** » Fri Mar 19, 2021 8:22 pm

php_bb wrote: ↑Thu Mar 18, 2021 7:29 pm my board has about 1000 forums, that's why it couldn't save the setting into database. [after submitting the changes, it even doesn't show the successful message. it just refreshes the page].
i solved the issue by deleting about half of the forums. now it works perfectly.

do you have any idea how to fix this? most of the boards have more forums.

Could you test something for us? In ext/primehalo/primepostrevisions/acp/main_module.php find and remove the lines $db->sql_transaction('begin'); and $db->sql_transaction('commit'); then see if it works.

php_bb · Post by **php_bb** » Fri Mar 19, 2021 8:50 pm

3Di wrote: ↑Fri Mar 19, 2021 6:00 am phpBB can NOT handle more than 1000 forums, even less.

my board with 1000 forums work perfectly with no issues.

php_bb · Post by **php_bb** » Fri Mar 19, 2021 9:03 pm

primehalo wrote: ↑Fri Mar 19, 2021 8:22 pm Could you test something for us? In ext/primehalo/primepostrevisions/acp/main_module.php find and remove the lines $db->sql_transaction('begin'); and $db->sql_transaction('commit'); then see if it works.

i tested, no change.

Onnozel Manneke · Post by **Onnozel Manneke** » Wed Mar 24, 2021 12:53 am

I get

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 351: Undefined variable: s_hidden_fields

On /revisions/view/***

phpBB 3.3.3
PHP 7.4.19

primehalo · Post by **primehalo** » Wed Mar 24, 2021 4:59 pm

Thanks, we'll get it fixed. You can just comment out that line if you want as I don't think it's needed anymore.

Onnozel Manneke · Post by **Onnozel Manneke** » Wed Mar 24, 2021 6:59 pm

primehalo wrote: ↑Wed Mar 24, 2021 4:59 pm Thanks, we'll get it fixed. You can just comment out that line if you want as I don't think it's needed anymore.

In the RC 4 version there are 2 errors on that page

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 280: Undefined index: primepost_edit_count
[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 352: Undefined variable: s_hidden_fields

Dark❶ · Post by **Dark❶** » Thu Mar 25, 2021 7:27 am

Onnozel Manneke wrote: ↑Wed Mar 24, 2021 6:59 pm
primehalo wrote: ↑Wed Mar 24, 2021 4:59 pm Thanks, we'll get it fixed. You can just comment out that line if you want as I don't think it's needed anymore.
In the RC 4 version there are 2 errors on that page
Code: Select all
[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 280: Undefined index: primepost_edit_count
[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 352: Undefined variable: s_hidden_fields

The line:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 352: Undefined variable: s_hidden_fields

is fine,
But the line:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/primehalo/primepostrevisions/controller/controller.php on line 280: Undefined index: primepost_edit_count

is some rare case scenario,
I'll do something about it...

Best regards