Page 2 of 2

Re: [3.2][BETA] Prime Post Revisions

Posted: Thu Jun 07, 2018 9:29 am
by Happykeppi
Thanks for the extension, which works very well at this state. I only had a minor issue with the post revision body while using prosilver based theme 'milk'. The span labels following the icons overlayed each other and screwed up the design and layout. Not sure if it's a general problem or just related to my current style. It originally looked like this:

Image

I deleted the following parts as I believe it would be sufficient to have a caption via mouse over anyway.

body.html
Line 81: '<span>{L_PRIMEPOSTREVISIONS_RESTORE}</span>'
Line 86: '<span>{L_PRIMEPOSTREVISIONS_DELETE}</span>'


overall_footer_body_after.html
Line: 14 '<span>{L_PRIMEPOSTREVISIONS_COMPARE}</span>'

I have also updated the German translations, which still had some labes not translated or mixed up (like 'PRIMEPOSTREVISIONS_INFO' and 'PRIMEPOSTREVISIONS_EDIT_BY' in the "de" version).

Git Hub:
https://github.com/happykeppi/primepostrevisions

Re: [3.2][BETA] Prime Post Revisions

Posted: Thu Jun 07, 2018 4:31 pm
by leschek
primehalo wrote:
Wed Jun 06, 2018 7:45 pm
That bug got introduced in my last update when I forgot to set the auto-increment. I've released v1.0.0 beta 4 which fixes it.
Thank you for great support.

Re: [3.2][BETA] Prime Post Revisions

Posted: Thu Jun 07, 2018 7:56 pm
by primehalo
Happykeppi wrote:
Thu Jun 07, 2018 9:29 am
Thanks for the extension, which works very well at this state. I only had a minor issue with the post revision body while using prosilver based theme 'milk'. The span labels following the icons overlayed each other and screwed up the design and layout. Not sure if it's a general problem or just related to my current style. It originally looked like this:

Image

I deleted the following parts as I believe it would be sufficient to have a caption via mouse over anyway.

body.html
Line 81: '<span>{L_PRIMEPOSTREVISIONS_RESTORE}</span>'
Line 86: '<span>{L_PRIMEPOSTREVISIONS_DELETE}</span>'


overall_footer_body_after.html
Line: 14 '<span>{L_PRIMEPOSTREVISIONS_COMPARE}</span>'

I have also updated the German translations, which still had some labes not translated or mixed up (like 'PRIMEPOSTREVISIONS_INFO' and 'PRIMEPOSTREVISIONS_EDIT_BY' in the "de" version).

Git Hub:
https://github.com/happykeppi/primepostrevisions

The icons issue was because I failed to add the sr-only class to the SPAN tags. I fixed this in v1.0.0 beta5 and merged your German language files.

Re: [3.2][BETA] Prime Post Revisions

Posted: Sat Jun 09, 2018 2:40 pm
by Happykeppi
Alright, thank you! :P

Re: [3.2][BETA] Prime Post Revisions

Posted: Sun Oct 14, 2018 11:07 pm
by Tarantino
If I had the old MOD installed and now at 3.2 I install this ext will it use all the data from the old mod? Is it retro-compatible?

Re: [3.2][BETA] Prime Post Revisions

Posted: Sun Oct 14, 2018 11:09 pm
by primehalo
Unfortunately, no, and I never got around to writing a conversion script.

Re: [3.2][BETA] Prime Post Revisions

Posted: Sun Oct 14, 2018 11:12 pm
by Tarantino
I see. I hope its in the plans at least :P Thanks for the quick reply!

Re: [3.2][BETA] Prime Post Revisions

Posted: Sun Oct 14, 2018 11:27 pm
by primehalo
Unfortunately, that's also a nope. I had no need for it personally and phpBB 3.0 is so old I figured it wasn't worth the time.

Re: [3.2][BETA] Prime Post Revisions

Posted: Tue Oct 30, 2018 1:17 pm
by SuperFedya
Enable/Delete this mod on phpbb 3.2.3 make mysql on server extremely slow and require a reboot...

Re: [3.2][BETA] Prime Post Revisions

Posted: Wed Oct 31, 2018 12:17 am
by primehalo
SuperFedya wrote:
Tue Oct 30, 2018 1:17 pm
Enable/Delete this mod on phpbb 3.2.3 make mysql on server extremely slow and require a reboot...
I did not experience this.

Re: [3.2][BETA] Prime Post Revisions

Posted: Fri Jan 11, 2019 4:36 am
by SuperFedya
primehalo wrote:
Wed Oct 31, 2018 12:17 am
SuperFedya wrote:
Tue Oct 30, 2018 1:17 pm
Enable/Delete this mod on phpbb 3.2.3 make mysql on server extremely slow and require a reboot...
I did not experience this.
For my server enabling or delete this module consume 100% cpu.

Any way to enable it via CURL? Or CLI?

Or how to remove this module manually?

Re: [3.2][BETA] Prime Post Revisions

Posted: Fri Jan 11, 2019 7:16 am
by primehalo
I have no idea why this extension would cause 100 CPU usage on your server. To remove it manually have you tried just renaming the folder to something else? If that works then you should be able to just delete the folder.

Re: [3.2][BETA] Prime Post Revisions

Posted: Fri Jan 11, 2019 7:38 am
by david63
primehalo wrote:
Fri Jan 11, 2019 7:16 am
To remove it manually have you tried just renaming the folder to something else?
That will never work and will, in fact, cause other errors.
SuperFedya wrote:
Fri Jan 11, 2019 4:36 am
Any way to enable it via CURL? Or CLI?

Or how to remove this module manually?
See - Knowledge Base - Disabling all extensions at once