[3.2][3.3][RC] Prime Post Revisions

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
primehalo
Former Team Member
Posts: 2893
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by primehalo »

One of your suggestions was to move all the HTML files from styles/prosilver to styles/all. When originally setting this up, I actually wasn't sure if I should place them in prosilver or all. I chose prosilver because they are made and pretty much dependent on a prosilver-based style.

But I'm not 100% sure how this whole system works with other styles. If the HTML files are in prosilver like they are now and someone installs a prosilver-based style, will it automatically look in this prosilver directory for the files or is the user required to copy the files to the new style?
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Dark❶
Registered User
Posts: 224
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by Dark❶ »

primehalo wrote:
Tue Apr 14, 2020 1:59 am
One of your suggestions was to move all the HTML files from styles/prosilver to styles/all. When originally setting this up, I actually wasn't sure if I should place them in prosilver or all. I chose prosilver because they are made and pretty much dependent on a prosilver-based style.

But I'm not 100% sure how this whole system works with other styles. If the HTML files are in prosilver like they are now and someone installs a prosilver-based style, will it automatically look in this prosilver directory for the files or is the user required to copy the files to the new style?
There are two types of styles in phpBB :
1. Parent Style : a independent style not depending on any external style assets.
2. Child Style : a dependent style which does "template inheritance" from Parent Style for any external style assets.
For More Info read this : https://www.phpbb.com/styles/installing/ && https://www.phpbb.com/styles/create/

Now , not all prosilver-based style use parent as prosilver,
some of them are independent too,
but they update their styles based on prosilver for maximum compatibility with various Extensions.

so those styles will get error for your controller,
coz the phpBB could not find the controller template file in it's style dir styles/{some_style} or in Universal style dir styles/all.

So to answer your question , Yes! user is required to copy the files to the new style.

---

I have made new PR : https://github.com/primehalo/primepostrevisions/pull/9
In this I have moved all the HTML files from styles/prosilver to styles/all.
Along with that , I have made it so to compare 2 BBcode Text of a Post, instead of 2 HTML entities.
Also added the ability to compare the Post Subject.

---

Best regards :+1:
Dark❶ [dark1]
User avatar
Jorup16
Registered User
Posts: 424
Joined: Sun Dec 14, 2008 5:13 am
Location: Zacapa, Guatemala
Name: Jorge
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by Jorup16 »

Very good extension, congratulations.

I remember that I had this MOD in my previous version of the forum, it always worked excellent.
Spanish Translations for Ext phpBB :D - Traducciones al español para Ext phpBB :)
>>>>> https://github.com/Jorup16 <<<<<
User avatar
Dark❶
Registered User
Posts: 224
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by Dark❶ »

Yes ! this is the best post revision tracking extension.

I especially like the Difference of 2 revision shown via JS , that is beautiful, I love it.

---

@primehalo ,
I had some questions regarding the code from controller for my next PR.
Are you there on Discord or Telegram ???
Can you PM me the discord or telegram public ID to contact you.
If you want I'll share mine via PM.

Best regards :+1:
Dark❶ [dark1]
User avatar
primehalo
Former Team Member
Posts: 2893
Joined: Fri May 06, 2005 5:58 pm
Location: Redding, CA
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by primehalo »

I'm on Discord, usually chatting in my Absolute Anime server when I'm available:
https://discord.gg/VYgbqSD
Last edited by primehalo on Thu Apr 16, 2020 7:44 pm, edited 1 time in total.
Ken F. Innes IV
My Extensions | My MODs | My Topics | My Site: Absolute Anime
Experience the wonder of Japanese Animation!
User avatar
Dark❶
Registered User
Posts: 224
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

Re: [3.2][BETA] Prime Post Revisions

Post by Dark❶ »

as asked in discord , I have done changes in this two PR's :
1. https://github.com/primehalo/primepostrevisions/pull/10
2. https://github.com/primehalo/primepostrevisions/pull/11

Any feedback would be nice...

Best regards :+1:
Dark❶ [dark1]
User avatar
Dark❶
Registered User
Posts: 224
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

Re: [3.2][3.3][RC] Prime Post Revisions

Post by Dark❶ »

Update : Prime Post Revisions v1.0.0-RC1
  • [1.0.0 RC1] - 2020-04-26
    • Added
      • Profile caching
      • Ability to not save post history when editing a post (only for those with the permissions to delete the post history)
    • Changed
      • SQL JOIN to SQL LEFT JOIN
    • Fixed
      • Newline indicators failed to show properly on some Linux systems
    • Removed
      • Unnecessary profile information displayed next to post revisions
  • [1.0.0 RC] - 2020-04-24
    • Added
      • Added the ability to compare non-sequential revisions
    • Changed
      • Fixed up code to be CDB (phpBB Customization Database) compliant
      • Reformatted ACP directory list to show categories and tree structure
      • Minor styling changes
    • Fixed
      • Unintentional dupicate HTML element IDs
.

Kindly check the OP to download the Update.

Best regards :+1:
Dark❶ [dark1]
Post Reply

Return to “Extensions in Development”