[3.2][BETA] Show Topic Starter

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

[3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 5:37 am

In response to this request.

Extension Name: Show Topic Starter
Author: martti
Extension Description:

This extension shows the string "Topic Starter" underneath the avatar in all posts of the topic starter (OP).

The original idea is from the MOD Topic Starter. Implemented as phpBB 3.2 extension.

Extension Version: 0.1.0
Requirements: phpBB 3.2 PHP 7+
Extension Download: https://github.com/marttiphpbb/phpbb-ex ... master.zip The files are to be put into ext/marttiphpbb/showtopicstarter
Github repository: https://github.com/marttiphpbb/phpbb-ex ... picstarter
Languages: en
Templates: Prosilver
Screenshot:

Image
Last edited by martti on Thu May 03, 2018 9:01 am, edited 1 time in total.

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by 3Di » Thu May 03, 2018 5:44 am

Seems like you forgot to add the css file in the repo?

https://github.com/marttiphpbb/phpbb-ex ... rter&type=
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 5:48 am

3Di wrote:
Thu May 03, 2018 5:44 am
Seems like you forgot to add the css file in the repo?

https://github.com/marttiphpbb/phpbb-ex ... rter&type=
For me it looks ok as it is. The class is just there as selector for whoever wants to style it.

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by 3Di » Thu May 03, 2018 5:52 am

Mah, unused code that's it. :)
I'd add a fake class in the CSS in this case open to be modified. Else remove that unused selector, that's me.

Why PHP >= 7 in this case btw?
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 6:02 am

3Di wrote:
Thu May 03, 2018 5:52 am
Why PHP >= 7 in this case btw?
I don't want to look at PHP 5 anymore.

User avatar
david63
Jr. Extension Validator
Posts: 15062
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by david63 » Thu May 03, 2018 6:05 am

David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by 3Di » Thu May 03, 2018 6:10 am

david63 wrote:
Thu May 03, 2018 6:05 am
How does this differ from - https://www.phpbb.com/customise/db/exte ... ic_author/
The latter uses a different template event and inline style, and it works on 3.1.x /PHP 5 as well. ;)

viewtopic_body_avatar_after (since 3.1.0-RC3 ) against the present viewtopic_body_post_author_before (since 3.1.3-rc1)
Last edited by 3Di on Thu May 03, 2018 6:12 am, edited 1 time in total.
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
david63
Jr. Extension Validator
Posts: 15062
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by david63 » Thu May 03, 2018 6:11 am

3Di wrote:
Thu May 03, 2018 6:10 am
it works on 3.1.x as well
So does the one in the CDB
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by 3Di » Thu May 03, 2018 6:14 am

david63 wrote:
Thu May 03, 2018 6:11 am
3Di wrote:
Thu May 03, 2018 6:10 am
it works on 3.1.x as well
So does the one in the CDB
Sorry, I edited my above post to reflect what I wanted to say.
The present does not work (due to ext.php) on 3.1
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 7:39 am

david63 wrote:
Thu May 03, 2018 6:05 am
How does this differ from - https://www.phpbb.com/customise/db/exte ... ic_author/
Ok, I didn't know about that one. Also the feature requester didn't see it.

Observed differences:
  • This ext uses another template event. This uses viewtopic_body_post_author_before. The other uses viewtopic_body_avatar_after
  • This ext is only phpBB 3.2 PHP7, the other phpBB 3.1, 3.2 PHP5&7
  • This ext is Bèta, the other CDB
  • This ext is only in Prosilver style (for now, more or "all" might be add. It's not final yet), the other "all"
  • This ext says "Topic Starter", the other "Topic author"
  • This ext is only in English (for now), the other has also Polish and Russian translations.
  • This ext does not do styling itself, but provides a selector class marttiphpbb-showtopicstarter (it's so verbose to easily recognise the origin.) The other one does inline styling to turn the text-color red. <strong style="color: #FF0000;">{L_TOPIC_AUTHOR}</strong>
  • The other extension adds a <br/> (line break) before the string. This extension does not do that.
  • This extension places the string in it's own <div> after <div class="avatar-container">...</div>. The other extension is inside <div class="avatar-container"> ... </div>, but closes it with </div> and then opens it's own <div> and uses then the closing </div> of the avatar-container. It might be cause of conflict if another extension uses the same template event expecting to be inside <div class="avatar-container">...</div>.
  • This extension sends less data over the wire (even with the long classname) than the other. The other extension injects this html comment in every post:

    Code: Select all

    <!--
    *
    * @package Topic Author
    * @author dmzx (www.dmzx-web.net)
    * @copyright (c) 2014 by dmzx (www.dmzx-web.net)
    * @license http://opensource.org/licenses/gpl-license.php GNU Public License
    * 
    -->
Both extensions enabled:

Image
Last edited by martti on Thu May 03, 2018 11:24 am, edited 1 time in total.

User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 11:21 am

martti wrote:
Thu May 03, 2018 7:39 am
Sorry, I just wanted to do a minor edit, but hit the "reply button" by mistake.

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by remoss » Thu May 03, 2018 3:40 pm

martti wrote:
Thu May 03, 2018 7:39 am
  • This ext says "Topic Starter", the other "Topic author"
In the Topic Author extension you can adjust the text in ACP, also the color of the background

Image
Image

User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 4:20 pm

remoss wrote:
Thu May 03, 2018 3:40 pm
That must be still another extension. Do you have a link to it?

User avatar
remoss
Registered User
Posts: 95
Joined: Wed Jul 08, 2015 2:12 pm
Location: The Netherlands
Name: René
Contact:

Re: [3.2][BETA] Show Topic Starter

Post by remoss » Thu May 03, 2018 4:23 pm


User avatar
martti
Registered User
Posts: 684
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Show Topic Starter

Post by martti » Thu May 03, 2018 4:34 pm

remoss wrote:
Thu May 03, 2018 4:23 pm
It's really this one: https://www.phpbb.com/customise/db/exte ... ic_author/
I see. it's a newer version, 1.0.4 instead of 1.0.2 in the CDB.

Link to the repo in Github: https://github.com/dmzx/Topic-Author

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: aedgington, Majestic-12 [Bot], Restless Rancor and 24 guests