martti wrote: ↑Thu May 03, 2018 7:39 am
Ok, I didn't know about that one. Also the feature requester didn't see it. ...
I did find
Topic Author, but I did not understand the description:
phpBB extension that will add Topic Author to viewtopic.
If the description was stated differently, for example "Adds "Topic Author" to the post of the member who started the topic.", I would have used the extension. Also, "Topic Author"
implies starting a topic. "Topic Starter" states the purpose directly.
martti wrote: ↑Thu May 03, 2018 7:39 am
Observed differences:
- This ext uses another template event. This uses
viewtopic_body_post_author_before
. The other uses viewtopic_body_avatar_after
- This ext is only phpBB 3.2 PHP7, the other phpBB 3.1, 3.2 PHP5&7
- This ext is Bèta, the other CDB
- This ext is only in Prosilver style (for now, more or "all" might be add. It's not final yet), the other "all"
- This ext says "Topic Starter", the other "Topic author"
- This ext is only in English (for now), the other has also Polish and Russian translations.
- This ext does not do styling itself, but provides a selector class
marttiphpbb-showtopicstarter
(it's so verbose to easily recognise the origin.) The other one does inline styling to turn the text-color red. <strong style="color: #FF0000;">{L_TOPIC_AUTHOR}</strong>
- The other extension adds a
<br/>
(line break) before the string. This extension does not do that.
- This extension places the string in it's own
<div>
after <div class="avatar-container">...</div>
. The other extension is inside <div class="avatar-container"> ... </div>
, but closes it with </div>
and then opens it's own <div>
and uses then the closing </div>
of the avatar-container. It might be cause of conflict if another extension uses the same template event expecting to be inside <div class="avatar-container">...</div>
.
- This extension sends less data over the wire (even with the long classname) than the other. The other extension injects this html comment in every post:
Code: Select all
<!--
*
* @package Topic Author
* @author dmzx (www.dmzx-web.net)
* @copyright (c) 2014 by dmzx (www.dmzx-web.net)
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
-->
...
I have installed the extension on my localhost test environment. I have phpBB 3.2.2, PHP 7.1, and the Prosilver style. My board is English with the American English language pack.
I have tested the extension with desktop and mobile (responsive mode), with an avatar and without an avatar. It works perfectly.
Do I need to add
language/en_us/common.php
to the extension?
By using the existing Prosilver CSS, there is no problem of compatibility with the existing style.
I like the implementation to place the string in its own
<div>
and to not insert an extra
<br />
.
A suggestion: Package the .zip file to extract directly into
ext/marttiphpbb/showtopicstarter
. So, copy the .zip file to
ext/
and then extract to create
marttiphpbb/showtopicstarter
.
Can this extension be validated?