[3.2][BETA] Extra Style

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
martti
Registered User
Posts: 758
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

[3.2][BETA] Extra Style

Post by martti » Mon May 28, 2018 8:45 pm

Extension Name: Extra Style
Author: martti
Extension Description: With this extension you can write extra style sheets in the ACP. The HTTP header for browser cache is set to maximum, 1 year.
Extension Version: 0.1.2
Requirements: Extension Download: https://github.com/marttiphpbb/phpbb-ex ... master.zip The files are to be put in ext/marttiphpbb/extrastyle
Github repository: https://github.com/marttiphpbb/phpbb-ext-extrastyle
Languages: en
Templates: all
Screenshots:

ACP Sheets

Image

ACP Edit

We are styling here the content of the Show Topic Starter extension which doesn't provide styling of its own.

Image

Result

(Content by the Show Topic Starter extension)

Image
Last edited by martti on Fri Sep 28, 2018 7:07 am, edited 2 times in total.

nou nou
Registered User
Posts: 372
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.2][BETA] Extra Style

Post by nou nou » Mon May 28, 2018 9:27 pm

Ooooh! This looks very interesting!

elawrenc
Registered User
Posts: 122
Joined: Thu Jul 21, 2011 2:41 pm

Re: [3.2][BETA] Extra Style

Post by elawrenc » Tue Jul 10, 2018 5:53 pm

I just added this to try it out. Works great so far!

User avatar
martti
Registered User
Posts: 758
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Extra Style

Post by martti » Mon Jul 16, 2018 5:05 am

elawrenc wrote:
Tue Jul 10, 2018 5:53 pm
I just added this to try it out. Works great so far!
Good to hear!

User avatar
John connor
Registered User
Posts: 2240
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [3.2][BETA] Extra Style

Post by John connor » Thu Sep 13, 2018 6:18 am

Nice! I shall try this with Topic Starter.

Lady_G
Registered User
Posts: 234
Joined: Fri Jun 08, 2012 12:38 pm
Location: US

Re: [3.2][BETA] Extra Style

Post by Lady_G » Fri Sep 28, 2018 1:15 am

I have installed this extension together with [3.2][BETA] Show Topic Starter and [3.2][BETA] CodeMirror (helper ext). This is a new install.

I have created a new sheet exactly as your example. When I save the sheet, I see a PHP Notice:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
The extension Show Topic Starter is working when I view my topics.

My test environment: localhost
OS: Linux
Database: PostgreSQL 10.5 on x86_64-redhat-linux-gnu
phpBB version: 3.2.3
PHP: 7.1.17

I have also reported a problem with [3.2][BETA] CodeMirror (helper ext). I don't know if these problems are related.

=========
The install instructions state that the CodeMirror extension is a requirement. Can I use Extra Style without CodeMirror?

Update: Fixed links to Show Topic Starter and CodeMirror.
Last edited by Lady_G on Fri Sep 28, 2018 9:10 pm, edited 1 time in total.

User avatar
martti
Registered User
Posts: 758
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Extra Style

Post by martti » Fri Sep 28, 2018 7:12 am

Lady_G wrote:
Fri Sep 28, 2018 1:15 am

I have created a new sheet exactly as your example. When I save the sheet, I see a PHP Notice:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
Thanks for reporting. I fixed this notice in a new version 0.1.2
Lady_G wrote:
Fri Sep 28, 2018 1:15 am
The install instructions state that the CodeMirror extension is a requirement. Can I use Extra Style without CodeMirror?
Yes, but it is not so convenient.

Lady_G
Registered User
Posts: 234
Joined: Fri Jun 08, 2012 12:38 pm
Location: US

Re: [3.2][BETA] Extra Style

Post by Lady_G » Sat Sep 29, 2018 12:50 am

Thank you, the PHP Notice no longer appears. I confirm the fix.
martti wrote:
Fri Sep 28, 2018 7:12 am
Yes, but it is not so convenient.
For a developer, it is very convenient. I will consider keeping this extension.

===================
I have created your example. The extension is working.

Suggestions for your Script names description:
  • I think you missed the period '.' character. From "index Style sheet" to "index. Style sheet"
  • The last sentence can be improved.
From:
A comma separated list of script names (without the .php extension) to define when this style sheet should be loaded. i.e. viewforum, viewtopic, index Style sheet content should as much be grouped together in order to avoid the number of files loaded.
To:
A comma separated list of script names (without the .php extension) to define when this style sheet should be loaded. i.e. viewforum, viewtopic, index. Style sheet content should be grouped together as much as possible in order to reduce the number of files loaded.
========
The "Reset" button has no effect.

(Post updated to clarify suggestions.)

User avatar
martti
Registered User
Posts: 758
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Extra Style

Post by martti » Sun Sep 30, 2018 6:51 am

Lady_G wrote:
Sat Sep 29, 2018 12:50 am
Suggestions for your Script names description:
  • I think you missed the period '.' character. From "index Style sheet" to "index. Style sheet"
  • The last sentence can be improved.
Good points. This is going to be rewritten anyway in the next version. The plan is to support wildcards and negations.
Lady_G wrote:
Sat Sep 29, 2018 12:50 am
The "Reset" button has no effect.
(Same response as in CodeMirror ext) It's working for me. It's to reset unsaved edits. It's like refreshing the page.

Lady_G
Registered User
Posts: 234
Joined: Fri Jun 08, 2012 12:38 pm
Location: US

Re: [3.2][BETA] Extra Style

Post by Lady_G » Sun Sep 30, 2018 4:31 pm

martti wrote:
Sun Sep 30, 2018 6:51 am
Lady_G wrote:
Sat Sep 29, 2018 12:50 am
The "Reset" button has no effect.
(Same response as in CodeMirror ext) It's working for me. It's to reset unsaved edits. It's like refreshing the page.
(Same response as in CodeMirror (helper ext)) I did not understand the intent of 'Reset'. The button is working as you describe. Perhaps the button text could be changed to "Reset changes"?

User avatar
martti
Registered User
Posts: 758
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Extra Style

Post by martti » Sun Sep 30, 2018 4:36 pm

Lady_G wrote:
Sun Sep 30, 2018 4:31 pm

(Same response as in CodeMirror (helper ext)) I did not understand the intent of 'Reset'. The button is working as you describe. Perhaps the button text could be changed to "Reset changes"?
The "Reset" button has the same functionality anywhere else in the ACP. So it's consistent. See for example General > Board Settings.

Lady_G
Registered User
Posts: 234
Joined: Fri Jun 08, 2012 12:38 pm
Location: US

Re: [3.2][BETA] Extra Style

Post by Lady_G » Sun Sep 30, 2018 7:05 pm

Thank you. You are correct. My mistake, as I did not associate that behavior with the other functionality in the ACP.

Post Reply

Return to “Extensions in Development”