[3.3][BETA] Extra Style

[martti]

Extension Name: Extra Style
Author: martti
Extension Description: With this extension you can write extra style sheets in the ACP. The HTTP header for browser cache is set to maximum, 1 year.
Extension Version: 0.3.0
Requirements:

• The CodeMirror helper extension
• phpBB 3.3.0+
• PHP 7.1+

(For phpBB 3.2 use version 0.1.2)
Extension Download: https://github.com/marttiphpbb/phpbb-ex ... master.zip The files are to be put in ext/marttiphpbb/extrastyle
Github repository: https://github.com/marttiphpbb/phpbb-ext-extrastyle
Languages: en
Templates: all
Screenshots:

ACP Sheets



ACP Edit

We are styling here the content of the Show Topic Starter extension which doesn't provide styling of its own.



Result

(Content by the Show Topic Starter extension)

[nou nou]

Ooooh! This looks very interesting!

[elawrenc]

I just added this to try it out. Works great so far!

[martti]

I just added this to try it out. Works great so far!

Good to hear!

[2600]

Nice! I shall try this with Topic Starter.

[Lady_G]

I have installed this extension together with [3.2][BETA] Show Topic Starter and [3.2][BETA] CodeMirror (helper ext). This is a new install.

I have created a new sheet exactly as your example. When I save the sheet, I see a PHP Notice:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file

The extension Show Topic Starter is working when I view my topics.

My test environment: localhost
OS: Linux
Database: PostgreSQL 10.5 on x86_64-redhat-linux-gnu
phpBB version: 3.2.3
PHP: 7.1.17

I have also reported a problem with [3.2][BETA] CodeMirror (helper ext). I don't know if these problems are related.

=========
The install instructions state that the CodeMirror extension is a requirement. Can I use Extra Style without CodeMirror?

Update: Fixed links to Show Topic Starter and CodeMirror.

[martti]

I have created a new sheet exactly as your example. When I save the sheet, I see a PHP Notice:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file
[phpBB Debug] PHP Notice: in file [ROOT]/ext/marttiphpbb/extrastyle/acp/main_module.php on line 72: Undefined variable: file

Thanks for reporting. I fixed this notice in a new version 0.1.2

The install instructions state that the CodeMirror extension is a requirement. Can I use Extra Style without CodeMirror?

Yes, but it is not so convenient.

[Lady_G]

Thank you, the PHP Notice no longer appears. I confirm the fix.

Yes, but it is not so convenient.

For a developer, it is very convenient. I will consider keeping this extension.

===================
I have created your example. The extension is working.

Suggestions for your Script names description:

• I think you missed the period '.' character. From "index Style sheet" to "index. Style sheet"
• The last sentence can be improved.

From:

A comma separated list of script names (without the .php extension) to define when this style sheet should be loaded. i.e. viewforum, viewtopic, index Style sheet content should as much be grouped together in order to avoid the number of files loaded.

To:

A comma separated list of script names (without the .php extension) to define when this style sheet should be loaded. i.e. viewforum, viewtopic, index. Style sheet content should be grouped together as much as possible in order to reduce the number of files loaded.

========
The "Reset" button has no effect.

(Post updated to clarify suggestions.)

[martti]

Suggestions for your Script names description:

• I think you missed the period '.' character. From "index Style sheet" to "index. Style sheet"
• The last sentence can be improved.

Good points. This is going to be rewritten anyway in the next version. The plan is to support wildcards and negations.

The "Reset" button has no effect.

(Same response as in CodeMirror ext) It's working for me. It's to reset unsaved edits. It's like refreshing the page.

[Lady_G]

The "Reset" button has no effect.

(Same response as in CodeMirror ext) It's working for me. It's to reset unsaved edits. It's like refreshing the page.

(Same response as in CodeMirror (helper ext)) I did not understand the intent of 'Reset'. The button is working as you describe. Perhaps the button text could be changed to "Reset changes"?

[martti]

(Same response as in CodeMirror (helper ext)) I did not understand the intent of 'Reset'. The button is working as you describe. Perhaps the button text could be changed to "Reset changes"?

The "Reset" button has the same functionality anywhere else in the ACP. So it's consistent. See for example General > Board Settings.

[Lady_G]

Thank you. You are correct. My mistake, as I did not associate that behavior with the other functionality in the ACP.

[martti]

Hi, this extension got updated to version 0.2.0 for phpBB 3.3+

New requirements:

• The CodeMirror helper extension
• phpBB 3.3.0+
• PHP 7.1+

[johnd0e]

After installing this extension my board stops to function (localhost is currently unable to handle this request. HTTP ERROR 500).

Even after I delete it (and purge cache) - I'm unable to access ACM / EXTENSIONS tab:

Code: Select all

General Error
Cannot find module ./../includes/acp/\marttiphpbb\extrastyle\acp\main_module.php

[warmweer]

After installing this extension my board stops to function (localhost is currently unable to handle this request. HTTP ERROR 500).

Even after I delete it (and purge cache) - I'm unable to access ACM / EXTENSIONS tab:

Code: Select all

General Error
Cannot find module ./../includes/acp/\marttiphpbb\extrastyle\acp\main_module.php

Which version of the extension
phpBB version? php version?
was the extension uploaded to the correct place?