[3.3][RC] Email Login

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
nudels64
Registered User
Posts: 51
Joined: Mon Oct 24, 2016 9:17 pm
Contact:

Re: [3.3][RC] Email Login

Post by nudels64 »

Thank you!
phpbb 3.2.5 # PHP-Version: 7.0 # Themes: Prosilver and Basic

nudels64
Registered User
Posts: 51
Joined: Mon Oct 24, 2016 9:17 pm
Contact:

Re: [3.3][RC] Email Login

Post by nudels64 »

Unfortunately version 2 does not run on php7.0, so we have to stay on php7.0. Can you still adapt the version?
phpbb 3.2.5 # PHP-Version: 7.0 # Themes: Prosilver and Basic

User avatar
martti
Registered User
Posts: 808
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.3][RC] Email Login

Post by martti »

nudels64 wrote:
Sat Feb 08, 2020 2:18 pm
Unfortunately version 2 does not run on php7.0, so we have to stay on php7.0. Can you still adapt the version?
Ok, sorry about that. Well, I don't feel like maintaining extra versions for old versions of PHP but you can easily adapt the code of 0.2.0 (use a good code editor like i.e. Visual Studio Code):

Remove from ext.php this:

Code: Select all

	public function is_enableable()
	{
		$config = $this->container->get('config');
		return phpbb_version_compare($config['version'], '3.2.5', '>=')
			&& version_compare(PHP_VERSION, '7.1', '>=');
	}
And from event/listener.php remove all instances of :void.

That should do the trick. But why not updating to phpBB 3.3.0 and PHP 7.1+?
Last edited by martti on Sat Feb 08, 2020 8:36 pm, edited 1 time in total.

User avatar
ssl
Registered User
Posts: 2
Joined: Sat Feb 08, 2020 2:15 pm
Location: France
Name: Fred
Contact:

Re: [3.3][RC] Email Login

Post by ssl »

This extension is planned for forums in version 3.3.0, therefore with a version of php at 7.2 minimum.
Php 7.0 is incompatible for a version 3.3.0 of phpBB
The best would be to update your forum instead of downgrading this extension

User avatar
Hippie459MN
Registered User
Posts: 945
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [3.3][RC] Email Login

Post by Hippie459MN »

ssl wrote:
Sat Feb 08, 2020 3:21 pm
This extension is planned for forums in version 3.3.0, therefore with a version of php at 7.2 minimum.
Php 7.0 is incompatible for a version 3.3.0 of phpBB
The best would be to update your forum instead of downgrading this extension
Well, good thing I haven't updated phpBB or this extension yet. My server is only up to 7.1

Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 26040
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [3.3][RC] Email Login

Post by Paul »

phpBB3.3 does require php 7.1.3 as minimum version, not php 7.2
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

nudels64
Registered User
Posts: 51
Joined: Mon Oct 24, 2016 9:17 pm
Contact:

Re: [3.3][RC] Email Login

Post by nudels64 »

That should do the trick. But why not updating to phpBB 3.3.0 and PHP 7.1+?
The soccer expansion only runs under 7.0, so we will stay at 7.0 for now.
phpbb 3.2.5 # PHP-Version: 7.0 # Themes: Prosilver and Basic

User avatar
Walther
Registered User
Posts: 281
Joined: Fri Jul 09, 2004 5:21 pm
Location: The Netherlands

Re: [3.3][RC] Email Login

Post by Walther »

nudels64 wrote:
Sat Feb 08, 2020 2:18 pm
Unfortunately version 2 does not run on php7.0, so we have to stay on php7.0. Can you still adapt the version?
If you mean with version 2 the version 0.20.0, then I got it running fine on phpBB 3.2.9 with PHP 7.3.16 :idea:
Finally got this function back, lots of people tried to login with their email address instead of their username and then asked me why they were not able to login. Check the connection-log (extension) and then saw they tried to login with their email address.
Or they forgot their username, they never forget their email address, should be a default option in phpBB to login with email. :|
phpBB 3.2.9 -- PHP 7.3.16 -- CentOs7 vps

Post Reply

Return to “Extensions in Development”