[3.3][BETA] Calendar Mono

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Paul wrote:
Fri Jan 18, 2019 5:24 pm
Composer dependencies are autoloaded and will be included only once.
It might well be. But still I'd like to
  • keep concerns separated
  • avoid code duplication
  • provide flexibility
  • work less
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 26729
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [3.2][BETA] Calendar Mono

Post by Paul »

1. That's kinda why composer exists as dependency Manger.
2. Adding it to composer.json won't add any duplication?
4. You are doing more work now, by creating an extra extension for you, and by requiring the user to install an extra extension.

Your current solution will also probably not make it past validation once you submit it to the cdb.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Paul wrote:
Fri Jan 18, 2019 8:41 pm
Your current solution will also probably not make it past validation once you submit it to the cdb.
Can you point me to the rule? Also note, the requirement for this extension is the PHP calendar fundtions to be enabled. The other extension is just a solution for people that can not get PHP compiled with --enable-calendar on their server.
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Alex Grigoras wrote:
Fri Sep 28, 2018 6:44 am
Good extension !

Try to make an update in the future to show on the first page the events that we created with the calendar:

Something like this: https://imgur.com/dJw66yc
The Calendar Inline View extension provides a local view of 5 to 16 days on the index and/or viewforum, viewtopic and posting pages (configurable).

Image
microbet
Registered User
Posts: 1
Joined: Mon May 20, 2019 2:02 am

Re: [3.2][BETA] Calendar Mono

Post by microbet »

This is my first time installing an extension - and I just installed phpBB..so probably obvious, but

I installed the extension and it showed up in my admin and I enabled it, but I don't see a link for the calendar on my index (by the Quick Links, FAQ). Is there another extension that has to be installed for it to work? I don't see anywhere in the admin console to edit which links appear on that bar.

Also, I'm not totally sure that php is enabled properly, but when I look at the output of phpinfo() I see a heading "calendar" that says "Calendar support" "enabled" and under "additional .ini files parsed" it includes "calendar.ini"
User avatar
tk6904
Translator
Posts: 21
Joined: Tue Feb 28, 2017 1:47 am
Name: Takefumi Tenshima
Contact:

Re: [3.2][BETA] Calendar Mono

Post by tk6904 »

I installed this extension today. I have realized sticky type topics and announcement type topics don't appear in the calendar. Is there a way to appear those?

Sorry, wrong topic.
Takefumi Tenshima
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

tk6904 wrote:
Tue Jul 02, 2019 2:38 pm
I installed this extension today. I have realized sticky type topics and announcement type topics don't appear in the calendar. Is there a way to appear those?

Sorry, wrong topic.
No, this is actually the right topic. Because in this extension the actual fetching of the data is happening. I'll have a look into it.
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

So from line 95 in service/repo.php the topics get limited to POST_NORMAL and POST_STICKY. (So stickies are actually shown)

Code: Select all

		$sql = 'select t.topic_id, t.forum_id, t.topic_title,
			t.' . cnst::COLUMN_START . ' as start_jd, t.' . cnst::COLUMN_END . ' as end_jd
			from ' . $this->topics_table . ' t
			where (t.' . cnst::COLUMN_START . ' <= ' . $end_jd . '
				and t.' . cnst::COLUMN_END . ' >= ' . $start_jd . ')
				and ' . $this->db->sql_in_set('t.forum_id', $forum_ids, false, true) . '
				and ' . $this->content_visibility->get_forums_visibility_sql('topic', $forum_ids, 't.') . '
				and ' . $this->db->sql_in_set('t.topic_type', [POST_NORMAL, POST_STICKY]) . '
			order by t.' . cnst::COLUMN_START;
Probably this line comes from the dark past of the development of the calendar which is based on my own mod from 2009. But I see no reason why ALL topics from a forum can't be shown including announcements and even global topics. So I will remove the line and will update to a new version quickly.
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Update, New version 0.5.0 :
  • All topics from targeted forums get fetched now, including global and announcement topics.
User avatar
tk6904
Translator
Posts: 21
Joined: Tue Feb 28, 2017 1:47 am
Name: Takefumi Tenshima
Contact:

Re: [3.2][BETA] Calendar Mono

Post by tk6904 »

martti wrote:
Tue Jul 02, 2019 4:07 pm
So from line 95 in service/repo.php the topics get limited to POST_NORMAL and POST_STICKY. (So stickies are actually shown)

Code: Select all

		$sql = 'select t.topic_id, t.forum_id, t.topic_title,
			t.' . cnst::COLUMN_START . ' as start_jd, t.' . cnst::COLUMN_END . ' as end_jd
			from ' . $this->topics_table . ' t
			where (t.' . cnst::COLUMN_START . ' <= ' . $end_jd . '
				and t.' . cnst::COLUMN_END . ' >= ' . $start_jd . ')
				and ' . $this->db->sql_in_set('t.forum_id', $forum_ids, false, true) . '
				and ' . $this->content_visibility->get_forums_visibility_sql('topic', $forum_ids, 't.') . '
				and ' . $this->db->sql_in_set('t.topic_type', [POST_NORMAL, POST_STICKY]) . '
			order by t.' . cnst::COLUMN_START;
Probably this line comes from the dark past of the development of the calendar which is based on my own mod from 2009. But I see no reason why ALL topics from a forum can't be shown including announcements and even global topics. So I will remove the line and will update to a new version quickly.
Thank you for the prompt action! I have installed the new version and confirmed that it starts working properly :)
Takefumi Tenshima
Holger
Registered User
Posts: 1814
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][BETA] Calendar Mono

Post by Holger »

Hello Martti, thank you for your hard work, but after the update I get Server Error 500 when trying to enter the calendar.
When going back to the previous version everything works again.
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Holger wrote:
Wed Jul 03, 2019 6:38 am
Hello Martti, thank you for your hard work, but after the update I get Server Error 500 when trying to enter the calendar.
When going back to the previous version everything works again.
What is the error message more specific (line, file)? It could also be the upload didn't happen correct? Very little changed in this version.
Holger
Registered User
Posts: 1814
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][BETA] Calendar Mono

Post by Holger »

I only get a white blank page and Internal Servererror 500.


Aaaaah, after deleting the cache everything is ok!
Sorry!
User avatar
martti
Registered User
Posts: 860
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [3.2][BETA] Calendar Mono

Post by martti »

Holger wrote:
Wed Jul 03, 2019 6:54 am
I only get a white blank page and Internal Servererror 500.


Aaaaah, after deleting the cache everything is ok!
Sorry!
Maybe you didn't follow the procedure?
  • Disabling extension
  • Uploading new version
  • Enabling extension
Because that clears the cache too.
Holger
Registered User
Posts: 1814
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][BETA] Calendar Mono

Post by Holger »

Of course I did not! Stupid me! Now I know!
Post Reply

Return to “Extensions in Development”