[ALPHA] [3.2] PG Social Network

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
SinusVonAlpha
Registered User
Posts: 17
Joined: Sat Nov 10, 2018 1:15 pm

Re: [ALPHA] [3.2] PG Social Network

Post by SinusVonAlpha » Fri Nov 23, 2018 3:05 pm

PGreca wrote:
Fri Nov 23, 2018 10:35 am
The running query is of the old version.
Have you updated the files with the new version and deleted the cache? 🤔
I downloaded and installed the latest version available to on Github. "Latest commit 8 days ago" it says and the files also date to November the 15th. Is there a newer one?
Last edited by SinusVonAlpha on Fri Nov 23, 2018 3:13 pm, edited 1 time in total.

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Fri Nov 23, 2018 5:51 pm

SinusVonAlpha wrote:
Fri Nov 23, 2018 3:05 pm
PGreca wrote:
Fri Nov 23, 2018 10:35 am
The running query is of the old version.
Have you updated the files with the new version and deleted the cache? 🤔
I downloaded and installed the latest version available to on Github. "Latest commit 8 days ago" it says and the files also date to November the 15th. Is there a newer one?
I'm sorry. For some strange reason, it did not commit to the new version.
I committed the commit. Now you can try again.
I apologize again. :?

totallybeautiful
Registered User
Posts: 60
Joined: Tue Mar 13, 2018 4:24 pm

Re: [ALPHA] [3.2] PG Social Network

Post by totallybeautiful » Sat Nov 24, 2018 12:39 am

PGreca wrote:
Fri Nov 23, 2018 10:35 am
Thanks! You can find the files here https://github.com/PGreca/pgsocial/tree ... anguage/en
Ok, I have the translations ready. The question now is, how do I send them to you? 😂

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Sat Nov 24, 2018 4:52 pm

totallybeautiful wrote:
Sat Nov 24, 2018 12:39 am
PGreca wrote:
Fri Nov 23, 2018 10:35 am
Thanks! You can find the files here https://github.com/PGreca/pgsocial/tree ... anguage/en
Ok, I have the translations ready. The question now is, how do I send them to you? 😂
If you want, you can send me the translations by PM, or use codebin, or i don't know ahaha

SinusVonAlpha
Registered User
Posts: 17
Joined: Sat Nov 10, 2018 1:15 pm

Re: [ALPHA] [3.2] PG Social Network

Post by SinusVonAlpha » Sat Nov 24, 2018 8:04 pm

Ah yes, the newest commit is up.

Tried it out, but I think there error message is no different to the previous one:

Code: Select all

SQL ERROR [ mysqli ]

Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'HTO01FLQAYBP_app.ph.photo_id' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by [1055]

SQL

SELECT *, (SELECT photo_file FROM comm__pg_social_photos as cov WHERE cov.user_id = ph.user_id AND ph.gallery_id = cov.gallery_id AND cov.photo_where = '0' ORDER BY cov.photo_time DESC LIMIT 0, 1) as gallery_cover, (SELECT COUNT(*) FROM comm__pg_social_photos as contt WHERE contt.user_id = ph.user_id AND ph.gallery_id = contt.gallery_id AND contt.photo_where = '0' ) as count FROM comm__pg_social_photos as ph WHERE ph.user_id = '246' AND ph.photo_where = '0' GROUP BY ph.gallery_id, ph.photo_where

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 996
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/pgreca/pgsocial/social/social_photo.php
LINE: 98
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/pgreca/pgsocial/event/listener.php
LINE: 292
CALL: pgreca\pgsocial\social\social_photo->getGallery()

FILE: (not given by php)
LINE: (not given by php)
CALL: pgreca\pgsocial\event\listener->memberlist_view_profile()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 184
CALL: call_user_func()

FILE: [ROOT]/vendor/symfony/event-dispatcher/EventDispatcher.php
LINE: 46
CALL: Symfony\Component\EventDispatcher\EventDispatcher->doDispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 62
CALL: Symfony\Component\EventDispatcher\EventDispatcher->dispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 46
CALL: phpbb\event\dispatcher->dispatch()

FILE: [ROOT]/memberlist.php
LINE: 685
CALL: phpbb\event\dispatcher->trigger_event()

Occurs in pretty much the same occasions :/ (Deleted cache and made sure it was the correct version)

EDIT: Maybe it has something to do with me using mysqli instead of mysql? I know mysqli is an improved version of it, but maybe it messes something up?

User avatar
canonknipser
Registered User
Posts: 1954
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by canonknipser » Sat Nov 24, 2018 8:39 pm

its a sql coding error - sql_mode=only_full_group_by is a default setting in newer mysql versions, so sql statements should respect that (and maybe those wrong statement will not work on other database systems). This error needs to be fixed by the extension author.

For your mysqli statement - keep it, because the old php mysql interface is deprecated for nearly a decade and removed from php 7.0
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Tue Nov 27, 2018 5:23 pm

canonknipser wrote:
Sat Nov 24, 2018 8:39 pm
its a sql coding error - sql_mode=only_full_group_by is a default setting in newer mysql versions, so sql statements should respect that (and maybe those wrong statement will not work on other database systems). This error needs to be fixed by the extension author.

For your mysqli statement - keep it, because the old php mysql interface is deprecated for nearly a decade and removed from php 7.0
I know it, but i don't know how to resolve.
I founded many guide but nothing fix this problem.
Maybe i need to do how in this post?

User avatar
canonknipser
Registered User
Posts: 1954
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by canonknipser » Tue Nov 27, 2018 6:03 pm

The error message is pretty clear:
Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'HTO01FLQAYBP_app.ph.photo_id' which is not functionally dependent on columns in GROUP BY clause;
I formatted your sql code from the message to make it a bit clearer

Code: Select all

SELECT 
*, 
(SELECT photo_file FROM comm__pg_social_photos as cov WHERE cov.user_id = ph.user_id AND ph.gallery_id = cov.gallery_id AND cov.photo_where = '0' ORDER BY cov.photo_time DESC LIMIT 0, 1) as gallery_cover, 
(SELECT COUNT(*) FROM comm__pg_social_photos as contt WHERE contt.user_id = ph.user_id AND ph.gallery_id = contt.gallery_id AND contt.photo_where = '0' ) as count 
FROM comm__pg_social_photos as ph 
WHERE ph.user_id = '246' AND ph.photo_where = '0' 
GROUP BY ph.gallery_id, ph.photo_where 
Expression #1 of SELECT list (second line) is just * for all columns in the table pg_social_photos, but you are only allowed to used columns listed in the GROUP BY (last line) statement which are ph.gallery_id and ph.photo_where in the statement or aggregated values (which are columns in function like count, sum, min, max etc.).
But none of the columns returned by * are aggregated:
so list them by name and leave out those you don't need for your result, those you need must be part of your GROUP BY clause or aggregated, eg. ph.gallery_id, ph.photo_where, count(ph.column1) ...
For the inner SELECTs, you will get same error messages, because both SELECTs give you no aggregated value also.

I would recommend to rewrite (simplify) the sql statement.
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Wed Nov 28, 2018 9:50 am

I followed your suggestion and removed the coloums *.
Now the query is as

Code: Select all

SELECT ph.gallery_id, (
SELECT photo_file FROM phpbb_pg_social_photos AS cov WHERE cov.user_id = ph.user_id AND ph.gallery_id = cov.gallery_id AND cov.photo_where =  '0' ORDER BY cov.photo_time DESC LIMIT 0, 1) AS gallery_cover, (
SELECT COUNT(*)  FROM phpbb_pg_social_photos AS contt WHERE contt.user_id = ph.user_id AND ph.gallery_id = contt.gallery_id AND contt.photo_where = '0') AS count
FROM phpbb_pg_social_photos AS ph
WHERE ph.user_id = '2' 
AND ph.photo_where =  '0' 
GROUP BY gallery_id, gallery_cover, count
I hope to have solved this bug finally xD
Thanks @totallybeautiful for german translation!

SinusVonAlpha
Registered User
Posts: 17
Joined: Sat Nov 10, 2018 1:15 pm

Re: [ALPHA] [3.2] PG Social Network

Post by SinusVonAlpha » Thu Nov 29, 2018 5:47 pm

Worked! Thanks a thousand times for all your effort :)

totallybeautiful
Registered User
Posts: 60
Joined: Tue Mar 13, 2018 4:24 pm

Re: [ALPHA] [3.2] PG Social Network

Post by totallybeautiful » Fri Nov 30, 2018 2:36 pm

1. sidebars don't work.

2. the chat does not work. No text arrives at the receiver and the opened chat cannot be clicked away and flies around somewhere in the screen.

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Fri Nov 30, 2018 8:07 pm

SinusVonAlpha wrote:
Thu Nov 29, 2018 5:47 pm
Worked! Thanks a thousand times for all your effort :)
Finally! Thank you for testing the ext! :D

totallybeautiful wrote:
Fri Nov 30, 2018 2:36 pm
1. sidebars don't work.

2. the chat does not work. No text arrives at the receiver and the opened chat cannot be clicked away and flies around somewhere in the screen.
1) have you enable from acp?
2) can you take a screenshot of the chat?

totallybeautiful
Registered User
Posts: 60
Joined: Tue Mar 13, 2018 4:24 pm

Re: [ALPHA] [3.2] PG Social Network

Post by totallybeautiful » Fri Nov 30, 2018 9:59 pm

PGreca wrote:
Fri Nov 30, 2018 8:07 pm
1) have you enable from acp?
Yes, I does.
PGreca wrote:
Fri Nov 30, 2018 8:07 pm
2) can you take a screenshot of the chat?
2. Oops, sorry.
I'm afraid I didn't.
In any case, the message window of the recipient is somewhere in the middle of the screen and can no longer be clicked away.

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Sun Dec 02, 2018 3:27 pm

totallybeautiful wrote:
Fri Nov 30, 2018 9:59 pm
PGreca wrote:
Fri Nov 30, 2018 8:07 pm
1) have you enable from acp?
Yes, I does.
PGreca wrote:
Fri Nov 30, 2018 8:07 pm
2) can you take a screenshot of the chat?
2. Oops, sorry.
I'm afraid I didn't.
In any case, the message window of the recipient is somewhere in the middle of the screen and can no longer be clicked away.
Fixed this bug's conflict with your template.

--------


Vers. 0.1.0-d1
ADDED - integration for any type activity
UPDATE - permalink of page
FIXED - vendor name' s notification
FIXED - removed url if activity has a embed element
UPDATE - better code for type activity
UPDATE - style of activity' s form
UPDATE - style of activity' s action

totallybeautiful
Registered User
Posts: 60
Joined: Tue Mar 13, 2018 4:24 pm

Re: [ALPHA] [3.2] PG Social Network

Post by totallybeautiful » Mon Dec 03, 2018 1:43 am

@PGreca

Thank you so much, worked. ;) Nice Job.

Post Reply

Return to “Extensions in Development”