[ALPHA] [3.2] PG Social Network

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
totallybeautiful
Registered User
Posts: 60
Joined: Tue Mar 13, 2018 4:24 pm

Re: [ALPHA] [3.2] PG Social Network

Post by totallybeautiful » Mon Dec 03, 2018 3:04 am

For the mobile use this would have to be adapted, because it is more difficult to handle the chat, because it disappears in the template and still remains stubbornly open when clicking away.

Edit: It doesn't work on the desktop either. It also disappears and cannot be clicked away.

Screenshots will follow via PN, unfortunately you can't upload any here.

User avatar
Lownoise
Registered User
Posts: 101
Joined: Sun Feb 11, 2018 8:44 pm

Re: [ALPHA] [3.2] PG Social Network

Post by Lownoise » Tue Dec 04, 2018 10:39 am

Page keeps on reloading @ "Page Activity".

Check:

Image

It's the pg_social script that keeps on flipping!

Check:

Image
It's Nice To Be Important, But It's More Important To Be Nice!
Trance Vizion ● (Trance Music Discussion Board). www.trancevizion.nl

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Thu Dec 06, 2018 12:42 am

Lownoise wrote:
Tue Dec 04, 2018 10:39 am
Page keeps on reloading @ "Page Activity".

Check:

Image

It's the pg_social script that keeps on flipping!
I knowed this it and i remove this animation, you can try new version files.
totallybeautiful wrote:
Mon Dec 03, 2018 3:04 am
For the mobile use this would have to be adapted, because it is more difficult to handle the chat, because it disappears in the template and still remains stubbornly open when clicking away.

Edit: It doesn't work on the desktop either. It also disappears and cannot be clicked away.

Screenshots will follow via PN, unfortunately you can't upload any here.
The chat disappears for a conflict caused of your template.
I'm rewriting all code of the chat for optimize it for remove all this conflict and bugs, so you need wait (next version i hope).

-------------------
In this version:
  • FIXED BUGS
  • ADDED BLOCK "PAGES MAY YOU LIKE"

NastyBoy
Registered User
Posts: 119
Joined: Wed May 31, 2017 7:03 pm
Location: Germany
Name: Tim
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by NastyBoy » Sun Dec 09, 2018 3:28 pm

thanks for update that is good. Is it possible that one better identifies the chat so that he opens automatically when logging in and gives a better overview of who is online?

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Mon Dec 10, 2018 9:59 pm

NastyBoy wrote:
Sun Dec 09, 2018 3:28 pm
thanks for update that is good. Is it possible that one better identifies the chat so that he opens automatically when logging in and gives a better overview of who is online?
As i telled in last post i fixed important bugs of the chat.
I' m writing a new version of it so you need to wait for the new features.
Before new year i want release new version.
---
I wanna integrate the message chat with the pm (optional setting from acp) (as old system on facebook), replace the box of people with a sidebar with only avatar, icon for online/offline status and tooltip for username.
For the chat box only little update to the style.
I need suggestion for the mobile style... 😵
-----

Vers. 0.2
ADDED - upload avatar for pages
UPDATE - when you edit a post, it's not publish new activity
FIXED - some errors
FIXED - optimize code

focp
Registered User
Posts: 32
Joined: Mon Feb 15, 2016 10:59 am

Re: [ALPHA] [3.2] PG Social Network

Post by focp » Tue Dec 11, 2018 12:17 pm

i found a few bugs when testing the ext,
(using ver 0.2 from github and phpbb 3.2.4 )

no1/ when adding a post, the ext creates an endless repeating no of posts, and can only be stopped by clicking on the refresh button of the browser,
and displays the following error,

[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/db/driver/mysql.php on line 275: mysql_fetch_assoc(): 231 is not a valid MySQL result resource

but the error log itself is empty.

once the refresh button is clicked on, the post then displays as it should ?

no2/ when adding an image to a post, all goes as it should (but with the same behaviour and cure as for no1)

but when the image is clicked on. it just shows a blank black screen where the image should be ?


no3/ am unable to change the cover picture, i can add the picture ok, but when the "update profile" button is clicked on, nothing happens, and the refresh button has to be clicked on to escape back, at which point the original image is reverted to,
this is the same for both admin or a member.


it does not seem to be a conflict related to any other extension, as it it the same with all extensions disabled,

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Tue Dec 11, 2018 8:00 pm

focp wrote:
Tue Dec 11, 2018 12:17 pm
i found a few bugs when testing the ext,
(using ver 0.2 from github and phpbb 3.2.4 )

no1/ when adding a post, the ext creates an endless repeating no of posts, and can only be stopped by clicking on the refresh button of the browser,
and displays the following error,


[phpBB Debug] PHP Warning: in file [ROOT]/phpbb/db/driver/mysql.php on line 275: mysql_fetch_assoc(): 231 is not a valid MySQL result resource

but the error log itself is empty.

----------

no3/ am unable to change the cover picture, i can add the picture ok, but when the "update profile" button is clicked on, nothing happens, and the refresh button has to be clicked on to escape back, at which point the original image is reverted to,
this is the same for both admin or a member.
Only with this informations i can't do so much. What version of mysql are you using?
(I had a bug with mysql 7, so it' s can possible with other versions.)
Is it possible to have link of your forum to see the schedule?
focp wrote:
Tue Dec 11, 2018 12:17 pm
but when the image is clicked on. it just shows a blank black screen where the image should be ?
I commited a new version files for fix this error, you can upload they

focp
Registered User
Posts: 32
Joined: Mon Feb 15, 2016 10:59 am

Re: [ALPHA] [3.2] PG Social Network

Post by focp » Wed Dec 12, 2018 2:37 pm

hi, i cant give you a link to the forum, as its just my test forum, running on a local server,
which a friend set up using an old computer for me,

its running on php 5.6.37 and mysql 5.0.11 if that helps,

the fix for the images worked fine, and images can be viewed ok now :)
so thanks for your time :)

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1104
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by mrgoldy » Wed Dec 12, 2018 3:37 pm

That's mostlikely because of this line: https://github.com/PGreca/pgsocial/blob ... s.php#L439
LIMIT differs per database.
Try using $this->db->sql_query_limit($sql, 1).

And I am just going to re-state what david already said.
If you wish to submit this extension the the Customisation Database at some point, I would highly suggest to read up on the coding guidelines and start applying them to your code.
No camelCase in PHP, only in javascript. So: function addStatus would become add_status.
Use brackets {}, so lines like if($text != "" || $extra != "") $sql = "INSERT INTO " . would become

Code: Select all

if ($text != '' || $extra != '')
{
    $sql = 'INSERT INTO ' . $this->pg_social_table . ' ' . $this->db->sql_build_array('INSERT', $sql_arr);
    // etc..
}
Note that the table is injected as a service, not just the table prefix.
And the additional space between the table name and the 'build' array function.

Good luck, looks great though!

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Thu Dec 13, 2018 2:02 pm

mrgoldy wrote:
Wed Dec 12, 2018 3:37 pm
That's mostlikely because of this line: https://github.com/PGreca/pgsocial/blob ... s.php#L439
LIMIT differs per database.
Try using $this->db->sql_query_limit($sql, 1).
i have optimized it with $this->db->sql_nextid(); so i can remove a query useless.
mrgoldy wrote:
Wed Dec 12, 2018 3:37 pm
And I am just going to re-state what david already said.
If you wish to submit this extension the the Customisation Database at some point, I would highly suggest to read up on the coding guidelines and start applying them to your code.
No camelCase in PHP, only in javascript. So: function addStatus would become add_status.
Use brackets {}, so lines like if($text != "" || $extra != "") $sql = "INSERT INTO " . would become

Code: Select all

if ($text != '' || $extra != '')
{
    $sql = 'INSERT INTO ' . $this->pg_social_table . ' ' . $this->db->sql_build_array('INSERT', $sql_arr);
    // etc..
}
Note that the table is injected as a service, not just the table prefix.
And the additional space between the table name and the 'build' array function.
I started to replace the camelCase and the backets {} and use the tables's services, so i can remove table_prefix.
Now i need to finish read the coding guidelines :?
mrgoldy wrote:
Wed Dec 12, 2018 3:37 pm
Good luck, looks great though!
Really really thank you and for you suggestions.
focp wrote:
Wed Dec 12, 2018 2:37 pm
hi, i cant give you a link to the forum, as its just my test forum, running on a local server,
which a friend set up using an old computer for me,

its running on php 5.6.37 and mysql 5.0.11 if that helps,

the fix for the images worked fine, and images can be viewed ok now :)
so thanks for your time :)
I have uploaded new files version, so check :3

focp
Registered User
Posts: 32
Joined: Mon Feb 15, 2016 10:59 am

Re: [ALPHA] [3.2] PG Social Network

Post by focp » Fri Dec 14, 2018 1:22 pm

tried the latest version, but still the same regarding 2/ (post repeating itself) and 3/ (cant change cover image)

NastyBoy
Registered User
Posts: 119
Joined: Wed May 31, 2017 7:03 pm
Location: Germany
Name: Tim
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by NastyBoy » Mon Dec 31, 2018 8:46 pm

PGreca wrote:
Mon Dec 10, 2018 9:59 pm
NastyBoy wrote:
Sun Dec 09, 2018 3:28 pm
thanks for update that is good. Is it possible that one better identifies the chat so that he opens automatically when logging in and gives a better overview of who is online?
As i telled in last post i fixed important bugs of the chat.
I' m writing a new version of it so you need to wait for the new features.
Before new year i want release new version.
---
I wanna integrate the message chat with the pm (optional setting from acp) (as old system on facebook), replace the box of people with a sidebar with only avatar, icon for online/offline status and tooltip for username.
For the chat box only little update to the style.
I need suggestion for the mobile style... 😵
-----

Vers. 0.2
ADDED - upload avatar for pages
UPDATE - when you edit a post, it's not publish new activity
FIXED - some errors
FIXED - optimize code
Iwait to the new Version of the Chat that sounds intresting

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Wed Jan 02, 2019 12:50 am

NastyBoy wrote:
Mon Dec 31, 2018 8:46 pm
Iwait to the new Version of the Chat that sounds intresting
The new version is amost ready. I need to ultimate the mobile version and scrolling chat for oldest messages.
At the moment i dont will integrate the chat with the pm. So much problems to undestand how to do it better.

New version of extension has the possibility to create new album (limit from acp) and upload image (limit too from acp).

I hope to finish it for to 4 jenuary.

----------------

(HAPPY NEW YEAR!! 🎉)

NastyBoy
Registered User
Posts: 119
Joined: Wed May 31, 2017 7:03 pm
Location: Germany
Name: Tim
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by NastyBoy » Wed Jan 02, 2019 3:28 pm

Happy new year and i wait for your new Version

User avatar
PGreca
Registered User
Posts: 36
Joined: Mon Oct 29, 2018 12:36 pm
Location: Italy
Contact:

Re: [ALPHA] [3.2] PG Social Network

Post by PGreca » Fri Jan 04, 2019 4:37 pm

Hello! This version give the new chat and the albums!
The new chat has a sidebar with friends and her status. From bottom panel you can open settings for online status and sound notification for new messages.
From ACP you can limit the albums for user and limit the photos for album.

Vers. 0.4.6
  • ADDED - albums with photos! (limit album and limit photos for album from ACP)
  • ADDED - settings chat (audio and online status) in chat sidebar
  • UPDATE - system status online
  • UPDATE - new chat
  • FIXED - position cover pages
  • FIXED - optimize code
  • FIXED - update info favorite books
  • FIXED - bugs with activities
  • FIXED - some bugs
After this version i will not add new features but i will fix the bugs exist and start apply the coding guidelines.
😁

Post Reply

Return to “Extensions in Development”