Page 3 of 3

Re: [3.2][BETA] Topic Cement Style

Posted: Tue Mar 05, 2019 8:49 pm
by 3Di
shortmort37 wrote:
Tue Mar 05, 2019 11:56 am
I'm unclear on exactly what this means. Should I declare something like this, instead?

'topic_priority' => array('INT:11', 0),

Where does -2,147,483,648 come from, anyway? I know that the least negative number that can be represented in 16 bits (base 2) is -32,768. The least negative number for 11 digits in base 10 would be -99,999,999,999 - no?
1 - Yes.
2 - http://www.mysqltutorial.org/mysql-int/ / https://wiki.phpbb.com/Database_Type_Map#Numeric

Re: [3.2][BETA] Topic Cement Style

Posted: Tue Mar 05, 2019 9:51 pm
by shortmort37
Ah; the largest range that can be specified in 32 bits. BTW, that range is incorrect; it should be -2,147,483,648 to 2,147,483,647.

Re: [3.2][BETA] Topic Cement Style

Posted: Tue Mar 05, 2019 10:17 pm
by 3Di
shortmort37 wrote:
Tue Mar 05, 2019 9:51 pm
Ah; the largest range that can be specified in 32 bits.
No, INT has a storage 4 bytes, that's all.
shortmort37 wrote:
Tue Mar 05, 2019 9:51 pm
BTW, that range is incorrect; it should be -2,147,483,648 to 2,147,483,647.
Feel free to correct the Wiki, you can. :)

On a side note, such change should be done within a new migration which depends on the parent, not on an installed extension for sure.
Btw, there could be someone who assigned a priority of ie.: 4294967295 and downgrading the capacity could lead to issues.
Moreover, there is not a minimum/maximum input's error handling in the HTMl anymore, another issue.

Again, I am discouraging the readers to apply such change if not approved (and therefore deeply tested) by us.

Glad to evaluate suggestions/ideas/PRs for this project if done here: https://github.com/phpBB-Studio/TopicCe ... new/choose

Re: [3.2][BETA] Topic Cement Style

Posted: Tue May 21, 2019 8:11 pm
by 3Di
v1.1.1-beta released - see first post.

This version fixes a couple of issues and needs phpBB 3.2.7 to be installed.

For all those who have already downloaded the extension, the update is simple:

1 - disable and DELETE DATA
2 - delete folder
3 - upload new folder
4 - enable
5 - purge cache

:geek: