[CDB] Mass Notification

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Midway
Registered User
Posts: 22
Joined: Tue Dec 09, 2014 8:02 pm

Re: [3.2][RC] Mass Notification

Post by Midway » Sat Jan 26, 2019 11:04 am

Hi,

I have this error when I want install the extension

Code: Select all

Fatal error: Cannot declare class senky\massnotification\migrations\m1_acp_module, because the name is already in use in C:\UwAmp\www\ext\senky\massnotification\migrations\m2_id_incrementer.php on line 31

Midway
Registered User
Posts: 22
Joined: Tue Dec 09, 2014 8:02 pm

Re: [3.2][RC] Mass Notification

Post by Midway » Thu Feb 21, 2019 2:23 pm

:roll:

User avatar
Hippie459MN
Registered User
Posts: 918
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [3.2][RC] Mass Notification

Post by Hippie459MN » Thu Feb 21, 2019 2:31 pm

I would try to disable the ext if its enabled, delete data, uninstall and start over. Guessing you installed it at one time before and didnt delete/remove it properly.

Senky
Extension Customisations
Extension Customisations
Posts: 2164
Joined: Thu Apr 30, 2009 8:49 pm
Name: Jakub
Contact:

Re: [3.2][RC] Mass Notification

Post by Senky » Thu Feb 21, 2019 2:39 pm

Hippie459MN wrote: โ†‘
Wed Jan 23, 2019 7:22 pm
I have an issue. Everything works, until I try to send a mass notification then I get this error. Im on phpBB 3.2.5 and php 7.1

Code: Select all

General Error
SQL ERROR [ mysqli ]

Duplicate entry 'senky_massnotification_id' for key 'PRIMARY' [1062]

SQL

INSERT INTO config (config_name, config_value, is_dynamic) VALUES ('senky_massnotification_id', '0', 0)

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 997
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 161
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 122
CALL: phpbb\config\db->set_atomic()

FILE: [ROOT]/phpbb/config/db.php
LINE: 188
CALL: phpbb\config\db->set()

FILE: [ROOT]/ext/senky/massnotification/acp/main_module.php
LINE: 185
CALL: phpbb\config\db->increment()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: senky\massnotification\acp\main_module->main()

FILE: [ROOT]/adm/index.php
LINE: 82
CALL: p_master->load_active()
I have uninstalled and reinstalled it 3 times and still the same error and never get any notifications.


EDIT: It seems to be working now. I was installing it using the Upload Extensions extension and I disabled Mass Notification then just deleted the files from the server and then replaced them manually and seems to be working fine now. Must be something with Upload Extesions that isnt playing nice with phpBB 3.2.5 cause it was when I installed an different extension and got a similar error that I reinstalled them manually and they started working just fine.
Truly must have been Upload Extensions error, my ext doesn't add such config.


Midway wrote: โ†‘
Sat Jan 26, 2019 11:04 am
Hi,

I have this error when I want install the extension

Code: Select all

Fatal error: Cannot declare class senky\massnotification\migrations\m1_acp_module, because the name is already in use in C:\UwAmp\www\ext\senky\massnotification\migrations\m2_id_incrementer.php on line 31
I assume you already installed it before? Or manipulated files somehow? In original files, migration names are correct. Try to download the ext once again.

User avatar
Hippie459MN
Registered User
Posts: 918
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [3.2][RC] Mass Notification

Post by Hippie459MN » Thu Feb 21, 2019 2:53 pm

Senky wrote: โ†‘
Thu Feb 21, 2019 2:39 pm
Hippie459MN wrote: โ†‘
Wed Jan 23, 2019 7:22 pm
I have an issue. Everything works, until I try to send a mass notification then I get this error. Im on phpBB 3.2.5 and php 7.1

Code: Select all

General Error
SQL ERROR [ mysqli ]

Duplicate entry 'senky_massnotification_id' for key 'PRIMARY' [1062]

SQL

INSERT INTO config (config_name, config_value, is_dynamic) VALUES ('senky_massnotification_id', '0', 0)

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 997
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 161
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/phpbb/config/db.php
LINE: 122
CALL: phpbb\config\db->set_atomic()

FILE: [ROOT]/phpbb/config/db.php
LINE: 188
CALL: phpbb\config\db->set()

FILE: [ROOT]/ext/senky/massnotification/acp/main_module.php
LINE: 185
CALL: phpbb\config\db->increment()

FILE: [ROOT]/includes/functions_module.php
LINE: 676
CALL: senky\massnotification\acp\main_module->main()

FILE: [ROOT]/adm/index.php
LINE: 82
CALL: p_master->load_active()
I have uninstalled and reinstalled it 3 times and still the same error and never get any notifications.


EDIT: It seems to be working now. I was installing it using the Upload Extensions extension and I disabled Mass Notification then just deleted the files from the server and then replaced them manually and seems to be working fine now. Must be something with Upload Extesions that isnt playing nice with phpBB 3.2.5 cause it was when I installed an different extension and got a similar error that I reinstalled them manually and they started working just fine.
Truly must have been Upload Extensions error, my ext doesn't add such config.
I have come to the conclusion that it was an issue with the Upload Extensions ext as it caused issues with a few other extensions as well. Your ext is working perfect now that I installed it manually.

Midway
Registered User
Posts: 22
Joined: Tue Dec 09, 2014 8:02 pm

Re: [3.2][RC] Mass Notification

Post by Midway » Thu Feb 21, 2019 4:53 pm

I reloaded the extension and now it's fine.

User avatar
teebling
Registered User
Posts: 41
Joined: Sat Apr 14, 2018 7:38 pm
Contact:

Re: [3.2][RC] Mass Notification

Post by teebling » Sun Feb 24, 2019 8:10 pm

Hey Senky,

When I click an unread notification that has been sent out using your extension it fails to redirect me to the specified page.
When I click a read notification that has been sent out using your extension, it correctly redirects me to the specified page.

I inspected the HTML and I can see the following:

Code: Select all

<a class="notification-block" href="./index.php?mark_notification=4724&amp;hash=cf31eb2a" data-real-url="http://localhost:8888/viewtopic.php?f=7&amp;t=1046">
Which is where I suppose the issue is - it is correctly marking the notification as read with the mark_notification function, but it isn't redirecting after that to the URL specified. It is somehow giving the 'make notification read' function priority over actually redirecting them maybe?

Normal notifications are working correctly.

This is in OS X using Safari v12.0. phpBB 3.2.2 (Prosilver), PHP version 7.2.1.
Image My World of Warcraft: Classic forum

Senky
Extension Customisations
Extension Customisations
Posts: 2164
Joined: Thu Apr 30, 2009 8:49 pm
Name: Jakub
Contact:

Re: [3.2][RC] Mass Notification

Post by Senky » Mon Feb 25, 2019 1:24 pm

teebling wrote: โ†‘
Sun Feb 24, 2019 8:10 pm
Hey Senky,

When I click an unread notification that has been sent out using your extension it fails to redirect me to the specified page.
When I click a read notification that has been sent out using your extension, it correctly redirects me to the specified page.
Thank you for the research! I got it. It redirects read notifications because they point directly to the specified URL. But unread notifications are firstly marked read and then redirected, using native redirect function which refuses external domains unless specified (which is not in our case). So unfortunately, I can't change that right now in the ext, but I posted a PR that will help me with that:
https://github.com/phpbb/phpbb/pull/5541

I will also submit new version of the ext that will be able to use the new event as soon as it is included in the core.

User avatar
teebling
Registered User
Posts: 41
Joined: Sat Apr 14, 2018 7:38 pm
Contact:

Re: [3.2][RC] Mass Notification

Post by teebling » Mon Feb 25, 2019 1:54 pm

Hey Senky, glad I could be of some help.

Looking forward to this extension once core event has been added and ext updated :)
Image My World of Warcraft: Classic forum

Senky
Extension Customisations
Extension Customisations
Posts: 2164
Joined: Thu Apr 30, 2009 8:49 pm
Name: Jakub
Contact:

Re: [3.2][RC] Mass Notification

Post by Senky » Thu Mar 07, 2019 2:55 pm

Extension updated - now it allows you to select notification author. This will display his/her avatar in the notification.

I also added small UI perk to the ACP form - as soon as you add username to "Send to users" textarea, it will hide "Send to group" selectbox since it will ignore it anyway. Once the textarea is empty again, a group selectbox is displayed as well.

User avatar
</Solidjeuh>
Registered User
Posts: 1732
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [3.2][RC] Mass Notification

Post by </Solidjeuh> » Thu Mar 07, 2019 3:37 pm


Exabot
Translator
Posts: 175
Joined: Sun Jan 18, 2015 8:21 pm
Location: Estonia

Re: [3.2][RC] Mass Notification

Post by Exabot » Thu Mar 07, 2019 3:53 pm


Senky
Extension Customisations
Extension Customisations
Posts: 2164
Joined: Thu Apr 30, 2009 8:49 pm
Name: Jakub
Contact:

Re: [3.2][RC] Mass Notification

Post by Senky » Thu Mar 07, 2019 9:53 pm

</Solidjeuh> wrote: โ†‘
Thu Mar 07, 2019 3:37 pm
Dutch update
Exabot wrote: โ†‘
Thu Mar 07, 2019 3:53 pm
Estonia
Thank you guys! Could you send a PR to the main repo for the translation updates as you are already forking it?

User avatar
Hippie459MN
Registered User
Posts: 918
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [3.2][RC] Mass Notification

Post by Hippie459MN » Fri Mar 08, 2019 3:35 pm

Senky wrote: โ†‘
Thu Mar 07, 2019 2:55 pm
Extension updated
Updated and seems to be working perfect. Again, thank you for this!

User avatar
eunaumtenhoid
Registered User
Posts: 884
Joined: Wed Jun 03, 2009 12:46 am
Location: ????

Re: [3.2][RC] Mass Notification

Post by eunaumtenhoid » Sun Mar 10, 2019 2:34 pm

nice update @Senky ty
i updated lang pt_br
My translations of the extensions for Brazilian Portuguese
https://github.com/phpBBTraducoes

Locked

Return to โ€œExtensions in Developmentโ€