[3.2][RC] Dice rolls

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Dice rolls

Post by 3Di » Sun May 26, 2019 3:18 am

Please provide a step-by-step instructions on how to reproduce the issue.

The expected behaviour as well.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

Tiree
Registered User
Posts: 18
Joined: Wed Jul 22, 2009 9:16 pm

Re: [3.2][BETA] Dice rolls

Post by Tiree » Sun May 26, 2019 5:15 am

Not a problem -

I realized this may be the issue - I am utilizing phpbb3.2.7

phpBB3.2.7 (brand new board)
phpBB Studio - Dice Mod 2.0.0-beta
only other installed extension: VigLink

Installed extension
Edited First Forum and used the following settings:
Image
Change UCP to Classic_Steel
Go make a post
Get the following result
Image

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Dice rolls

Post by 3Di » Sun May 26, 2019 5:48 am

Thanks for feedback, much appreciated.
I will try to reproduce it, in case will be fixed.

If you see any other issue pls report.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Dice rolls

Post by 3Di » Sun May 26, 2019 6:53 am

Tiree wrote: ↑
Sun May 26, 2019 5:15 am
I realized this may be the issue - I am utilizing phpbb3.2.7
That's not a bug but a feature .. really.

As per default this User permission is ON, that's why.

Can ignore overriding forum skins. The user selected skin will be used, even when the forum skin is set to β€œoverride”.

You can change it on a per group basis using roles (User Standard)

Image
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Dice rolls

Post by 3Di » Mon Jun 03, 2019 4:47 am

locust shell wrote: ↑
Fri Apr 26, 2019 1:40 am
I've noticed something while playing around with it: when the BBCode to show an already existing roll is quoted or copied onto another page (doesn't seem to matter whether it's the next page within the same topic, or a different topic entirely), the roll results don't always display.

If there happens to be a "new" roll displayed on the topic page in question--shown inline in the post that originated the roll--then any other rolls quoted/copied on that page display perfectly.

But, if that's not the case (no "new" rolls are present on the page) it seems like the dice-display doesn't generate properly for the quoted rolls.
If you want to test it again, the hotfix is here.
https://github.com/phpBB-Studio/DiceRolls/issues/1

Thanks. :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

[3.2][RC] Dice rolls

Post by 3Di » Mon Jun 03, 2019 9:21 pm

New and final version 2.0.1 available.

(submitted to the CDB) - See first post.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 6060
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: [3.2][RC] Dice rolls

Post by Raul [ThE KuKa] » Sat Jun 08, 2019 10:04 am

"PR" for Spanish translation ready Marco. ;)
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate with Image
:flag_es: phpBB Spain - Online Since 2003 :heart:



User avatar
mrgoldy
Jr. Extension Validator
Posts: 1047
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs

Re: [3.2][RC] Dice rolls

Post by mrgoldy » Sat Jun 08, 2019 11:49 am

Much appreciated, Raul! Thanks! :mrgreen:
phpBB Studio / ''Proud member of the Studio"

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][RC] Dice rolls

Post by 3Di » Sat Jun 08, 2019 1:27 pm

Yeah, muy apreciado. ;)

Thank you for meeting my request in such a short time.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

[3.2][RC] Dice rolls

Post by 3Di » Sat Jun 08, 2019 6:26 pm

New version 2.1.0 - see first post. ;)

Changelog inside.

Update:
  • disable and NOT delete data
  • delete old files and upload the new ones
  • enable it again.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

[3.2][RC] Dice rolls

Post by 3Di » Mon Jun 10, 2019 1:35 am

New version 2.1.1 - see first post. ;)

Changelog inside.

Update:
  • disable and NOT delete data
  • delete old files and upload the new ones
  • enable it again.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

BlackGirl
Registered User
Posts: 32
Joined: Thu Feb 24, 2011 9:52 pm

Re: [3.2][RC] Dice rolls

Post by BlackGirl » Wed Jul 03, 2019 9:55 pm

Hi, I've installed this extension and it causes a striking mistake. Some messages' contents fade off just as is if there was nothing written in them, but when I try to edit it's clearly seen there is text in them (bbcodes, etc). It happens in prosilver.
I attach screenshots

https://i.imgur.com/wPofgOd.png
https://i.imgur.com/E4bWrth.png
https://rhea.phpbbstudio.com/viewtopic. ... p=335#p335

Thanks.

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1047
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs

Re: [3.2][RC] Dice rolls

Post by mrgoldy » Thu Jul 04, 2019 10:56 am

That's an excellent catch, thank you for reporting it!

Seems like there was a problem with a regex, throwing an error and returning null instead of the actual message.
That's why there is nothing visible at all!

So, I recreated the issue on my localhost and started searching and found the issue.
I was able to come up with a fix that works for me, but could you verify this fix for me?

Open ext/phpbbstudio/dice/event/display_listener.php
Line 168: "/<blockquote.*(.+?)<\/blockquote>/s",
Replace with: '/<blockquote[^>]*>(.+?)<\/blockquote>/s',

Long story short: the regex was faulty, causing it to endlessly loop over the text if no direct matches were found.
.* looks for any character and as much as possible.
.+? looks for any characters and as little as possible, but everything was already matched by the above mentioned, so it started 'backtracking' and re-evaluating the entire message over and over. Which eventually throws a PREG_BACKTRACK_LIMIT_ERROR and then returns null.

Once again thank you for reporting it! :mrgreen:
phpBB Studio / ''Proud member of the Studio"

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][RC] Dice rolls

Post by 3Di » Thu Jul 04, 2019 12:13 pm

* double * see below.
Last edited by 3Di on Thu Jul 04, 2019 12:20 pm, edited 1 time in total.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

User avatar
3Di
Former Team Member
Posts: 13769
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][RC] Dice rolls

Post by 3Di » Thu Jul 04, 2019 12:19 pm

Thanks for feedback indeed. :)

The related issue has been created here:
https://github.com/phpBB-Studio/DiceRolls/issues/3

The same regex should be replaced 4 times in the same file.

Lines: 168, 261, 385, 489
https://github.com/phpBB-Studio/DiceRol ... 5c22c4cea0
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity ΒΊ PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
πŸ‘¨β€πŸ« | Take a tour to | The Studio | πŸ‘¨β€πŸ«

Post Reply

Return to β€œExtensions in Development”