Page 1 of 3

[3.2][DEV] Dark Mode

Posted: Mon Mar 25, 2019 10:42 pm
by Aurelienazerty
Extension Name: Dark Mode
Author: Aurelienazerty

Extension Description: Enable switching between Dark and Light mode
Extension Version: 0.9.0

Demo URL: https://www.team-azerty.com/forum/

Extension Download: https://github.com/Aurelienazerty/darkMode

Re: [DEV] Dark Mode

Posted: Tue Mar 26, 2019 10:03 am
by Skyrider
Github URL shows a 404. And as for the demo, I have no clue how to actually "switch" modes. There's no indication on the page anywhere to do so.

Re: [DEV] Dark Mode

Posted: Tue Mar 26, 2019 2:01 pm
by Aurelienazerty
Indeed, the repository was private. I turned it public.
I realised that the switch button was not visible when you are note logged in. I'll change this in few time (it's still in development)

Re: [DEV] Dark Mode

Posted: Tue Mar 26, 2019 9:44 pm
by Aurelienazerty
Now it's working for not logged user. You can test it.

Re: [DEV] Dark Mode

Posted: Tue Mar 26, 2019 11:34 pm
by nou nou
Neat!

Would this be style agnostic or prosilver only?

Re: [DEV] Dark Mode

Posted: Wed Mar 27, 2019 8:37 am
by mastnacek
Great, that feature i love!

Re: [DEV] Dark Mode

Posted: Wed Mar 27, 2019 8:39 am
by fagbutlil
:o I have this feature in one of my exts.

Re: [DEV] Dark Mode

Posted: Wed Mar 27, 2019 1:06 pm
by Aurelienazerty
nou nou wrote:
Tue Mar 26, 2019 11:34 pm
Would this be style agnostic or prosilver only?
It's working for all style... But, I think in some few case it may have some adaptation.

Re: [DEV] Dark Mode

Posted: Wed Mar 27, 2019 3:30 pm
by Talk19Zehn
Hello, thanks for your idea and I like to give this hint to you: I notice that no 'back' in the browser is possible because "Dark" is not "saved". For example, FF always switches to "Light", although "Dark" has been chosen (your Demo URL). Please see where the catch is. Or are my current browsers wrongly defined .... ;)

Regards

Edit:
Okay, it only works here currently if I manually clear the cache into the browser - after I have change (light / dark).

Re: [DEV] Dark Mode

Posted: Wed Mar 27, 2019 5:21 pm
by Raul [ThE KuKa]
"PR" for composer.json file...

I would personally edit the topic prefix by [3.2][DEV] ;)

Best regards and nice job.

Re: [DEV] Dark Mode

Posted: Thu Mar 28, 2019 9:16 am
by Aurelienazerty
Talk19Zehn wrote:
Wed Mar 27, 2019 3:30 pm
Hello, thanks for your idea and I like to give this hint to you: I notice that no 'back' in the browser is possible because "Dark" is not "saved". For example, FF always switches to "Light", although "Dark" has been chosen (your Demo URL). Please see where the catch is. Or are my current browsers wrongly defined .... ;)

Regards

Edit:
Okay, it only works here currently if I manually clear the cache into the browser - after I have change (light / dark).
It's strange, because I save the change in a cookie named darkmode.
Raul [ThE KuKa] wrote:
Wed Mar 27, 2019 5:21 pm
I would personally edit the topic prefix by [3.2][DEV] ;)
Done
Raul [ThE KuKa] wrote:
Wed Mar 27, 2019 5:21 pm
Best regards and nice job.
Thanks

[DEV] [3.2] Dark Mode

Posted: Thu Mar 28, 2019 4:40 pm
by MedCo
Hello

what can I do to keep the background unchanged?

Great extension. I like it.

Re: [DEV] [3.2] Dark Mode

Posted: Thu Mar 28, 2019 10:14 pm
by Aurelienazerty
Which thème do you use ? Have you got one thème by default or several ?

[DEV] [3.2] Dark Mode

Posted: Fri Mar 29, 2019 1:29 am
by MedCo
I use prosilver. The background is a photo. This should remain unchanged when using the extension.

Re: [DEV] [3.2] Dark Mode

Posted: Fri Mar 29, 2019 6:46 am
by david63
Can I just point out that if you intend, at some point, to submit this extension to the CDB that phpBB uses "snake_case" and not "camelCase".

Also you have an error in your listener doc block