[3.2][RC] To First Unseen Post

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
lexlf
Registered User
Posts: 6
Joined: Fri Apr 12, 2019 3:50 pm

[3.2][RC] To First Unseen Post

Post by lexlf » Fri Apr 12, 2019 11:34 pm

Extension Name: To First Unseen Post
Author: alexlf

Extension Description: Allows to reach the first unseen post, instead of last post from forum link.
Extension Version: 1.1.1

Requirements: 3.2+

Features: Modify topic and forum link to go to the first unseen post, instead of the last post.

Extension Download: https://github.com/alexandrelefourner/P ... nseen-post

Last update: 04.16.2019
Last edited by lexlf on Tue Apr 16, 2019 7:29 pm, edited 5 times in total.

User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 6015
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: [RC] To First Unseen Post

Post by Raul [ThE KuKa] » Sat Apr 13, 2019 1:48 pm

It's for phpBB 3.2 version?

composer.json file...

Code: Select all

    "require": {
        "php": ">=5.3.3",
        .................................
    },
    "extra": {
        ...............................
        "soft-require": {
            "phpbb/phpbb": ">=3.1.4,<3.2.0@dev"
main_listener.php file...

Code: Select all

$frow["U_LAST_POST"] = "./viewtopic.php?t=".$event["row"]["last_topic_id"]."&view=unread#unread";
viewtopic.php php extension ?
$this->php_ext
append_sid ?
$this->phpbb_root_path ?

RC version ?

https://area51.phpbb.com/docs/dev/3.2.x ... index.html
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate with Image
:flag_es: phpBB Spain - Online Since 2003 :heart:



lexlf
Registered User
Posts: 6
Joined: Fri Apr 12, 2019 3:50 pm

Re: [RC] [3.2][RC] To First Unseen Post

Post by lexlf » Sat Apr 13, 2019 10:23 pm

Hello Raul,

Thank you very much for your feedback. This is the first extension I want to share.

I updated my code according to your recommendations. Please let me know if anything else should be changed.

Kind regards,

Lexlf

User avatar
Prosk8er
Registered User
Posts: 1444
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: [RC] [3.2][RC] To First Unseen Post

Post by Prosk8er » Sat Apr 13, 2019 11:02 pm


lexlf
Registered User
Posts: 6
Joined: Fri Apr 12, 2019 3:50 pm

Re: [3.2][RC] To First Unseen Post

Post by lexlf » Sun Apr 14, 2019 6:37 pm

Hello Prosk8er,

Indeed, the link was broken. I fixed it.

I also implemented an uniformity in the if/for statement.

Thank you for your feedback.

mh254
Registered User
Posts: 10
Joined: Tue Jan 21, 2014 5:56 pm

Re: [3.2][RC] To First Unseen Post

Post by mh254 » Tue Apr 16, 2019 3:53 am

I have this error: [phpBB Debug] PHP Notice: in file [ROOT]/ext/alexlf/tofirstunseenpost/event/main_listener.php on line 102: Undefined property: alexlf/tofirstunseenpost/event/main_listener::$phpbb_root_path

User avatar
Mannix_
Registered User
Posts: 475
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: [3.2][RC] To First Unseen Post

Post by Mannix_ » Tue Apr 16, 2019 7:34 am

Great extension!!! This should be core behavior imo :D
-=-=-=-=-=-=-=-=-=-=-=-=-My Styles-=-=-=-=-=-=-=-=-=-=-=-=-
HexagonHexagonRebornCleanSilverProject Durango
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Want me to port a style to 3.2.x etc. contact me here or on twitter.

User avatar
Hartenheer
Registered User
Posts: 740
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [3.2][RC] To First Unseen Post

Post by Hartenheer » Tue Apr 16, 2019 3:00 pm

:lol: :lol: :lol:

When I asked for this post, I received a lot of comments
Sorry English is not my native language :oops:

lexlf
Registered User
Posts: 6
Joined: Fri Apr 12, 2019 3:50 pm

Re: [3.2][RC] To First Unseen Post

Post by lexlf » Tue Apr 16, 2019 7:27 pm

mh254 wrote:
Tue Apr 16, 2019 3:53 am
I have this error: [phpBB Debug] PHP Notice: in file [ROOT]/ext/alexlf/tofirstunseenpost/event/main_listener.php on line 102: Undefined property: alexlf/tofirstunseenpost/event/main_listener::$phpbb_root_path
Hello mh254,

I had a hard time reproducting the bug, but I just sent a new version of the Github.

Can you confirm the bug is now fixed please ?

Thank you for your feedbacks :D

Holger
Registered User
Posts: 1725
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][RC] To First Unseen Post

Post by Holger » Thu Apr 18, 2019 8:42 am

I am a little bit confused.
Is this the same behaviour like the topic-icon, going to first unread post in a topic?

User avatar
Mannix_
Registered User
Posts: 475
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: [3.2][RC] To First Unseen Post

Post by Mannix_ » Thu Apr 18, 2019 9:05 am

Holger wrote:
Thu Apr 18, 2019 8:42 am
I am a little bit confused.
Is this the same behaviour like the topic-icon, going to first unread post in a topic?
Basically yes
-=-=-=-=-=-=-=-=-=-=-=-=-My Styles-=-=-=-=-=-=-=-=-=-=-=-=-
HexagonHexagonRebornCleanSilverProject Durango
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Want me to port a style to 3.2.x etc. contact me here or on twitter.

Holger
Registered User
Posts: 1725
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][RC] To First Unseen Post

Post by Holger » Thu Apr 18, 2019 9:09 am

Ok, so that the topic-icon, small red icon and the topic-text has the same functionality? That is nice and consistent, but removes the possibility to go to the first post completely if there are unread posts.
A moderator who wants to change the topic title but not wants to read the unread posts for some reason cannot do that in the common easy way.

User avatar
Mannix_
Registered User
Posts: 475
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: [3.2][RC] To First Unseen Post

Post by Mannix_ » Thu Apr 18, 2019 10:21 am

Holger wrote:
Thu Apr 18, 2019 9:09 am
Ok, so that the topic-icon, small red icon and the topic-text has the same functionality? That is nice and consistent, but removes the possibility to go to the first post completely if there are unread posts.
A moderator who wants to change the topic title but not wants to read the unread posts for some reason cannot do that in the common easy way.
topic icon =/= topic tittle. The icon takes you to the first unread post in a topic and Topic Tittle takes you to the first post of the topic unread or read it doesn't matter. As a side note lexlf you should remove the topic icon next to tittle since it is not needed.

EDIT
lexlf wrote:
Tue Apr 16, 2019 7:27 pm
Can you confirm the bug is now fixed please ?
Can confirm this issue is fixed
-=-=-=-=-=-=-=-=-=-=-=-=-My Styles-=-=-=-=-=-=-=-=-=-=-=-=-
HexagonHexagonRebornCleanSilverProject Durango
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Want me to port a style to 3.2.x etc. contact me here or on twitter.

lexlf
Registered User
Posts: 6
Joined: Fri Apr 12, 2019 3:50 pm

Re: [3.2][RC] To First Unseen Post

Post by lexlf » Thu Apr 18, 2019 8:59 pm

Holger wrote:
Thu Apr 18, 2019 9:09 am
Ok, so that the topic-icon, small red icon and the topic-text has the same functionality? That is nice and consistent, but removes the possibility to go to the first post completely if there are unread posts.
A moderator who wants to change the topic title but not wants to read the unread posts for some reason cannot do that in the common easy way.
Hello ! As you can see on the following image, the plugin will still leave you the possibility to go to the first post of the topic. Through the page numerotation of course, but also from the title of the topic.

Image
Mannix_ wrote:
Thu Apr 18, 2019 10:21 am

As a side note lexlf you should remove the topic icon next to tittle since it is not needed.

EDIT
lexlf wrote:
Tue Apr 16, 2019 7:27 pm
Can you confirm the bug is now fixed please ?
Can confirm this issue is fixed
Thank you for your feedback. Are you talking of the orange box I put on my previous image ?

Holger
Registered User
Posts: 1725
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [3.2][RC] To First Unseen Post

Post by Holger » Thu Apr 18, 2019 9:23 pm

lexlf wrote:
Thu Apr 18, 2019 8:59 pm
Holger wrote:
Thu Apr 18, 2019 9:09 am
Ok, so that the topic-icon, small red icon and the topic-text has the same functionality? That is nice and consistent, but removes the possibility to go to the first post completely if there are unread posts.
A moderator who wants to change the topic title but not wants to read the unread posts for some reason cannot do that in the common easy way.
Hello ! As you can see on the following image, the plugin will still leave you the possibility to go to the first post of the topic. Through the page numerotation of course, but also from the title of the topic.

Image
Now I am struggeling a bit.
The picture shows the out of the box functionality I think?
Only the "Last post" icon does not lead to the last post, it leads to the first unread post in the topic.
Is that the only change this Ext does?

Very sorry, I feel a lot confused because I dont see what this Ext really does.

Post Reply

Return to “Extensions in Development”