Page 2 of 3

Re: [RC] Selective mass emails

Posted: Mon Jul 15, 2019 7:59 pm
by ac_roma
nice mod i will try it

Version 1.0.4 released and sent for review

Posted: Sun Aug 18, 2019 2:49 pm
by MarkDHamill
Version 1.0.4 of the extension is released and has been submitted for review by the phpBB extension review team.

You can download it from my web page.

[RC} Version 1.0.5 released

Posted: Wed Oct 09, 2019 5:06 pm
by MarkDHamill
This extension had its first review by the extension review team, and a new version 1.0.5 is now available. See the first post to download it. Only one new feature: you can send emails to people based on the number of unapproved posts. This version has been resubmitted for another review.

[RC] Selective mass emails 1.0.6

Posted: Thu Oct 10, 2019 1:07 pm
by MarkDHamill
I made a mistake in version 1.0.5: I was counting approved posts when I should have been counting non-approved posts, i.e. post_visibility=1 instead of post_visibility=0. This made it easier for me to do my testing. I just forgot to change it to count properly. See first post for version 1.0.6 download links that fixes this issue.

Re: [RC] Selective mass emails 1.0.6

Posted: Thu Oct 10, 2019 8:21 pm
by KlausiMaus
Version control shows
Failed to obtain latest version information.

Re: [RC] Selective mass emails 1.0.6

Posted: Thu Oct 10, 2019 8:58 pm
by MarkDHamill
Thanks. Not sure why as I changed composer.json to specify ssl:

Code: Select all

    "extra": {
        "display-name": "Selective mass emails",
        "soft-require": {
            "phpbb/phpbb": ">=3.2.0,<3.3.0@dev"
        },
        "version-check": {
            "host": "www.phpbbservices.com",
            "directory": "/other/selectivemassmails/updatecheck/",
            "filename": "3.2.json",
            "ssl": true
        }
    }
and the same approach worked for the digest extension, and the file comes up in a web browser easily enough:

https://www.phpbbservices.com/other/sel ... k/3.2.json

Re: [RC] Selective mass emails 1.0.6

Posted: Thu Oct 10, 2019 9:15 pm
by MarkDHamill
Looks like line 28 in composer.json should be:

Code: Select all

            "directory": "/other/selectivemassemails/updatecheck/",
Thanks.

Re: [RC] Selective mass emails 1.0.6

Posted: Thu Oct 10, 2019 9:43 pm
by KlausiMaus
Perfekt :!:

Selective mass emails 1.0.7

Posted: Mon Oct 14, 2019 1:41 pm
by MarkDHamill
A newest version is now available, having gotten a quick review of the last one by the extension review team. See first post for links. There was a minor bug fix regarding unapproved email filtering, otherwise just improving the way the extension works based on the team's feedback.

Re: [RC] Selective mass emails 1.0.7

Posted: Mon Oct 14, 2019 4:50 pm
by KlausiMaus
There is only one little thing, it is not possible to do an update with the Upload Extensions:
14-10-_2019_18-22-57.jpg
A wrong link to the ZIP-file, isn't it?

Re: [RC] Selective mass emails 1.0.7

Posted: Mon Oct 14, 2019 7:24 pm
by MarkDHamill
That's a link to the page for the extension where it can be downloaded. Not sure how that URL is being grabbed since it's not in the composer.json file. Also, the Uploads extension does not indicate it works for phpBB 3.2.

Re: [RC] Selective mass emails 1.0.7

Posted: Tue Oct 15, 2019 12:50 am
by KlausiMaus
Version 3.2.0-RC works even with 3.2.8 :!:
I use this tool since years and I love it :!:

Maybe another developer knows how it works since thee are a lot off extension working with the tool.

Re: [RC] Selective mass emails 1.0.7

Posted: Tue Oct 15, 2019 2:32 am
by 3Di
Is it just me or the date-pickers aren't working? FF and IE.

We at the Studio are using: https://github.com/fengyuanchen/datepicker

Suggested. https://fengyuanchen.github.io/datepicker/

Re: [RC] Selective mass emails 1.0.7

Posted: Tue Oct 15, 2019 12:49 pm
by MarkDHamill
No, it's not just you. Apparently I missed a replace when I was asked to change the definition INCLUDED_SMEJS.

Line 2 of /ext/phpbbservices/selectivemassemails/adm/style/event/acp_overall_footer_after.html is:

Code: Select all

{% if definition.INCLUDED_SMEJS %}
and should be:

Code: Select all

{% if definition.INCLUDED_JQUERYUI1121JS%}
Thanks for reporting the error.

[RC] Selective mass emails 1.0.8 released

Posted: Thu Oct 17, 2019 4:00 pm
by MarkDHamill
This version fixes the bug 3Di noticed (thanks) that kept the popup date picker from coming up. Found a few other things that were not quite correct that I fixed too:
  • Made the default operator for unread private messages to greater than or equal to, as most likely if you are going to send emails based on the number of private messages, it will be based on a large number of them in the user's mailbox.
  • For the date picker controls (last visited and last post), I realized that for the less than or equal to and the greater than operators, I had to add 24 hours (less one second) to the timestamp, as the timestamp returns the timestamp for midnight of the date picked, and I needed the last possible second for the date picked.
  • Applied $db->sql_escape() to the operator fields to avoid SQL injection concerns. Also did the same with the number fields returned by the $request object, although it was redundant.
Download links are on the first post.