[RC] Filter by country - version 1.0.6

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [BETA] Filter by country - version 1.0.3

Post by MarkDHamill » Fri Jul 05, 2019 8:00 pm

One thing I could do on your issue is to check the return value of rmdir and unlink. If they can't delete files and folders, some action should be taken. I think that was the case: the permissions weren't there so it couldn't complete the tasks.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
</Solidjeuh>
Registered User
Posts: 1684
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [BETA] Filter by country - version 1.0.3

Post by </Solidjeuh> » Fri Jul 05, 2019 8:23 pm

MarkDHamill wrote:
Fri Jul 05, 2019 1:54 pm
I'm guessing it's an issue updating your database. Make sure the permission is the /store and the /store/phpbbservice/filterbycountry folders are 777. You can try just deleting the folder. It should get recreated.
It's strange, I CHMODDED the folder and all files inside to 0777, but not of my cronjobs would start. They all stayed in "queue". Disabled the ext, and they started again.
Register a free account & Play!!
~~~ https://www.solidjeuh.be ~~~

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [BETA] Filter by country - version 1.0.3

Post by MarkDHamill » Tue Jul 09, 2019 8:59 pm

What do people think about capturing more statistical information? I'm thinking that the phpbb_fbc_stats table could be expanded to capture the IP, page requested and user agent string of those restricted. In addition, the report could be expanded so the country name becomes a link and if you click on the link you can see a list this information. This would make for a much bigger table but it would provide "drill down" details.

Right now, the log can be cleared entirely but not partially. It might be useful to have a function that clears the log for periods, like say retain the last two weeks, or specify a block of time to keep in the log.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

[RC] Filter by country - version 1.0.4 released

Post by MarkDHamill » Sat Jul 27, 2019 10:35 pm

Version 1.0.4 is now released. This is a release candidate.

Changes since 1.0.3 include:
  • Statistics table uses ID and HEADER attributes for improved accessibility
  • Country flags are shown in the report
  • Improved logic for downloading and updating the MaxMind country codes database. Hopefully it addresses the issues noted by a tester.
  • Fixes the encoding bug with country names containing special characters. Thanks EA117 for the solution!
There are three language changes. See the list of changes for changes needed.

I probably won't be adding any additional features but if you think more are needed speak up soon before it goes up for formal review.

For downloads, see the first post.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Hartenheer
Registered User
Posts: 768
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by Hartenheer » Sun Jul 28, 2019 9:27 am

Will follow this very interesting extension.
And start using it when it is stable.

Why is it marked as RC if it is not yet stable?
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by MarkDHamill » Sun Jul 28, 2019 12:25 pm

What instability are you noticing? I haven't noticed any in my testing.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Hartenheer
Registered User
Posts: 768
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by Hartenheer » Sun Jul 28, 2019 12:36 pm

MarkDHamill wrote:
Sun Jul 28, 2019 12:25 pm
What instability are you noticing? I haven't noticed any in my testing.
Because this line is on the first page, I don't dare to use it on a running forum
Being an alpha extension, it should not be used on a production board. Take it for a test drive and let me know if it's working correctly and suggestions for improvement
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by MarkDHamill » Sun Jul 28, 2019 12:39 pm

Thanks. With every new version, I must edit the first post. I missed this and removed it from the first post.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Hartenheer
Registered User
Posts: 768
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by Hartenheer » Sun Jul 28, 2019 12:43 pm

MarkDHamill wrote:
Sun Jul 28, 2019 12:39 pm
Thanks. With every new version, I must edit the first post. I missed this and removed it from the first post.
Thank you for your answer, I will try to set it up

Then you have less chance of Russian spammers
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
janus_zonstraal
Registered User
Posts: 3361
Joined: Sat Aug 30, 2014 1:30 pm

Re: [RC] Filter by country - version 1.0.4

Post by janus_zonstraal » Sun Jul 28, 2019 8:54 pm

What about search bots, I assume that the are blocked and you have to give there country access?
Sorry! My English is bat ;) !!!

User avatar
janus_zonstraal
Registered User
Posts: 3361
Joined: Sat Aug 30, 2014 1:30 pm

Re: [RC] Filter by country - version 1.0.4

Post by janus_zonstraal » Sun Jul 28, 2019 9:05 pm

en uw land is Spanja
Dutch translation error "Spanja" must be "Spanje"
Sorry! My English is bat ;) !!!

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by MarkDHamill » Sun Jul 28, 2019 9:41 pm

janus_zonstraal wrote:
Sun Jul 28, 2019 8:54 pm
What about search bots, I assume that the are blocked and you have to give there country access?
If the search engine's IP is associated with a blocked country, it would just get the blocked message shown on the first post. Not much to index there. It's not hard to masquerade as a search engine so really there's no way to let them selectively in.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by MarkDHamill » Sun Jul 28, 2019 9:44 pm

janus_zonstraal wrote:
Sun Jul 28, 2019 9:05 pm
en uw land is Spanja
Dutch translation error "Spanja" must be "Spanje"
Might want to do a pull request here:

https://github.com/Solidjeuh/filterbyco ... common.php
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
</Solidjeuh>
Registered User
Posts: 1684
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by </Solidjeuh> » Mon Jul 29, 2019 12:10 pm

MarkDHamill wrote:
Sun Jul 28, 2019 9:44 pm
Might want to do a pull request here:
janus_zonstraal wrote:
Sun Jul 28, 2019 9:05 pm
Dutch translation error "Spanja" must be "Spanje"
I fixed the NL translation, and updated to latest version.
https://github.com/Solidjeuh/filterbycountry
Register a free account & Play!!
~~~ https://www.solidjeuh.be ~~~

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Filter by country - version 1.0.4

Post by MarkDHamill » Mon Jul 29, 2019 12:12 pm

Thanks!
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

Post Reply

Return to “Extensions in Development”