[3.2][BETA] Advanced Shop System

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Glorio
Registered User
Posts: 13
Joined: Tue Oct 01, 2019 7:29 am
Location: France

Re: [3.2][BETA] Advanced Shop System

Post by Glorio » Mon Oct 07, 2019 8:14 am

3Di wrote:
Sun Oct 06, 2019 8:36 pm
The action is Ajax'ed, will reload the page once done.
And it is, done, since the http response (status code) is 200 (OK).

Are you sure your browser has javascript enabled?
AJAX informs me that it works, but indeed not at all. Moreover I noticed that by deleting a file, or an image it is not suppressed. Refreshing the page, a long error message goes to the top of the admin panel. Here is a gif of creating a folder and an image, then removing all this. You will see that I have to purge the cache, return to File and then F5 on the page.

Image

User avatar
3Di
Former Team Member
Posts: 14372
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by 3Di » Mon Oct 07, 2019 8:34 am

We are currently investigating your issue, thanks.

Image

Please next time simply copy&paste the error. :) There are double slashes in the URL I can see.

Do you confirm PHP 7.2.2 and phpBB 3.2.8?
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by mrgoldy » Mon Oct 07, 2019 8:40 am

If you have a proper editor (Notepad++, Atom or the likes) could you try a change and see if this fixes the issue for you:

Could you open phpbbstudio/ass/helper/files.php and on line 376 you will find:

Code: Select all

	public function get_path($directory, $root = true, $file = '')
	{
		$root_path = $root ? $this->root_path : '';
		$file = $file ? "/{$file}" : '';

		return "{$root_path}{$this->mode}/aps/{$directory}{$file}";
	}
Could you try and replace that with:

Code: Select all

	public function get_path($directory, $root = true, $file = '')
	{
		$root_path = $root ? $this->root_path : '';

		$directory = $directory ? "/{$directory}" : '';
		$file = $file ? "/{$file}" : '';

		return "{$root_path}{$this->mode}/aps{$directory}{$file}";
	}
Alternatively, if you do not want/know how to do these edits, could you try adding a file or directory within an already existing folder? So not in the base directory of the images mode. So that would mean create a 'Test' folder (with the error messages), purge the cache and then go to Files > Images > Test folder and then add an image or folder.

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by mrgoldy » Mon Oct 07, 2019 8:43 am

Shywing wrote:
Sun Oct 06, 2019 8:48 pm
Fatal error: Cannot use phpbbstudio\ass\entity\category as category because the name is already in use in /srv/disk1/2575031/www/manganimeverse.com/ext/phpbbstudio/ass/operator/inventory.php on line 13
Getting this error whenever I try to add items to the shop. Or when trying to view my inventory.
This will be fixed in the next release, thank you for reporting it.

User avatar
Glorio
Registered User
Posts: 13
Joined: Tue Oct 01, 2019 7:29 am
Location: France

Re: [3.2][BETA] Advanced Shop System

Post by Glorio » Mon Oct 07, 2019 9:08 am

3Di wrote:
Mon Oct 07, 2019 8:34 am
We are currently investigating your issue, thanks.

Image

Please next time simply copy&paste the error. :) There are double slashes in the URL I can see.

Do you confirm PHP 7.2.2 and phpBB 3.2.8?
The version of the forum is in 3.2.8

EDIT: @mrgoldy,
I just replaced the code, and it still does not work. I did register the code, purge the forum cache and try to host the image, but it does not work.
Last edited by Glorio on Mon Oct 07, 2019 9:14 am, edited 1 time in total.

User avatar
3Di
Former Team Member
Posts: 14372
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by 3Di » Mon Oct 07, 2019 9:11 am

Glorio wrote:
Mon Oct 07, 2019 9:08 am
The version of the forum is in 3.2.8
Oky, could you please test the hotfix?
See: viewtopic.php?p=15337421#p15337421
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
Glorio
Registered User
Posts: 13
Joined: Tue Oct 01, 2019 7:29 am
Location: France

Re: [3.2][BETA] Advanced Shop System

Post by Glorio » Mon Oct 07, 2019 9:16 am

3Di wrote:
Mon Oct 07, 2019 9:11 am
Glorio wrote:
Mon Oct 07, 2019 9:08 am
The version of the forum is in 3.2.8
Oky, could you please test the hotfix?
See: viewtopic.php?p=15337421#p15337421
You posted before me ^ _ ^ I made an edit.

So: I just replaced the code, and it still does not work. I did register the code, purge the forum cache and try to host the image, but it does not work.

User avatar
3Di
Former Team Member
Posts: 14372
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by 3Di » Mon Oct 07, 2019 9:20 am

Glorio wrote:
Mon Oct 07, 2019 9:16 am
So: I just replaced the code, and it still does not work. I did register the code, purge the forum cache and try to host the image, but it does not work.
please wait, still on it ...
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by mrgoldy » Mon Oct 07, 2019 9:34 am

Well, we've made some more changes but it's becoming bit hard to specify all in a post.
Please sit tight for now and just use your regular filesystem (or FTP), instead of the Files interface.
Bit 'hard' for us aswell, as we can not replicate the issues ouserlves unfortunately.
The changes will be included in the next release, which shouldn't be too far off.
Sorry for the inconvenience.

User avatar
Glorio
Registered User
Posts: 13
Joined: Tue Oct 01, 2019 7:29 am
Location: France

Re: [3.2][BETA] Advanced Shop System

Post by Glorio » Mon Oct 07, 2019 9:43 am

mrgoldy wrote:
Mon Oct 07, 2019 9:34 am
Well, we've made some more changes but it's becoming bit hard to specify all in a post.
Please sit tight for now and just use your regular filesystem (or FTP), instead of the Files interface.
Bit 'hard' for us aswell, as we can not replicate the issues ouserlves unfortunately.
The changes will be included in the next release, which shouldn't be too far off.
Sorry for the inconvenience.

I am completely understandable. I will wait for the last update from you. This is only a minor concern, it does not bother me more than that. Thank you for your help! :)

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by mrgoldy » Mon Oct 07, 2019 8:37 pm

A new version has been released: 1.1.1-beta
  1. Disable the extension
  2. Do NOT delete data
  3. Delete the phpbbstudio/ass folder
  4. Upload the download to phpbbstudio/ass
  5. Enable the extension
This version requires the just released Advanced Points System v1.0.2-beta!

Changelog 1.1.1-beta
  • Fixed users being able to gift themselves (now for real)
  • Fixed pressing enter causing the page to reload instead of submitting the gift form
  • Fixed redundant = in an HTML class attribute
  • Fixed points distribution, now all goes through Advanced Points System
  • Fixed the permission for managing the ACP Inventory not showing up
  • Fixed entity import names to prevent warnings on lower PHP versions
  • Fixed “File” item type not downloading when immediately deleted
  • Fixed double slashes (//) in shop folders' and files' paths
  • Added additional checks to file functions to ensure file existance
  • Added style template events
  • Added item stacking
    • Multiple of the same item can now be in a user's inventory
    • Only when the item is allowed to be stacked by the Administrator
    • The maximum item stack is configurable on a per item basis
    • Users need the permission to be authorised to stack items
    • Full explanation added to the “Take the tour” upon item creation
  • Extended index panels configuration
    • Panels can now be disabled by giving them a limit of 0
    • Panels can now be ordered, determining in which order they are displayed
    • Panels width is now also configurable by the administrator

User avatar
warlock666
Registered User
Posts: 24
Joined: Fri Sep 06, 2019 1:52 pm
Location: London
Name: Andrew Scott
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by warlock666 » Tue Oct 08, 2019 7:03 am

Cannot wait for it's official release, will help me in a big way :D

User avatar
wowmatu
Registered User
Posts: 24
Joined: Fri Mar 22, 2013 10:55 pm

Re: [3.2][BETA] Advanced Shop System

Post by wowmatu » Tue Oct 08, 2019 1:52 pm

Very good plugin
Is there any way to generate feedback to users?

User avatar
Glorio
Registered User
Posts: 13
Joined: Tue Oct 01, 2019 7:29 am
Location: France

Re: [3.2][BETA] Advanced Shop System

Post by Glorio » Tue Oct 08, 2019 2:05 pm

Hello, so after updating everything, there is always the same problem with file creation and image hosting. On the other hand, when deleting a folder I no longer have the error message. By deleting the folder, the folder is deleted visually, but if I do F5, the folder reappears. For image creation and hosting, I always have to purge the forum cache so that everything is there or everything that I have deleted is no longer there.

User avatar
mrgoldy
Jr. Extension Validator
Posts: 1182
Joined: Tue Oct 06, 2009 7:34 pm
Location: The Netherlands
Name: Gijs
Contact:

Re: [3.2][BETA] Advanced Shop System

Post by mrgoldy » Tue Oct 08, 2019 2:12 pm

wowmatu wrote:
Tue Oct 08, 2019 1:52 pm
Very good plugin
Is there any way to generate feedback to users?
Not sure what you're asking here?

And at Glorio.
What PHP version are you using? What server are you on?
I tried everything locally and live to 'break it' but I can not succeed.
Alternatively, just use the regular FTP, as this was just designed as an ease of use interface.

Post Reply

Return to “Extensions in Development”