[3.2][3.3][RC] IP Address Deletion

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

[3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

Extension Name: IP Address Deletion

Image Image

Author: Mike-on-Tour
Extension Description:IP Address Deletion is an extension to the phpBB bulletin board software which ensures privacy and data protection by deleting user related IP addresses in all database tables original to phpBB when a user gets deleted.

There are countries where the IP address an internet user uses is assumed to belong to his/her personal data and thus falls under privacy and data protection laws. Especially the supreme court of the European Union ruled that a user has a right to be informed if the IP address from which he/she logs into a web site is stored and that he/she has a right to have this information deleted if the respective service is no longer used. This means that the IP address still stored within phpBB's database must be deleted if a user gets deleted.
phpBB stores user IP addresses in several tables and explicitly within the posts table it is not deleted if a user gets deleted and his/her posts are retained. This is what IP Address Deletion does.
To fulfill this task IP Address Deletion is hooked into phpBB's delete_user function via the core.delete_user_before event. Everytime a user is deleted it replaces IP addresses stored with this user's user_id with 0:0:0:0 to ensure that nowhere within the phpBB core tables the IP address is stored any longer.

Note
IP Address Deletion has no settings and is not visible anywhere in the ACP. After having been successfully enabled it just works in the background. Its existence is only visible through its presence in the table listing the enabled extensions.

Requirements: phpBB 3.2.x: PHP 5.4 + / phpBB 3.3.x: PHP 7.1 +
Download: https://www.mike-on-tour.com/mot/mot_ipdelete.php
Languages: n/a
Styles: n/a
Github repository: https://github.com/Mike-on-Tour/ipdelete

Tested with phpBB 3.2.10 and 3.3.1 under PHP 7.2.11 and 7.4.10
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
ssl
Registered User
Posts: 576
Joined: Sat Feb 08, 2020 2:15 pm
Location: France
Name: Fred
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by ssl »

Hi
Thanks for this extension
Sorry for my English ... I do my best!

phpBB version: 3.3.3
php version: 8.0.2
User avatar
HaioPaio
Registered User
Posts: 143
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] IP Address Deletion

Post by HaioPaio »

Mike
I have tested it in my testforum.
It works well for the table 'posts' for poster_ip.
However following tables still contain the users ip adresses:
'log' in log_id
'privmsgs' in author_ip
'session_keys' in last_ip
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

This is weird because the three tables mentioned by you are part of the nine tables this extension updates; and since this is done before phpBB's deletion function does anything it shouldn't know of the former IP addresses and therefore should be unable to restore them.
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
HaioPaio
Registered User
Posts: 143
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] IP Address Deletion

Post by HaioPaio »

i will repeat the test with all other extensions disabled. Should I provide you with a copy of my database, before and after user deletion?
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

You don't need to do this, I will believe you. Perhaps you can check the tables and the columns defined in event/main_listener.php on GitHub, perhaps I mispelled something and don't see it.
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
HaioPaio
Registered User
Posts: 143
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] IP Address Deletion

Post by HaioPaio »

Mike
I disabled all other extensions and deleted another user in my testforum.
Now, no single IP adress remained in the database. Everything was cleaned up properly.
I need a bit of time to find out if I can duplicate the reported problem when I reactivate other extensions, one by one.
User avatar
HaioPaio
Registered User
Posts: 143
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] IP Address Deletion

Post by HaioPaio »

I was not able to duplicate the reported problem.
I have installed the extension now on our live forum and deleted some sleeping users.
Everything works as intended.
Sorry for the false alarm. Thank you for this great extension.

Question: Will this work if a user will be deleted via your extension "user reminder"?
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

Yes, it will work with Userreminder since Userreminder just calls phpBB's delete_user function and ipdelete is hooked into that.
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
RMcGirr83
Former Team Member
Posts: 21903
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [3.2][3.3][RC] IP Address Deletion

Post by RMcGirr83 »

Mike-on-Tour wrote:
Wed Sep 30, 2020 10:28 am
This is weird because the three tables mentioned by you are part of the nine tables this extension updates; and since this is done before phpBB's deletion function does anything it shouldn't know of the former IP addresses and therefore should be unable to restore them.
That table array shouldn't be within the __construct of the extension (believe that will be a deny by the validators). Just place it in the method or create a new function and call it in the method.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

Thanks for the hint, it is already submitted so I'll wait and see. If this proves to be the case there will be ver. 1.0.1
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 27158
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Paul »

You should just inline that array in the method you are using it, it is only used in one place, so there is no need at all to have it as property.
User avatar
Mike-on-Tour
Registered User
Posts: 182
Joined: Wed Jan 15, 2020 3:51 pm
Location: Germany
Name: Michael
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Mike-on-Tour »

Okay, you are right. Should I do it now and submit an updated version for approval or wait?
Watz fo lunch?
If you like my extensions or my support please consider a donation: Image
User avatar
pierredu
Registered User
Posts: 1125
Joined: Thu Nov 01, 2012 8:04 am
Location: Paris (France)

Re: [3.2][3.3][RC] IP Address Deletion

Post by pierredu »

Fine idea.
User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 1346
Joined: Thu Apr 23, 2009 1:20 pm
Location: Stuttgart, Germany
Name: Christian
Contact:

Re: [3.2][3.3][RC] IP Address Deletion

Post by Crizzo »

Mike-on-Tour wrote:
Thu Oct 01, 2020 8:46 pm
Okay, you are right. Should I do it now and submit an updated version for approval or wait?
Update it and resubmit now. This will put you a bit back in the queue, but this is better than waiting and resubmit it anyway later.
My extensions for phpBB: crizzo.de
German phpBB Support at www.phpbb.de
Post Reply

Return to “Extensions in Development”