[3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
scheccia
Registered User
Posts: 94
Joined: Fri Feb 10, 2017 8:16 am

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by scheccia »

axe70 wrote: Thu Feb 04, 2021 4:08 pm But if i'm not wrong, on quick reply, you have title to insert, and textarea for the content, not attachments, isn't it?
no, i have it... i have quick reply reloaded https://boardtools.ru/QuickReply/
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Ah ok, i see, very nice; well the fact that the new version will allow to rotate images onclick directly on posts and not only into attachment panel, may will partially resolve, while hooking directly into this extension you use, which i do not know, may is easy also, but as said, unfortunately it is an extension i do not know at moment.
Do not take me too serious
Anyway i do not like Discourse
scheccia
Registered User
Posts: 94
Joined: Fri Feb 10, 2017 8:16 am

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by scheccia »

axe70 wrote: Thu Feb 04, 2021 4:31 pm well the fact that the new version will allow to rotate images onclick directly on posts and not only into attachment panel
:o WONDERFULL
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

Hello Alessio

Today I upgraded my testforum from 332 to 333 under php 7.4.14.
Your extension Ver. 103 does not store the rotated pics.
After rotating and clicking at "Store", the button changes to "processing" and stays there forever.
Clicking outside of the rotation windows causes the window to disappear.
The pics in the post remain unchanged.
With 332, the ext. works as expected.

Do you have any recommendation?
www.der-räuchertreff.de phpBB 3.3.x php 7.4
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Hello, going to update to 3.3.3 then and check what's going on.


i'm over plupload, adding a custom row to attachment as add audio to post button clicked.
It is making me crazy ... let take a pause updating phpBB and giving a try to check what's going wrong here
Do not take me too serious
Anyway i do not like Discourse
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Updated to 3.3.3 and all is going fine here.
Still in trouble?

There is a problem after the update, into a machine configured like this:
Server version: 5.6.10 - MySQL Community Server (GPL)
Apache/2.4.23 (Win32) OpenSSL/1.0.2h PHP/7.4.7
Database client version: libmysql - mysqlnd 7.4.7


After update to 3.3.3, when i go to open ACP, the MAIN ACP index page (this do not happen into any other ACP page, only into ACP index)
it return this:
General Error
SQL ERROR [ mysqli ]

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-phpbb3' at line 2 [1064]
SQL
SHOW TABLE STATUS FROM subdomain-phpbb3
BACKTRACE
FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()
FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 1023
....
so whenever someone else fall on this, the solution is to open:
phpBB3/phpbb/db/driver/driver.php
line 1023

Code: Select all

trigger_error($message, E_USER_ERROR);
just comment this line:

Code: Select all

//trigger_error($message, E_USER_ERROR);
as said, ACP links like
subdomain.w3host.com/phpbb3/adm/index.php?sid=your_SID&i=21
aren't affected. the problem have come out only into MAIN ACP PAGE. No way to fix it, the unique fix i find out that work is this one, comment line 1023 into driver.php file.
Do not take me too serious
Anyway i do not like Discourse
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

p.s stupid question:
did you changed the style? Is the style the same, where all was working last time?
I tested updating all, prosilver is the one of phpBB 3.3.3 and all is working. I will go on testing more little time along with something else.

p.s yes my question was stupid since the popup display and you say: the process seem to happen, but the image result not rotated.
So asking myself if something goes wrong when the image file is written to disk. Or something else.

If you can check, do you see some error into browser console, after you clicked into Popup rotate image button?
Do not take me too serious
Anyway i do not like Discourse
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

It could be easier to analyze if you had a look to my testforum.
I will send you Admin credentials via PM.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Ok let see what it can be!
Anyway, may admin account will not resolve too much, instead will see browser's errors if there are
Php error logs would may also would be the place where to take a look.
Very strange that it suddenly do not work into your site
Do not take me too serious
Anyway i do not like Discourse
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

Alessio
PM is out.
My server error log is clean. No entry related to my testforum.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

Alessio
Thanks for trying it at my forum. Its is strange. You reported that the pics rotate without problems when you log in.
Now, I tried it in the same configuration as before and the problem has disappeared.
Really strange. Let's call it "healing hands".
Thank you.

Now, you should have gained enough energy to continue working on 104 which will be a great step forward.
I'll keep fingers crossed.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

An error log code will be easy to be added, that will return what goes wrong when/if files not saved/rotated.
So it will be added.

I was answering via PM, but noticed of this reply, so may it is useful to put it here:

......... Ok, but do not think it can be a browser issue, but maybe i'm wrong.
If the popup open and the request executed, then the unique place where something can goes wrong is into file fileRotate.php where the passed request is checked about:
can the passed attach id be processed by the requesting user?

To check that this could be the problem, you could change this into file

/ext/w3all/imageattachrotation/core/fileRotate.php

Code: Select all

		if (!$own_attachment)
		{
			send_status_line(404, 'Not Found');
			trigger_error('ERROR_NO_ATTACHMENT');
		}
into this

Code: Select all

	/*	if (!$own_attachment)
		{
			send_status_line(404, 'Not Found');
			trigger_error('ERROR_NO_ATTACHMENT');
		}*/
and look if after this the rotation is executed. if then execute, the reason was that the user had no rights to execute the action.
You say it was an admin performing the action. So strange.

So just a question more:
You tested that now it work into another forum, or into same where the rotation failed? Are you testing into same forum?

Beware that obviously, editing the file in the way as above explained, will let any user passing correct values but with no permissions to edit the file, so it need to be only for testing purposes.
Let know!
Do not take me too serious
Anyway i do not like Discourse
User avatar
HaioPaio
Registered User
Posts: 265
Joined: Mon Jan 08, 2018 7:39 pm

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by HaioPaio »

axe70 wrote: Mon Feb 08, 2021 9:26 am So just a question more:
You tested that now it work into another forum, or into same where the rotation failed? Are you testing into same forum?
I tested it at the same forum as before with the same browser. No changes had been done from my side (I strongly believe).
So, for the time being, we should believe in your healing hands.
I cannot duplicate the fault at this time.

Whenever the problem will return, I will attempt the suggested code change then.

I am really happy that it works for now. This Extension has become indispensable in our Main Forum. The members use it a lot because it is so easy to use. A great relief for the team. They no longer need to rotate pics for the members.
www.der-räuchertreff.de phpBB 3.3.x php 7.4
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

This (pseudo) extension is so easy, to maintain it along the time is also easy. Substantially it is standalone, and mainly javascript. Unique php instructions on phpbb, are passing some var to the template, nothing more.
imageRotate.php and fileRotate.php files may needs to be little cleaned up of unwanted things that could differ from a phpBB version to another (if there are).

Next 1.0.4 will resolve some issues and will be improved to be more comfortable on customize the popup style (that will be improved also on default features and how thumbnail display) and icon dimension or prepend/append option. Will also reduce/remove some instruction to be faster and will add an easy error reporting, while imageRotate.php and fileRotate.php as said, will be cleaned up from instructions that could differ from a phpBB version to another.
NP! Anytime it will require an update due to phpBB code changes we can apply with easy.
Do not take me too serious
Anyway i do not like Discourse
User avatar
axe70
Registered User
Posts: 752
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Name: Alessio
Contact:

Re: [3.2][3.3][RC] Attachments images rotation extension - dev/bugs logs

Post by axe70 »

Hi there!
Beside the last observation about to check what's can going wrong...

Over the audio/video (that will be only audio on first release, since i have the rush to release it) extension, that is quite ready and fully working as raw version into my localhost and very soon installed as example online, i note that (because i grab a piece of code for this extension, into this of image rotation)
file
/ext/w3all/imageattachrotation/styles/prosilver/template/event/overall_footer_body_after.html
on top there is this line:

Code: Select all

if( w3ReqMode == 'edit' || w3ReqMode == 'post' || w3ReqMode == 'reply'  ){
need to be switched into this:

Code: Select all

if( w3ReqMode == 'edit' || w3ReqMode == 'post' || w3ReqMode == 'reply' || w3ReqMode == 'compose' ){
So rotate image feature will be also available into pm, whenever images attachments allowed into private messages.
Tested fully working, without changing nothing else, since the html dom of the attachment panel is exactly the same all over phpBB.

The 1.0.3 on github has been updated on fly to fix this
https://github.com/axew3/phpBB-image-at ... s-rotation

when editing phpBB template files, may rebuild stale template is required, to make modifications take effect
Do not take me too serious
Anyway i do not like Discourse
Post Reply

Return to “Extensions in Development”