bug generating URL for cron.php

Get help with installation and running phpBB 3.0.x here. Please do not post bug reports, feature requests, or MOD-related questions here.
Suggested Hosts
Forum rules
END OF SUPPORT: 1 January 2017 (announcement)
Locked
benwilliams
Registered User
Posts: 6
Joined: Wed Jun 17, 2009 6:11 am

bug generating URL for cron.php

Post by benwilliams »

Support Request Template
What version of phpBB are you using? phpBB 3.0.8
What is your board's URL? http://forums.jadeworld.com
Who do you host your board with? inhouse
How did you install your board? I used the download package from phpBB.com
Is your board a fresh install or a conversion? Update from a previous version of phpBB3
Do you have any MODs installed? No
Is registration required to reproduce this issue? No
What version of phpBB3 did you update from? phpBB 3.0.7
What styles do you currently have installed? No answer given
What language(s) is your board currently using? No answer given
Which database type/version are you using? MySQL 5
What is your level of experience? Experienced with PHP and phpBB
When did your problem begin? After upgrade to phpBB 3.0.8
Please describe your problem. In certain conditions, phpBB is exposing the full path of cron.php. ie apache access log shows requests:
"GET /var/www/jadephpbb/httpdocs/cron.php?cron_type=tidy_search HTTP/1.1" 404 304 "https://forums.jadeworld.com/viewtopic. ... 06&start=0"

This does not happen all the time, mostly clients call the cron.php script correctly.
Generated by SRT Generator ($Rev: 4778 $)
Oleg
Former Team Member
Posts: 1221
Joined: Sat Jan 30, 2010 4:42 pm
Location: NYC
Contact:

Re: bug generating URL for cron.php

Post by Oleg »

Participate in phpBB development: Get involved | Issue tracker | Report a bug | Development board | [url=irc://chat.freenode.net/phpbb-dev]Development IRC chat[/url]
My stuff: mindlinkgame.com
User avatar
-=ET=-
Registered User
Posts: 799
Joined: Sun May 25, 2003 5:32 pm

Re: bug generating URL for cron.php

Post by -=ET=- »

Oleg wrote:I filed a ticket here: http://tracker.phpbb.com/browse/PHPBB3-10046
Hi,

Can u fix the link to the minimal fix for phpBB 3.0?
Thanks very much! :)
Eternal newbie
User avatar
4_seven
I've Been Banned!
Posts: 5155
Joined: Wed Apr 30, 2008 1:41 am

Re: bug generating URL for cron.php

Post by 4_seven »

Current Mods | Mod Base | php(BB) programming | No help via PM
Oleg
Former Team Member
Posts: 1221
Joined: Sat Jan 30, 2010 4:42 pm
Location: NYC
Contact:

Re: bug generating URL for cron.php

Post by Oleg »

A truly minimal fix would be:

1. on this line: https://github.com/phpbb/phpbb3/commit/ ... be55#L0L24 set $use_shutdown_function to false unconditionally (the rest of the changeset can be omitted)

2. https://github.com/phpbb/phpbb3/commit/ ... 369e23935c

I have not tested this - use at your own risk.
Participate in phpBB development: Get involved | Issue tracker | Report a bug | Development board | [url=irc://chat.freenode.net/phpbb-dev]Development IRC chat[/url]
My stuff: mindlinkgame.com
User avatar
-=ET=-
Registered User
Posts: 799
Joined: Sun May 25, 2003 5:32 pm

Re: bug generating URL for cron.php

Post by -=ET=- »

Ok thanks, I'll give it a try! :)
I have not tested this - use at your own risk.
But apart from the fact that it "may" not solve the issue, is there any other risk related to this proposal?
Eternal newbie
Oleg
Former Team Member
Posts: 1221
Joined: Sat Jan 30, 2010 4:42 pm
Location: NYC
Contact:

Re: bug generating URL for cron.php

Post by Oleg »

Since we are talking about altering cron, your cron may cease to function.

Commits merged into phpbb repository go through a peer review and are tested for proper functionality. In this case the testing is up to you. Apply the complete fix if you want a tested solution.
Participate in phpBB development: Get involved | Issue tracker | Report a bug | Development board | [url=irc://chat.freenode.net/phpbb-dev]Development IRC chat[/url]
My stuff: mindlinkgame.com
User avatar
-=ET=-
Registered User
Posts: 799
Joined: Sun May 25, 2003 5:32 pm

Re: bug generating URL for cron.php

Post by -=ET=- »

Oleg wrote:Apply the complete fix if you want a tested solution.
Complete fix is these 4 commits?
https://github.com/phpbb/phpbb3/pull/126

Or these ones (given as the "proper" fix in the comments)? :)
https://github.com/p/phpbb3/compare/dev ... et%2F10046
Eternal newbie
Oleg
Former Team Member
Posts: 1221
Joined: Sat Jan 30, 2010 4:42 pm
Location: NYC
Contact:

Re: bug generating URL for cron.php

Post by Oleg »

Participate in phpBB development: Get involved | Issue tracker | Report a bug | Development board | [url=irc://chat.freenode.net/phpbb-dev]Development IRC chat[/url]
My stuff: mindlinkgame.com
User avatar
-=ET=-
Registered User
Posts: 799
Joined: Sun May 25, 2003 5:32 pm

Re: bug generating URL for cron.php

Post by -=ET=- »

Oleg wrote:https://github.com/phpbb/phpbb3/pull/126 is the fix.

https://github.com/p/phpbb3/compare/dev ... et%2F10046 was an intermediate proposal that was rejected.
Ok thanks!

I've applied the simple fix first.
But I may apply the full fix as there's not so much more to do.
Since we are talking about altering cron, your cron may cease to function.
Ok. So one last question: how can I control if it's still working?
I mean, which functionality is using it, is to be tested?

FYI, at this stage the simple fix has indeed fixed the wrong URLs. Thanks!
But I would like to test that it has broken nothing else now :)

Thanks for your help, I appreciate!
Eternal newbie
User avatar
-=ET=-
Registered User
Posts: 799
Joined: Sun May 25, 2003 5:32 pm

Re: bug generating URL for cron.php

Post by -=ET=- »

-=ET=- wrote:Ok. So one last question: how can I control if it's still working?
I mean, which functionality is using cron.php, is to be tested?
Any direction to look at?
Thanks!
Eternal newbie
User avatar
Lumpy Burgertushie
Registered User
Posts: 68479
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: bug generating URL for cron.php

Post by Lumpy Burgertushie »

if the cron is running and doing it's job and you are getting no errors there is nothing more to test or worry about.

robert
I'm baaaaaccckkkk. still doing work on donation basis. PM your needs.

Premium phpBB 3.3 Styles by PlanetStyles.net

If nobody is in the forest, does a tree really fall?
Locked

Return to “[3.0.x] Support Forum”