Running the "normal" phpBB tests with my extension enabled

gothick · Post by **gothick** » Sun Sep 24, 2017 1:07 pm

Hi,

Is there a way of running the full, normal phpBB test suite with my extension activated? The extension I'm developing shouldn't really change anything in the normal "flow" of phpBB, so it struck me that it would be a good reassurance if I could run the phpBB tests with it enabled and make sure the results were the same as when it's not...

Thanks,

Matt

(PS: Sorry if this has been asked before; my Google-fu appears to be failing me today!)

Post by **Brf** » Mon Sep 25, 2017 12:05 am

What is a "full, normal phpBB test suite"?
What are "the results"?

gothick · Post by **gothick** » Mon Sep 25, 2017 5:46 am

Ah, sorry, perhaps an example might help. For example, if I pull the latest phpBB 3.2.x from git, install the composer dependencies, set up a functional testing URL in the appropriate environment variable and run:

Code: Select all

phpBB/vendor/bin/phpunit --group __nogroup__,functional

...it will run what I was thinking of as a "full, normal phpBB test suite". By "the results" I mean the output thereof (i.e. in a perfect world, the success of all tests.)

So what I'm saying is, having run that once, "out of the box", I'd like to run it again, with the only difference being that my extension is enabled, on the grounds that the results *should* be the same, but if I've written some bad code in my extension somehow, perhaps they won't be.

I'm wondering if there is a standard way of doing that.

Regards,

Matt

david63 · Post by **david63** » Mon Sep 25, 2017 6:31 am

Is this of any help? - https://area51.phpbb.com/docs/dev/3.2.x ... sting.html

gothick · Post by **gothick** » Mon Sep 25, 2017 6:37 am

david63 wrote: ↑Mon Sep 25, 2017 6:31 am Is this of any help? - https://area51.phpbb.com/docs/dev/3.2.x ... sting.html

Any particular bit you had in mind? It does mention how to make sure my extension is loaded when running my own functional tests, but that doesn't seem to give me a way of running phpBB's own tests with my extension enabled.

Matt

Post by **Brf** » Mon Sep 25, 2017 1:32 pm

gothick wrote: ↑Mon Sep 25, 2017 5:46 am
Code: Select all
phpBB/vendor/bin/phpunit --group __nogroup__,functional

Never heard of it. I am not even seeing that folder in the phpBB 3.2.1 download.

RMcGirr83 · Post by **RMcGirr83** » Mon Sep 25, 2017 1:49 pm

That's where the cli is

https://github.com/rmcgirr83/phpbb/tree ... /phpBB/bin

Elsensee · Post by **Elsensee** » Mon Sep 25, 2017 2:36 pm

I believe you are better up with asking this question on area51 discussion board. (for the future at least

)

Also I don't believe that this is possible. The default test suite doesn't know about extensions. So I believe you have to code your own tests, but there are examples in the repositories of the official extensions by the phpBB Extensions Team.

rxu · Post by **rxu** » Tue Sep 26, 2017 3:52 am

In theory, if you fork phpbb/phpbb repository, put your extension there and run tests, your extension should be enabled during tests (on phpBB installation step) so tests would run with the extension enabled.
It's not guaranteed though as phpBB seems to be handling this in some random way.

gothick · Post by **gothick** » Sun Oct 01, 2017 10:32 am

Thanks for the tips, all. I think it seems like this is an idea I should give up on

I'll just do my best to cover the places where I think my code could break the system, perhaps copying the core tests I need as I go...

Regards,

Matt