canonknipser wrote: ↑
Tue Jan 23, 2018 3:33 pm
Shouldn't there be a rule to force extension developers to implement a default value (or NULL) when adding new columns to tables in the core, eg. topic, post, users-table in their migration files?
Well, either that or allow NULL values.
To summarize the discussion:linked to by canonknipser: the cmBB extension - like some other extensions - creates a topic in an automated way. When a board also has the Topic Description extension, it throws
Column 'topic_desc' cannot be null 
That is because the Topic Description extension adds a column to the topics table with NOT NULL option, but also without a default value.
Apart from this specific case, the discussion boils down to the point where the responsibility is: the extension that adds a column to a default phpBB table (extension A) or any other extension to provide compatibility to said extension A?
In my opinion, it's an endless road to add checks to each extension to make sure about any other installed extension that does something to default tables. I think it makes more sense that when altering a default table all behaviour to cope with that change should be covered by the extension altering it. So in this case the proposal of canonknipser seems sound, but it might be broader than that.
RMcGirr83 wrote: ↑
Tue Jan 23, 2018 10:58 am
Poke to notify you of this discussion in general (not specific to the topic description)
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2
Like my work? Buy me a coffee
to keep it coming.
-Available for custom work-