Missing dependency

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Tue Jul 07, 2015 10:02 pm

$php_container should be provided as dependency for extensions. For example if you want to write something into the log you have to use globals inside the __construct.

Code: Select all

$this->phpbb_log = $GLOBALS['phpbb_container']->get('log');

rxu · Post by **rxu** » Wed Jul 08, 2015 2:38 am

You should just add the log dependency in that case.

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 7:44 am

Well said

https://wiki.phpbb.com/Dependency_list

there is nothing like a log dependency in the list... please now don't come and tell me that this exists and I had to look inside the phpBB sourcecode.

Post by **Marc** » Wed Jul 08, 2015 7:48 am

That dependency list is far from being complete. The main set of service can be found in services.yml:
https://github.com/phpbb/phpbb/blob/3.1 ... rvices.yml

Post by **Paul** » Wed Jul 08, 2015 7:56 am

cYbercOsmOnauT wrote:Well said

https://wiki.phpbb.com/Dependency_list

there is nothing like a log dependency in the list... please now don't come and tell me that this exists and I had to look inside the phpBB sourcecode.

If it didn't exists you wouldn't be able to ask it from the container

.

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 9:15 am

I am injecting the container into my event listener by using $GLOBALS. But this is not the secure way of getting a core method of phpBB into my script. This dependencies are there to make sure to get the objects one need in his event listener with the plus of type check like \phpbb\config\config $config.

When I use $GLOBALS (or global) I don't have this extra security. I have to believe that the object is what I really wanted. Even if you say The passing of dependencies in this way replaces the need of using global $var; in most cases. in your Wiki I believe that such core stuff should be available as dependency.

btw, the "Full Editor & Preview" button in your QuickReply here does not really work. I clicked it unintentionally twice and lost my whole posting because all I got was an empty full editor.

RMcGirr83 · Post by **RMcGirr83** » Wed Jul 08, 2015 10:11 am

No need to use globals

https://github.com/RMcGirr83/phpBB-3.1- ... es.yml#L16

https://github.com/RMcGirr83/phpBB-3.1- ... er.php#L45

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L102

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L118

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L167

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 10:25 am

Thanks RMcGirr83... but tell me one thing.. how can someone who does not sleep with the phpBB source know that there is such a dependency existing when it's not found in the wiki?

Anyways.. I will change my code and use the container the way you showed.

RMcGirr83 · Post by **RMcGirr83** » Wed Jul 08, 2015 10:34 am

cYbercOsmOnauT wrote:Thanks RMcGirr83... but tell me one thing.. how can someone who does not sleep with the phpBB source know that there is such a dependency existing when it's not found in the wiki?

By staying up until the wee hours of the night looking at code...like I did. I guess.

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 11:39 am

I guess you have no family to feed.

I have work to be done and code to be finished with less time to look inside a sourcecode of big project for hours. Documentation is eminent for bigger project.

Is there a place somewhere in the phpBB code where all these dependencies are set and we can see what is provided? Sorry but I am also no Symphony pro.

Post by **nicofuma** » Wed Jul 08, 2015 11:39 am

You can look at the files in the config directory or use my Debug Tools extension viewtopic.php?f=456&t=2253386

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 1:36 pm

Thanks for the hint nicofuma.

RMcGirr83: I did it the way you linked me. But now when I go to the configpage of my captcha extension I get to see

Catchable fatal error: Argument 7 passed to cosmo\peoplesign\captcha\peoplesign::__construct() must be an instance of \ContainerInterface, instance of phpbb_cache_container given, called in /var/www/dev/board/cache/container_dotslashdotdotslash.php on line 990

So back to globals I guess

Edit... now I see.. you forgot to mention that you injected the dependency on your own
use Symfony\Component\DependencyInjection\ContainerInterface;

Edit 2: After playing around I found the following solution.
https://github.com/cYbercOsmOnauT/phpbb ... es.yml#L13
https://github.com/cYbercOsmOnauT/phpbb ... gn.php#L80
https://github.com/cYbercOsmOnauT/phpbb ... gn.php#L99
https://github.com/cYbercOsmOnauT/phpbb ... n.php#L308

rxu · Post by **rxu** » Wed Jul 08, 2015 4:14 pm

"Edit 2" is the correct approach

cYbercOsmOnauT · Post by **cYbercOsmOnauT** » Wed Jul 08, 2015 8:35 pm

but nowhere documented

Khaos-Rage · Post by **Khaos-Rage** » Fri Jul 10, 2015 1:06 pm

cYbercOsmOnauT wrote:but nowhere documented

I think one could have just opened any of the other extensions (including the acme extension) to have figured this out?

Writing Extensions wrote:In phpBB 3.1 this has been implemented using the Symfony DependencyInjection Component. All services provided by phpBB are defined in a YAML format file at /config/services.yml. Extensions can use the services defined by phpBB as well as define their own services for their PHP classes in their own config/ directory.

https://github.com/phpbb/phpbb/blob/3.1 ... s.yml#L121

https://github.com/phpbb/phpbb-ext-acme ... ces.yml#L8

https://github.com/phpbb/phpbb-ext-acme ... in.php#L32

advertisements