Enable_super_globals in external scripts with included phpbb-files

Discussion forum for Extension Writers regarding Extension Development.
Post Reply
steve59
Registered User
Posts: 53
Joined: Mon Jun 01, 2015 9:32 am

Enable_super_globals in external scripts with included phpbb-files

Post by steve59 » Mon Oct 24, 2016 2:07 pm

Dear reader,

In php 3.1.x the super globals were deactivated but we need them for integration purposes,
for example: people registrate on our site outside phpbb (via an external script)

User input is collected via forms,
and to make our integration scripts work with phpbb we added:
$request->enable_super_globals();
at several places.

Immediately reverting to
$request->disable_super_globals();
in our scripts is difficult,
since files are included, form-data are transported between pages etcetera.

So, we don't revert al all, and simply use
$request->enable_super_globals();
whenever needed.

Is this safe? We only do it in external scripts, not directly on any pages of the phpbb-forum itself. I mean, on some pages we do include phpbb-files to make the integration work, but we never access those phpbb-files directly.
User input that we use in our scripts, like $_REQUEST variables, is sanitized via our own scripts.

So, this concerns scripts like this:

file "our-own_php", with for example in it:
<?php
--- some included phpbb-files ---
$request->enable_super_globals();
--- further scripts of ourselves with possible further includes---
--- end ---
?>

Best regards,
Steve

Post Reply

Return to “Extension Writers Discussion”